AbstractRequest::getTime() - Code Metrics - Inspection of "add APL support" - maxbeckers/amazon-alexa-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#97)

by Maximilian

created 2025-10-06 13:37 UTC

AbstractRequest::getTime() A

↳ Parent: AbstractRequest

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	1
dl	0
loc	12
ccs	6
cts	6
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace MaxBeckers\AmazonAlexa\Request\Request;

abstract class AbstractRequest
{
    /**
     * @param string $type Request type
     * @param ?\DateTime $timestamp Request timestamp
     */
    public function __construct(
        public string $type,
        public ?\DateTime $timestamp = null,
    ) {
    }

    abstract public static function fromAmazonRequest(array $amazonRequest): self;

    public function validateTimestamp(): bool
    {
        return true;
    }

    public function validateSignature(): bool
    {
        return true;
    }

    protected static function getTime(string|int|null $value): ?\DateTime
    {
        if ($value !== null) {
            // Workaround for amazon developer console sending unix timestamp
            try {
                return new \DateTime((string) $value);
            } catch (\Exception $e) {
                return (new \DateTime())->setTimestamp((int) ((string) ($value / 1000)));
            }
        }

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace MaxBeckers\AmazonAlexa\Request\Request;
6
7		abstract class AbstractRequest
8		{
9		/**
10		* @param string $type Request type
11		* @param ?\DateTime $timestamp Request timestamp
12		*/
13	62	public function __construct(
14		public string $type,
15		public ?\DateTime $timestamp = null,
16		) {
17	62	}
18
19		abstract public static function fromAmazonRequest(array $amazonRequest): self;
20
21	10	public function validateTimestamp(): bool
22		{
23	10	return true;
24		}
25
26	54	public function validateSignature(): bool
27		{
28	54	return true;
29		}
30
31	48	protected static function getTime(string\|int\|null $value): ?\DateTime
32		{
33	48	if ($value !== null) {
34		// Workaround for amazon developer console sending unix timestamp
35		try {
36	48	return new \DateTime((string) $value);
37	14	} catch (\Exception $e) {
38	14	return (new \DateTime())->setTimestamp((int) ((string) ($value / 1000)));
39		}
40		}
41
42	6	return null;
43		}
44		}
45

maxbeckers / amazon-alexa-php

Pull Request — master (#97)

AbstractRequest::getTime() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like