TodayCommand::handle() - Code Metrics - Inspection of "Added badges" - maxalmonte14/nfl-scores - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 652e57...3ec9c1 )

by Max

created 2018-10-30 19:37 UTC

TodayCommand::handle() A

↳ Parent: TodayCommand

Complexity

Conditions	3
Paths	6

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	10
nc	6
nop	0
dl	0
loc	17
ccs	0
cts	10
cp	0
crap	12
rs	9.9332
c	0
b	0
f	0

<?php

namespace NFLScores\Commands;

use DateTime;
use DateTimeZone;
use ErrorException;
use LaravelZero\Framework\Commands\Command;
use NFLScores\Http\NFLHttpClient;
use NFLScores\Models\NFL;
use NFLScores\Utilities\Printer;

class TodayCommand extends Command
{
    /**
     * The signature of the command.
     *
     * @var string
     */
    protected $signature = 'today';

    /**
     * The description of the command.
     *
     * @var string
     */
    protected $description = 'Show the scheduled games for today';

    /**
     * Execute the console command.
     *
     * @return void
     */
    public function handle(): void
    {
        $nfl = new NFL(new NFLHttpClient(), new DateTime('now', new DateTimeZone('US/Eastern')));

        try {
            $data = [];

            $todayGames = $nfl->getTodayGames();

            if (is_null($todayGames)) {
                exit($this->line('Sorry, there is no games scheduled for today.'));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }

            $printer = new Printer($this);

            $printer->renderGamesList($todayGames);
        } catch (ErrorException $e) {
            exit($this->line('Sorry, there was a problem fetching the remote data.'));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }
    }
}


1			<?php
2
3			namespace NFLScores\Commands;
4
5			use DateTime;
6			use DateTimeZone;
7			use ErrorException;
8			use LaravelZero\Framework\Commands\Command;
9			use NFLScores\Http\NFLHttpClient;
10			use NFLScores\Models\NFL;
11			use NFLScores\Utilities\Printer;
12
13			class TodayCommand extends Command
14			{
15			/**
16			* The signature of the command.
17			*
18			* @var string
19			*/
20			protected $signature = 'today';
21
22			/**
23			* The description of the command.
24			*
25			* @var string
26			*/
27			protected $description = 'Show the scheduled games for today';
28
29			/**
30			* Execute the console command.
31			*
32			* @return void
33			*/
34			public function handle(): void
35			{
36			$nfl = new NFL(new NFLHttpClient(), new DateTime('now', new DateTimeZone('US/Eastern')));
37
38			try {
39			$data = [];
			0 ignored issues – show Unused Code introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report The assignment to `$data` is dead and can be removed. Loading history...
40			$todayGames = $nfl->getTodayGames();
41
42			if (is_null($todayGames)) {
43			exit($this->line('Sorry, there is no games scheduled for today.'));
			0 ignored issues – show Bug introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->line('Sorry, ther... scheduled for today.')` targeting `Illuminate\Console\Command::line()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... Best Practice introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
44			}
45
46			$printer = new Printer($this);
47
48			$printer->renderGamesList($todayGames);
49			} catch (ErrorException $e) {
50			exit($this->line('Sorry, there was a problem fetching the remote data.'));
			0 ignored issues – show Best Practice introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Bug introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->line('Sorry, ther...hing the remote data.')` targeting `Illuminate\Console\Command::line()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
51			}
52			}
53			}
54

maxalmonte14 / nfl-scores

Push — master ( 652e57...3ec9c1 )

TodayCommand::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like