NFLScores\Commands\LiveCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	14	3

<?php

namespace NFLScores\Commands;

use DateTime;
use DateTimeZone;
use ErrorException;
use LaravelZero\Framework\Commands\Command;
use NFLScores\Http\NFLHttpClient;
use NFLScores\Models\NFL;
use NFLScores\Utilities\Printer;

class LiveCommand extends Command
{
    /**
     * The signature of the command.
     *
     * @var string
     */
    protected $signature = 'live {team?}';

    /**
     * The description of the command.
     *
     * @var string
     */
    protected $description = 'Show the current live games';

    /**
     * Execute the console command.
     *
     * @return void
     */
    public function handle(): void
    {
        $nfl = new NFL(new NFLHttpClient(), new DateTime('now', new DateTimeZone('US/Eastern')));

        try {
            $games = (!is_null($this->argument('team')))
                ? $nfl->getLiveGameByTeam($this->argument('team'))

It seems like $this->argument('team') can also be of type null and string[]; however, parameter $team of NFLScores\Models\NFL::getLiveGameByTeam() does only seem to accept string, maybe add an additional type check?

                : $nfl->getLiveGames();

            $printer = new Printer($this);

            $printer->renderScoreBoard($games);
        } catch (ErrorException $e) {
            exit($this->line('Sorry, there was a problem fetching the remote data.'));

Are you sure the usage of $this->line('Sorry, there was a problem fetching the remote data.') targeting Illuminate\Console\Command::line() seems to always return null.

Using exit here is not recommended.

        }
    }
}