TodayCommand::handle() - Code Metrics - Inspection of "Updated build" - maxalmonte14/nfl-scores - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3ec9c1...244937 )

by Max

created 2018-11-02 14:03 UTC

TodayCommand::handle() A

↳ Parent: TodayCommand

Complexity

Conditions	3
Paths	6

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.4746

Importance

Changes

Metric	Value
cc	3
eloc	8
nc	6
nop	0
dl	0
loc	14
ccs	5
cts	8
cp	0.625
crap	3.4746
rs	10
c	0
b	0
f	0

<?php

namespace NFLScores\Commands;

use ErrorException;
use NFLScores\Utilities\Printer;

class TodayCommand extends AbstractCommand
{
    /**
     * The signature of the command.
     *
     * @var string
     */
    protected $signature = 'today';

    /**
     * The description of the command.
     *
     * @var string
     */
    protected $description = 'Show the scheduled games for today';

    /**
     * Execute the console command.
     *
     * @return void
     */
    public function handle(): void
    {
        try {
            $todayGames = $this->NFL->getTodayGames();

            if (is_null($todayGames)) {
                exit($this->line('Sorry, there is no games scheduled for today.'));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }

            $printer = new Printer($this);

            $printer->renderGamesList($todayGames);
        } catch (ErrorException $e) {
            exit($this->line('Sorry, there was a problem fetching the remote data.'));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }
    }
}


1		<?php
2
3		namespace NFLScores\Commands;
4
5		use ErrorException;
6		use NFLScores\Utilities\Printer;
7
8		class TodayCommand extends AbstractCommand
9		{
10		/**
11		* The signature of the command.
12		*
13		* @var string
14		*/
15		protected $signature = 'today';
16
17		/**
18		* The description of the command.
19		*
20		* @var string
21		*/
22		protected $description = 'Show the scheduled games for today';
23
24		/**
25		* Execute the console command.
26		*
27		* @return void
28		*/
29	1	public function handle(): void
30		{
31		try {
32	1	$todayGames = $this->NFL->getTodayGames();
33
34	1	if (is_null($todayGames)) {
35		exit($this->line('Sorry, there is no games scheduled for today.'));
		0 ignored issues – show Best Practice introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Bug introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->line('Sorry, ther... scheduled for today.')` targeting `Illuminate\Console\Command::line()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
36		}
37
38	1	$printer = new Printer($this);
39
40	1	$printer->renderGamesList($todayGames);
41		} catch (ErrorException $e) {
42		exit($this->line('Sorry, there was a problem fetching the remote data.'));
		0 ignored issues – show Best Practice introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Bug introduced 2018-10-30 19:41 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->line('Sorry, ther...hing the remote data.')` targeting `Illuminate\Console\Command::line()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
43		}
44	1	}
45		}
46

maxalmonte14 / nfl-scores

Push — master ( 3ec9c1...244937 )

TodayCommand::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like