mav3rick177\RapidPagination\Base\Query\SelectOrUnionAll::create()

Complexity

Conditions	6
Paths	4

Size

Total Lines

21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	6

Importance

Changes

0

<?php
    public static function create(array $orders, $cursor, Limit $limit, Direction $direction, $exclusive, $seekable)
    {
        $cursor = $cursor instanceof Cursor ? $cursor : new ArrayCursor($cursor);
        $mainQuery = new Select(
            $cursor->has() ? ConditionGroup::createMany($orders, $cursor, $direction, $exclusive) : [],
            $direction->backward()
                ? array_map(static function (Order $order) {
                    return $order->inverse();
                }, $orders)
                : $orders,
            $limit
        );

        if (!$cursor->has() || !$seekable) {

The expression $cursor->has() of type null|boolean is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            // We don't need UNION ALL and support query when cursor parameters are empty,
            // or it does not need to be seekable.
            return $mainQuery;
        }

        return new UnionAll($mainQuery);
    }
}