Issues (3627)

WebhookBundle/Controller/WebhookController.php (3 issues)

Checks if the types of returned expressions are compatible with the documented types.

Best Practice Bug Major
1
<?php
2
3
/*
4
 * @copyright   2014 Mautic Contributors. All rights reserved
5
 * @author      Mautic
6
 *
7
 * @link        http://mautic.org
8
 *
9
 * @license     GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html
10
 */
11
12
namespace Mautic\WebhookBundle\Controller;
13
14
use Mautic\CoreBundle\Controller\FormController;
15
16
/**
17
 * Class WebhookController.
18
 */
19
class WebhookController extends FormController
20
{
21
    public function __construct()
22
    {
23
        $this->setStandardParameters(
24
            'webhook.webhook', // model name
25
            'webhook:webhooks', // permission base
26
            'mautic_webhook', // route base
27
            'mautic_webhook', // session base
28
            'mautic.webhook', // lang string base
29
            'MauticWebhookBundle:Webhook', // template base
30
            'mautic_webhook', // activeLink
31
            'mauticWebhook' // mauticContent
32
        );
33
    }
34
35
    /**
36
     * @param int $page
37
     *
38
     * @return \Symfony\Component\HttpFoundation\JsonResponse|\Symfony\Component\HttpFoundation\RedirectResponse
39
     */
40
    public function indexAction($page = 1)
41
    {
42
        return parent::indexStandard($page);
43
    }
44
45
    /**
46
     * Generates new form and processes post data.
47
     *
48
     * @return \Symfony\Component\HttpFoundation\JsonResponse
49
     */
50
    public function newAction()
51
    {
52
        return parent::newStandard();
0 ignored issues
show
Bug Best Practice introduced by
The expression return parent::newStandard() also could return the type Symfony\Component\HttpFo...\RedirectResponse|array which is incompatible with the documented return type Symfony\Component\HttpFoundation\JsonResponse.
Loading history...
53
    }
54
55
    /**
56
     * Generates edit form and processes post data.
57
     *
58
     * @param int  $objectId
59
     * @param bool $ignorePost
60
     *
61
     * @return \Symfony\Component\HttpFoundation\JsonResponse
62
     */
63
    public function editAction($objectId, $ignorePost = false)
64
    {
65
        return parent::editStandard($objectId, $ignorePost);
0 ignored issues
show
Bug Best Practice introduced by
The expression return parent::editStand...$objectId, $ignorePost) also could return the type Symfony\Component\HttpFoundation\RedirectResponse which is incompatible with the documented return type Symfony\Component\HttpFoundation\JsonResponse.
Loading history...
66
    }
67
68
    /**
69
     * Displays details on a Focus.
70
     *
71
     * @param $objectId
72
     *
73
     * @return array|\Symfony\Component\HttpFoundation\JsonResponse|\Symfony\Component\HttpFoundation\RedirectResponse
74
     */
75
    public function viewAction($objectId)
76
    {
77
        return parent::viewStandard($objectId, 'webhook', 'webhook');
78
    }
79
80
    /**
81
     * Clone an entity.
82
     *
83
     * @param int $objectId
84
     *
85
     * @return \Symfony\Component\HttpFoundation\JsonResponse|\Symfony\Component\HttpFoundation\RedirectResponse
86
     */
87
    public function cloneAction($objectId)
88
    {
89
        return parent::cloneStandard($objectId);
0 ignored issues
show
Bug Best Practice introduced by
The expression return parent::cloneStandard($objectId) also could return the type array which is incompatible with the documented return type Symfony\Component\HttpFo...dation\RedirectResponse.
Loading history...
90
    }
91
92
    /**
93
     * Deletes the entity.
94
     *
95
     * @param int $objectId
96
     *
97
     * @return \Symfony\Component\HttpFoundation\JsonResponse|\Symfony\Component\HttpFoundation\RedirectResponse
98
     */
99
    public function deleteAction($objectId)
100
    {
101
        return parent::deleteStandard($objectId);
102
    }
103
104
    /**
105
     * Deletes a group of entities.
106
     *
107
     * @return \Symfony\Component\HttpFoundation\JsonResponse|\Symfony\Component\HttpFoundation\RedirectResponse
108
     */
109
    public function batchDeleteAction()
110
    {
111
        return parent::batchDeleteStandard();
112
    }
113
}
114