mautic / mautic

app/bundles/EmailBundle/Swiftmailer/Sparkpost/SparkpostFactory.php

<?php

namespace Mautic\EmailBundle\Swiftmailer\Sparkpost;

use Http\Adapter\Guzzle6\Client as GuzzleAdapter;
use SparkPost\SparkPost;

final class SparkpostFactory implements SparkpostFactoryInterface
{
    /**
     * @var GuzzleAdapter
     */
    private $client;

    public function __construct(GuzzleAdapter $client)
    {
        $this->client = $client;
    }

    /**
     * @param string   $host
     * @param string   $apiKey
     * @param int|null $port
     *
     * @return SparkPost
     */
    public function create($host, $apiKey, $port = null)
    {
        if ((false === strpos($host, '://') && '/' != substr($host, 0, 1))) {
            $host = 'https://'.$host;
        }

        $options = [
            'key' => ($apiKey) ?: 1234, // prevent Exception: You must provide an API key
        ];

        if ($port) {
            $options['port'] = $port;
        }

        $hostInfo = parse_url($host);
        if ($hostInfo) {

The expression $hostInfo of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $options['protocol'] =  $hostInfo['scheme'];

            if (empty($port)) {
                $options['port'] = 'https' === $hostInfo['scheme'] ? 443 : 80;
            }

            $host = $hostInfo['host'];
            if (isset($hostInfo['path'])) {
                $path = $hostInfo['path'];
                if (preg_match('~/api/(v\d+)$~i', $path, $matches)) {
                    // Remove /api from the path and extract the version in case differnt than the Sparkpost SDK default
                    $path               = str_replace($matches[0], '', $path);
                    $options['version'] = $matches[1];
                }

                // Append whatever is left over to the host (assuming Momentum can be in a subfolder?)
                if ('/' !== $path) {
                    $host .= $path;
                }
            }

            $options['host'] = $host;
        }

        // Must always return a SparkPost host or else Symfony will fail to build the container if host is empty
        return new SparkPost($this->client, $options);
    }
}