mautic / mautic

app/bundles/CoreBundle/Helper/FilePathResolver.php

<?php

/**
 * @copyright   2014 Mautic Contributors. All rights reserved
 * @author      Mautic
 *
 * @see         http://mautic.org
 *
 * @license     GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Mautic\CoreBundle\Helper;

use Mautic\CoreBundle\Exception\FilePathException;
use Symfony\Component\Filesystem\Exception\IOException;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\HttpFoundation\File\UploadedFile;

class FilePathResolver
{
    private $filesystem;

    private $inputHelper;

    public function __construct(Filesystem $filesystem, InputHelper $inputHelper)
    {
        $this->filesystem  = $filesystem;
        $this->inputHelper = $inputHelper;
    }

    /**
     * @param string $uploadDir
     *
     * @return string
     *
     * @throws FilePathException
     */
    public function getUniqueFileName($uploadDir, UploadedFile $file)
    {
        $inputHelper       = $this->inputHelper;
        $fullName          = $file->getClientOriginalName();
        $fullNameSanitized = $inputHelper::filename($fullName);
        $ext               = $this->getFileExtension($file);
        $baseFileName      = pathinfo($fullNameSanitized, PATHINFO_FILENAME);
        $name              = $baseFileName;
        $filePath          = $this->getFilePath($uploadDir, $baseFileName, $ext);
        $i                 = 1;

        while ($this->filesystem->exists($filePath)) {
            $name     = $baseFileName.'-'.$i;

Are you sure $baseFileName of type array|string can be used in concatenation?

            $filePath = $this->getFilePath($uploadDir, $name, $ext);
            ++$i;

            if ($i > 1000) {
                throw new FilePathException('Could not generate path');
            }
        }

        return $name.$ext;

Are you sure $name of type array|string can be used in concatenation?

    }

    /**
     * @param string $directory
     *
     * @throws FilePathException
     */
    public function createDirectory($directory)
    {
        if ($this->filesystem->exists($directory)) {
            return;
        }
        try {
            $this->filesystem->mkdir($directory);
        } catch (IOException $e) {
            throw new FilePathException('Could not create directory');
        }
    }

    /**
     * @param string $path
     */
    public function delete($path)
    {
        if (!$this->filesystem->exists($path)) {
            return;
        }
        try {
            $this->filesystem->remove($path);
        } catch (IOException $e) {

Consider adding a comment why this CATCH block is empty.

        }
    }

    public function move(string $originPath, string $targetPath): void
    {
        $this->filesystem->rename($originPath, $targetPath);
    }

    /**
     * @param string $uploadDir
     * @param string $fileName
     * @param string $ext
     *
     * @return string
     */
    private function getFilePath($uploadDir, $fileName, $ext)
    {
        return $uploadDir.DIRECTORY_SEPARATOR.$fileName.$ext;
    }

    /**
     * @return string
     */
    private function getFileExtension(UploadedFile $file)
    {
        $ext = $file->getClientOriginalExtension();

        return ('' === $ext ? '' : '.').$ext;
    }
}