mautic / mautic

app/bundles/CampaignBundle/Entity/SlaveConnectionTrait.php

<?php

/*
 * @copyright   2018 Mautic Contributors. All rights reserved
 * @author      Mautic, Inc.
 *
 * @link        https://mautic.org
 *
 * @license     GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Mautic\CampaignBundle\Entity;

use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Connections\MasterSlaveConnection;
use Mautic\CampaignBundle\Executioner\ContactFinder\Limiter\ContactLimiter;

/**
 * Trait SlaveConnectionTrait.
 */
trait SlaveConnectionTrait
{
    /**
     * Get a connection, preferring a slave connection if available and prudent.
     *
     * If a query is being executed with a limiter with specific contacts
     * then this could be a real-time request being handled so we should avoid forcing a slave connection.
     *
     * @return Connection
     */
    private function getSlaveConnection(ContactLimiter $limiter = null)
    {
        /** @var Connection $connection */
        $connection = $this->getEntityManager()->getConnection();

It seems like getEntityManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($connection instanceof MasterSlaveConnection) {
            if (
                !$limiter
                || !($limiter->getContactId() || $limiter->getContactIdList())

The expression $limiter->getContactId() of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            ) {
                $connection->connect('slave');
            }
        }

        return $connection;
    }
}