mautic / mautic

app/bundles/ApiBundle/Security/OAuth1/Authentication/Provider/OAuthProvider.php

<?php

/*
 * @copyright   2014 Mautic Contributors. All rights reserved
 * @author      Mautic
 *
 * @link        http://mautic.org
 *
 * @license     GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Mautic\ApiBundle\Security\OAuth1\Authentication\Provider;

use Bazinga\OAuthServerBundle\Security\Authentification\Token\OAuthToken;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Exception\AuthenticationException;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * Class OAuthProvider.
 */
class OAuthProvider extends \Bazinga\OAuthServerBundle\Security\Authentification\Provider\OAuthProvider
{
    /**
     * @var \Symfony\Bundle\FrameworkBundle\Translation\Translator
     */
    private $translator;

    public function setTranslator(TranslatorInterface $translator)
    {
        $this->translator = $translator;

$translator is of type Symfony\Component\Translation\TranslatorInterface, but the property $translator was declared to be of type Symfony\Bundle\FrameworkBundle\Translation\Translator. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * {@inheritdoc}
     */
    public function authenticate(TokenInterface $token)
    {
        if (!$this->supports($token)) {
            return null;
        }

        $requestParameters = $token->getRequestParameters();
        $requestMethod     = $token->getRequestMethod();
        $requestUrl        = $token->getRequestUrl();

        if ($this->serverService->validateRequest($requestParameters, $requestMethod, $requestUrl)) {
            $accessToken = $this->tokenProvider->loadAccessTokenByToken($requestParameters['oauth_token']);
            $user        = $accessToken->getUser();

            if (null !== $user) {
                //Recreate token to include user roles in order to be able to avoid CSRF checks with forms
                $token = new OAuthToken($user->getRoles());
                $token->setRequestParameters($requestParameters);
                $token->setRequestMethod($requestMethod);
                $token->setRequestUrl($requestUrl);
                $token->setAuthenticated(true);
                $token->setUser($user);
            }

            return $token;
        }

        throw new AuthenticationException($this->translator->trans('mautic.api.oauth.auth.failed'));
    }

    /**
     * {@inheritdoc}
     */
    public function supports(TokenInterface $token)
    {
        return $token instanceof OAuthToken;
    }
}