App\Service\BaseService

Complexity

Total Complexity

18

Size/Duplication

Total Lines	132
Duplicated Lines	12.12 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	validateInputOnCreateUser()	0	13	3
B	validateInputOnUpdateUser()	0	16	5
A	validateInputOnCreateTask()	0	13	4
A	validateName()	8	8	2
A	validateEmail()	0	9	2
A	validateTaskName()	8	8	2

<?php

namespace App\Service;

use Respect\Validation\Validator as v;

/**
 * Base Service.
 */
abstract class BaseService
{
    const USER_NOT_FOUND = 'El usuario solicitado no existe.';
    const USER_NAME_NOT_FOUND = 'No se encontraron usuarios con ese nombre.';
    const USER_NAME_REQUIRED = 'Ingrese el nombre del usuario.';
    const USER_INFO_REQUIRED = 'Ingrese los datos a actualizar del usuario.';
    const USER_DELETED = 'El usuario fue eliminado correctamente.';
    const USER_NAME_INVALID = 'El nombre ingresado es incorrecto.';
    const USER_EMAIL_INVALID = 'El email ingresado es incorrecto.';

    const TASK_NOT_FOUND = 'La tarea solicitada no existe.';
    const TASK_NAME_NOT_FOUND = 'No se encontraron tareas con ese nombre.';
    const TASK_NAME_REQUIRED = 'Ingrese el nombre de la tarea.';
    const TASK_INFO_REQUIRED = 'Ingrese los datos a actualizar de la tarea.';
    const TASK_DELETED = 'La tarea fue eliminada correctamente.';
    const TASK_NAME_INVALID = 'La tarea ingresada es incorrecta.';
    const TASK_STATUS_INVALID = 'El estado ingresado es incorrecto.';

    protected $database;
    protected $request;
    protected $response;
    protected $args;

    /**
     * Validate and sanitize input data when create new user.
     *
     * @param array $input
     * @return string
     * @throws \Exception
     */
    protected function validateInputOnCreateUser($input)
    {
        if (!isset($input['name'])) {
            throw new \Exception(self::USER_NAME_REQUIRED, 400);
        }
        $name = $this->validateName($input['name']);
        $email = null;
        if (isset($input['email'])) {
            $email = $this->validateEmail($input['email']);
        }

        return ['name' => $name, 'email' => $email];
    }

    /**
     * Validate and sanitize input data when update a user.
     *
     * @param array $input
     * @param object $user
     * @return string
     * @throws \Exception
     */
    protected function validateInputOnUpdateUser($input, $user)
    {
        if (!isset($input['name']) && !isset($input['email'])) {
            throw new \Exception(self::USER_INFO_REQUIRED, 400);
        }
        $name = $user->name;
        if (isset($input['name'])) {
            $name = $this->validateName($input['name']);
        }
        $email = $user->email;
        if (isset($input['email'])) {
            $email = $this->validateEmail($input['email']);
        }

        return ['name' => $name, 'email' => $email];
    }

    /**
     * Validate and sanitize input data when create new user.
     *
     * @param array $input
     * @return string
     * @throws \Exception
     */
    protected function validateInputOnCreateTask($input)
    {
        if (empty($input['task'])) {
            throw new \Exception(self::TASK_NAME_REQUIRED, 400);
        }
        $task = $this->validateTaskName($input['task']);
        $status = isset($input['status']) ? $input['status'] : 0;
        if (!v::numeric()->between(0, 1)->validate($status)) {
            throw new \Exception(self::TASK_STATUS_INVALID, 400);
        }

        return ['task' => $task, 'status' => $status];
    }

    /**
     * Validate and sanitize a username.
     *
     * @param string $name
     * @return string
     * @throws \Exception
     */
    protected function validateName($name)

This method seems to be duplicated in your project.

    {
        if (!v::alnum()->length(2, 100)->validate($name)) {
            throw new \Exception(self::USER_NAME_INVALID, 400);
        }

        return $name;
    }

    /**
     * Validate and sanitize a email address.
     *
     * @param string $emailValue
     * @return string
     * @throws \Exception
     */
    protected function validateEmail($emailValue)
    {
        $email = filter_var($emailValue, FILTER_SANITIZE_EMAIL);
        if (!v::email()->validate($email)) {
            throw new \Exception(self::USER_EMAIL_INVALID, 400);
        }

        return $email;
    }

    protected function validateTaskName($name)

This method seems to be duplicated in your project.

    {
        if (!v::alnum()->length(2, 100)->validate($name)) {
            throw new \Exception(self::TASK_NAME_INVALID, 400);
        }

        return $name;
    }
}