Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | View Code Duplication | class UserController extends BaseController |
|
| 12 | { |
||
| 13 | /** |
||
| 14 | * Get all users. |
||
| 15 | * |
||
| 16 | * @param Request $request |
||
| 17 | * @param Response $response |
||
| 18 | * @param array $args |
||
| 19 | * @return array |
||
| 20 | */ |
||
| 21 | public function getUsers($request, $response, $args) |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Get one user by id. |
||
| 32 | * |
||
| 33 | * @param Request $request |
||
| 34 | * @param Response $response |
||
| 35 | * @param array $args |
||
| 36 | * @return array |
||
| 37 | */ |
||
| 38 | public function getUser($request, $response, $args) |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Search users by name. |
||
| 53 | * |
||
| 54 | * @param Request $request |
||
| 55 | * @param Response $response |
||
| 56 | * @param array $args |
||
| 57 | * @return array |
||
| 58 | */ |
||
| 59 | public function searchUsers($request, $response, $args) |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Create a user. |
||
| 74 | * |
||
| 75 | * @param Request $request |
||
| 76 | * @param Response $response |
||
| 77 | * @param array $args |
||
| 78 | * @return array |
||
| 79 | */ |
||
| 80 | public function createUser($request, $response, $args) |
||
| 93 | |||
| 94 | /** |
||
| 95 | * Update a user. |
||
| 96 | * |
||
| 97 | * @param Request $request |
||
| 98 | * @param Response $response |
||
| 99 | * @param array $args |
||
| 100 | * @return array |
||
| 101 | */ |
||
| 102 | public function updateUser($request, $response, $args) |
||
| 114 | |||
| 115 | /** |
||
| 116 | * Delete a user. |
||
| 117 | * |
||
| 118 | * @param Request $request |
||
| 119 | * @param Response $response |
||
| 120 | * @param array $args |
||
| 121 | * @return array |
||
| 122 | */ |
||
| 123 | public function deleteUser($request, $response, $args) |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Constructor of the class. |
||
| 138 | * |
||
| 139 | * @param \Slim\Container $container |
||
| 140 | */ |
||
| 141 | public function __construct(\Slim\Container $container) |
||
| 146 | } |
||
| 147 |