Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | View Code Duplication | class TaskController extends BaseController |
|
| 12 | { |
||
| 13 | /** |
||
| 14 | * Constructor of the class. |
||
| 15 | * |
||
| 16 | * @param \Slim\Container $container |
||
| 17 | */ |
||
| 18 | public function __construct(\Slim\Container $container) |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Get all tasks. |
||
| 26 | * |
||
| 27 | * @param Request $request |
||
| 28 | * @param Response $response |
||
| 29 | * @param array $args |
||
| 30 | * @return array |
||
| 31 | */ |
||
| 32 | public function getTasks($request, $response, $args) |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Get one task by id. |
||
| 43 | * |
||
| 44 | * @param Request $request |
||
| 45 | * @param Response $response |
||
| 46 | * @param array $args |
||
| 47 | * @return array |
||
| 48 | */ |
||
| 49 | public function getTask($request, $response, $args) |
||
| 61 | |||
| 62 | /** |
||
| 63 | * Search tasks by name. |
||
| 64 | * |
||
| 65 | * @param Request $request |
||
| 66 | * @param Response $response |
||
| 67 | * @param array $args |
||
| 68 | * @return array |
||
| 69 | */ |
||
| 70 | public function searchTasks($request, $response, $args) |
||
| 82 | |||
| 83 | /** |
||
| 84 | * Create a task. |
||
| 85 | * |
||
| 86 | * @param Request $request |
||
| 87 | * @param Response $response |
||
| 88 | * @param array $args |
||
| 89 | * @return array |
||
| 90 | */ |
||
| 91 | public function createTask($request, $response, $args) |
||
| 104 | |||
| 105 | /** |
||
| 106 | * Update a task. |
||
| 107 | * |
||
| 108 | * @param Request $request |
||
| 109 | * @param Response $response |
||
| 110 | * @param array $args |
||
| 111 | * @return array |
||
| 112 | */ |
||
| 113 | public function updateTask($request, $response, $args) |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Delete a task. |
||
| 128 | * |
||
| 129 | * @param Request $request |
||
| 130 | * @param Response $response |
||
| 131 | * @param array $args |
||
| 132 | * @return array |
||
| 133 | */ |
||
| 134 | public function deleteTask($request, $response, $args) |
||
| 146 | } |
||
| 147 |