Issues in UpdateTask.php - All Issues - Inspection of "Test Test..." - maurobonfietti/api-rest-slimphp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 83447c...2e155a )

by Mauro

created 2018-08-12 03:08 UTC

src/Controller/Task/UpdateTask.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Controller\Task;

use Slim\Http\Request;
use Slim\Http\Response;

/**
 * Update Task Controller.
 */
class UpdateTask extends BaseTask

{
    /**
     * Update a task.
     *
     * @param Request $request
     * @param Response $response
     * @param array $args
     * @return Response
     */
    public function __invoke($request, $response, $args)
    {
        $this->setParams($request, $response, $args);
        $input = $this->getInput();
        $taskId = $this->args['id'];
        $result = $this->getTaskService()->updateTask($input, $taskId);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return $this->jsonResponse('success', $result, 200);
    }
}


1		<?php
2
3		namespace App\Controller\Task;
4
5		use Slim\Http\Request;
6		use Slim\Http\Response;
7
8		/**
9		* Update Task Controller.
10		*/
11	View Code Duplication	class UpdateTask extends BaseTask
		0 ignored issues – show Duplication introduced 2018-01-28 17:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		/**
14		* Update a task.
15		*
16		* @param Request $request
17		* @param Response $response
18		* @param array $args
19		* @return Response
20		*/
21		public function __invoke($request, $response, $args)
22		{
23		$this->setParams($request, $response, $args);
24		$input = $this->getInput();
25		$taskId = $this->args['id'];
26		$result = $this->getTaskService()->updateTask($input, $taskId);
		0 ignored issues – show Bug introduced 2018-07-15 18:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$input` defined by `$this->getInput()` on line `24` can also be of type `null` or `object`; however, `App\Service\TaskService::updateTask()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
27
28		return $this->jsonResponse('success', $result, 200);
29		}
30		}
31

maurobonfietti / api-rest-slimphp

Push — master ( 83447c...2e155a )

src/Controller/Task/UpdateTask.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like