FinderTest - Code Metrics - Inspection of "Tests, Interfaces, Large files" - mauro-moreno/find-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Mauro

created 2016-02-04 01:13 UTC

FinderTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	5
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	74
rs	10

5 Methods

Rating	Name	Size	Complexity
A	setUp()	6	1
A	testFindWrongParameterPattern()	7	1
A	testFindWrongParameterFileInfo()	7	1
A	testFindNotFound()	9	1
A	testFindOk()	12	1

<?php
/**
 * Class FinderTest
 *
 * @author Mauro Moreno <[email protected]>
 */
namespace MauroMoreno\FindBundle\Tests\Services;

use MauroMoreno\FindBundle\Service\Finder;

/**
 * Class FinderTest
 * @package MauroMoreno\FindBundle\Tests\Services
 */
class FinderTest extends \PHPUnit_Framework_TestCase
{

    /**
     * @var Finder
     */
    private $finder;

    /**
     * Set up
     */
    public function setUp()
    {
        parent::setUp();

        $this->finder = new Finder();
    }

    /**
     * Test find, wrong parameter pattern
     *
     * @expectedException \InvalidArgumentException
     */
    public function testFindWrongParameterPattern()
    {
        $found = $this->finder->find(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
           [],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new \SplFileInfo(__DIR__ . '/../Fixtures/directory/file_2')
        );
    }

    /**
     * Test find, wrong parameter fileInfo
     *
     * @expectedException \TypeError
     */
    public function testFindWrongParameterFileInfo()
    {
        $found = $this->finder->find(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            'pattern',
            'bad_parameter'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    /**
     * Test find, not found
     */
    public function testFindNotFound()
    {
        $found = $this->finder->find(
            'pattern',
            new \SplFileInfo(__DIR__ . '/../Fixtures/directory/file_2')
        );

        $this->assertEquals($found, false);
    }

    /**
     * Test find Ok
     */
    public function testFindOk()
    {
        $file_info = new \SplFileInfo(
            __DIR__ . '/../Fixtures/directory/file_1'
        );
        $found = $this->finder->find(
            'pattern',
            $file_info
        );

        $this->assertEquals($found, $file_info);
    }

}

1			<?php
2			/**
3			* Class FinderTest
4			*
5			* @author Mauro Moreno <[email protected]>
6			*/
7			namespace MauroMoreno\FindBundle\Tests\Services;
8
9			use MauroMoreno\FindBundle\Service\Finder;
10
11			/**
12			* Class FinderTest
13			* @package MauroMoreno\FindBundle\Tests\Services
14			*/
15			class FinderTest extends \PHPUnit_Framework_TestCase
16			{
17
18			/**
19			* @var Finder
20			*/
21			private $finder;
22
23			/**
24			* Set up
25			*/
26			public function setUp()
27			{
28			parent::setUp();
29
30			$this->finder = new Finder();
31			}
32
33			/**
34			* Test find, wrong parameter pattern
35			*
36			* @expectedException \InvalidArgumentException
37			*/
38			public function testFindWrongParameterPattern()
39			{
40			$found = $this->finder->find(
			0 ignored issues – show Unused Code introduced 2016-02-04 01:26 UTC by Report Bug Copy Issue Report `$found` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
41			[],
			0 ignored issues – show Documentation introduced 2016-02-04 01:26 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			new \SplFileInfo(__DIR__ . '/../Fixtures/directory/file_2')
43			);
44			}
45
46			/**
47			* Test find, wrong parameter fileInfo
48			*
49			* @expectedException \TypeError
50			*/
51			public function testFindWrongParameterFileInfo()
52			{
53			$found = $this->finder->find(
			0 ignored issues – show Unused Code introduced 2016-02-04 01:26 UTC by Report Bug Copy Issue Report `$found` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54			'pattern',
55			'bad_parameter'
			0 ignored issues – show Documentation introduced 2016-02-04 01:26 UTC by Report Bug Copy Issue Report `'bad_parameter'` is of type `string`, but the function expects a `object<SplFileInfo>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
56			);
57			}
58
59			/**
60			* Test find, not found
61			*/
62			public function testFindNotFound()
63			{
64			$found = $this->finder->find(
65			'pattern',
66			new \SplFileInfo(__DIR__ . '/../Fixtures/directory/file_2')
67			);
68
69			$this->assertEquals($found, false);
70			}
71
72			/**
73			* Test find Ok
74			*/
75			public function testFindOk()
76			{
77			$file_info = new \SplFileInfo(
78			__DIR__ . '/../Fixtures/directory/file_1'
79			);
80			$found = $this->finder->find(
81			'pattern',
82			$file_info
83			);
84
85			$this->assertEquals($found, $file_info);
86			}
87
88			}

mauro-moreno / find-bundle

Pull Request — master (#11)

FinderTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like