SimpleEventStoreManager\Infrastructure\DataTransformers\XmlEventDataTransformer::transform()

Complexity

Conditions	3
Paths	4

Size

Total Lines	33
Code Lines	21

Duplication

Lines	5
Ratio	15.15 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function transform($events, $eventsCount, $page, $maxPerPage)
    {
        $pageCount = count($events);
        $eventsCollection = new EventCollectionObjectRepresentation(
            (int) $page,
            (int) $maxPerPage,
            (int) $numberOfPages = ceil($eventsCount/$maxPerPage),
            (int) $eventsCount,
            $this->calculateLinks($page, $numberOfPages)

$numberOfPages of type double is incompatible with the type integer expected by parameter $numberOfPages of SimpleEventStoreManager\Infrastructure\DataTransformers\AbstractEventDataTransformer::calculateLinks().

        );
        foreach ($events as $event) {
            $eventsCollection->addEvent(new EventObjectRepresentation($event));
        }

        $response = new Response(
            $this->serializer->serialize(
                [
                    $eventsCollection
                ], 'xml'),
            $this->getHttpStatusCode($pageCount)
        );

        $response->headers->set('Content-type', 'text/xml');
        $response->setCharset('utf-8');

        // set infinite cache if page is complete
        if ($maxPerPage === $pageCount) {

This code seems to be duplicated across your project.

            $response
                ->setMaxAge(60 * 60 * 24 * 365)
                ->setSharedMaxAge(60 * 60 * 24 * 365);
        }

        return $response;
    }