SimpleEventStoreManager\Infrastructure\DataTransformers\JsonEventDataTransformer::transform()

Complexity

Conditions	3
Paths	2

Size

Total Lines	30
Code Lines	19

Duplication

Lines	5
Ratio	16.67 %

Importance

Changes

0

<?php
    public function transform($events, $eventsCount, $page, $maxPerPage)
    {
        $pageCount = count($events);
        $jsonResponse = new JsonResponse(
            $this->serializer->serialize(
                [
                    '_meta' => [
                        'page' => $page,
                        'records_per_page' => $maxPerPage,
                        'total_pages' => $numberOfPages = ceil($eventsCount/$maxPerPage),
                        'total_count' => $eventsCount
                    ],
                    '_links' => [
                        $this->calculateLinks($page, $numberOfPages)

$numberOfPages of type double is incompatible with the type integer expected by parameter $numberOfPages of SimpleEventStoreManager\Infrastructure\DataTransformers\AbstractEventDataTransformer::calculateLinks().

                    ],
                    'events' => (is_array($events)) ? $events : $this->convertEventsDataToArray($events)
                ], 'json'),
            $this->getHttpStatusCode($pageCount),
            [],
            true
        );

        // set infinite cache if page is complete
        if ($maxPerPage === $pageCount) {

This code seems to be duplicated across your project.

            $jsonResponse
                ->setMaxAge(60 * 60 * 24 * 365)
                ->setSharedMaxAge(60 * 60 * 24 * 365);
        }

        return $jsonResponse;
    }