ArrayQuery\Filters\JoinFilter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	filter()	0	20	6

<?php
/**
 * This file is part of the ArrayQuery package.
 *
 * (c) Mauro Cassani<https://github.com/mauretto78>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ArrayQuery\Filters;

class JoinFilter extends AbstractFilter
{
    /**
     * @param array $results
     * @param null $joinArray

Are you sure the doc-type for parameter $joinArray is correct as it would always require null to be passed?

     * @return array
     */
    public static function filter(array $results, $joinArray = null)
    {
        if ($joinArray) {

$joinArray is of type null, thus it always evaluated to false.

            foreach ($joinArray as $join) {
                foreach ($results as $key => $result) {
                    $arrayToJoin = $join['array'];
                    $arrayName = $join['arrayName'];
                    $parentKey = $join['parentKey'];
                    $foreignKey = $join['foreignKey'];

                    if (array_key_exists($parentKey, $result) && $arrayToJoin[$foreignKey] === $result[$parentKey]) {
                        $results[$key][$arrayName] = $arrayToJoin;
                    } else {
                        unset($results[$key]);
                    }
                }
            }
        }

        return $results;
    }
}