View GitHub Repository sphpeme

Schedule Inspection
Subscribe

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.

LetHandler::evaluate()   A
last analyzed

↳ Parent: LetHandler

Complexity

Conditions 1
Paths 1

Size

Total Lines 10

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 7
CRAP Score 1

Importance

Changes 0
Metric Value
cc 1
nc 1
nop 3
dl 0
loc 10
ccs 7
cts 7
cp 1
crap 1
rs 9.9332
c 0
b 0
f 0
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Sphpeme\ExpHandler;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use Sphpeme\Env;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
use Sphpeme\Evaluator;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
use Sphpeme\Symbol;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
class LetHandler implements ExpHandler

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    private $letSymbol;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    private $lambdaSymbol;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                             4                         
                
                
                
    public function __construct()

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                             4                         
                
                
                
        $this->letSymbol = Symbol::make('let');

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                             4                         
                
                
                
        $this->lambdaSymbol = Symbol::make('lambda');

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                             4                         
                
                
                
    }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                             1                         
                
                
                
    public function handles($program): bool

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    25
                

                                    
                             1                         
                
                
                
        return $program[0] === $this->letSymbol;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                             1                         
                
                
                
    public function evaluate($program, Env\EnvInterface $env, Evaluator $evaluate)

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
        // bindings is an array of pairs: [[param, value], [param, value]]

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                             1                         
                
                
                
        list($_let, $bindings) = $program;

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The assignment to $_let is unused. Consider omitting it like so list($first,,$third).
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This checks looks for assignemnts to variables using the list(...)
function, where not all assigned variables are subsequently used.


Consider the following code example.


<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;





Only the variables $a and $c are used. There was no need to assign $b.


Instead, the list call could have been.


list($a,, $c) = returnThreeValues();





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                             1                         
                
                
                
        $letBody = \array_slice($program, 2);

            


            
                                                        
            
                                    
            
            

                
                    33
                

                                    
                             1                         
                
                
                
        $lambdaExp = array_merge(

            


            
                                                        
            
                                    
            
            

                
                    34
                

                                    
                             1                         
                
                
                
            [$this->lambdaSymbol, array_column($bindings, 0)],

            


            
                                                        
            
                                    
            
            

                
                    35
                

                                    
                             1                         
                
                
                
            $letBody); // unpack the body of let into the lambda exp

            


            
                                                        
            
                                    
            
            

                
                    36
                

                                    
                             1                         
                
                
                
        return $evaluate(array_merge([$lambdaExp], array_column($bindings, 1)), $env);

            


            
                                                        
            
                                    
            
            

                
                    37
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                
}