Sphpeme\ExpHandler\LambdaExpHandler

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	evaluate()	0	16	3
A	handles()	0	4	1

<?php

namespace Sphpeme\ExpHandler;


use Sphpeme\Env;
use function Sphpeme\env_extend;
use Sphpeme\EnvExtender;
use Sphpeme\Evaluator;
use Sphpeme\Symbol;

class LambdaExpHandler implements ExpHandler
{
    private $lambdaSymbol;
    /**
     * @var EnvExtender
     */
    private $envExtender;

    public function __construct(EnvExtender $envExtender)
    {
        $this->lambdaSymbol = Symbol::make('lambda');
        $this->envExtender = $envExtender;
    }

    public function evaluate($exp, Env\EnvInterface $env, Evaluator $evaluate)
    {
        list($lambda, $params) = $exp;

The assignment to $lambda is unused. Consider omitting it like so list($first,,$third).

        $body = \array_slice($exp, 2);
        return function (...$args) use ($env, $body, $params, $evaluate) {
            if (\count($params)) {
                $env = ($this->envExtender)($env, new Env\SimpleEnv(array_combine($params, $args)));

Consider using a different name than the imported variable $env, or did you forget to import by reference?

            }

            while (\count($body) > 1) {
                $evaluate(array_shift($body), $env);
            }

            return $evaluate(array_shift($body), $env);
        };
    }

    public function handles($exp): bool
    {
        return $exp[0] === $this->lambdaSymbol;
    }
}