mattiabasone / minepic

app/Image/ImageSection.php

<?php

declare(strict_types=1);

namespace Minepic\Image;

use Minepic\Image\Exceptions\ImageCreateFromPngFailedException;
use Minepic\Image\Exceptions\ImageResourceCreationFailedException;

abstract class ImageSection
{
    protected \GdImage $skinResource;

    protected int $skinWidth;

    protected int $skinHeight;
    /**
     * Resource with the image.
     */
    protected \GdImage $imgResource;

    /**
     * @throws ImageCreateFromPngFailedException
     */
    public function __construct(protected string $skinPath = '')
    {
        $this->skinResource = $this->createImageFromPng($this->skinPath);
        $this->skinWidth = (int) imagesx($this->skinResource);
        $this->skinHeight = (int) imagesy($this->skinResource);
    }

    public function __destruct()
    {
        if ($this->imgResource instanceof \GdImage) {

$this->imgResource is always a sub-type of GdImage.

            imagedestroy($this->imgResource);
        }
    }

    public function __toString(): string
    {
        ob_start();
        imagepng($this->imgResource);
        $imgToString = (string) ob_get_clean();

        return $imgToString;
    }

    public function is64x64(): bool
    {
        return $this->skinWidth === 64 && $this->skinHeight === 64;
    }

    /**
     * Get generated resource image.
     */
    public function getResource(): \GdImage
    {
        return $this->imgResource;
    }

    /**
     * @throws ImageCreateFromPngFailedException
     */
    protected function createImageFromPng(string $path): \GdImage
    {
        $resource = imagecreatefrompng($path);
        if ($resource === false) {
            throw new ImageCreateFromPngFailedException("Cannot create png image from file {$path}");
        }

        return $resource;

The expression return $resource could return the type resource which is incompatible with the type-hinted return GdImage. Consider adding an additional type-check to rule them out.

    }

    /**
     * @throws ImageResourceCreationFailedException
     */
    protected function emptyBaseImage(int $width, int $height): \GdImage
    {
        $tmpImageResource = imagecreatetruecolor($width, $height);
        if ($tmpImageResource === false) {
            throw new ImageResourceCreationFailedException('imagecreatetruecolor() failed');
        }
        imagealphablending($tmpImageResource, false);
        imagesavealpha($tmpImageResource, true);
        $transparent = (int) imagecolorallocatealpha($tmpImageResource, 255, 255, 255, 127);
        imagefilledrectangle($tmpImageResource, 0, 0, $width, $height, $transparent);

        return $tmpImageResource;

The expression return $tmpImageResource could return the type resource which is incompatible with the type-hinted return GdImage. Consider adding an additional type-check to rule them out.

    }
}