CheckUuid::handle() - Code Metrics - Inspection of "improvements" - mattiabasone/minepic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 165425...e22481 )

by Mattia

created 2020-09-09 16:24 UTC

CheckUuid::handle() B

↳ Parent: CheckUuid

Complexity

Conditions	6
Paths	38

Size

Total Lines	51
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	35
dl	0
loc	51
rs	8.7377
c	0
b	0
f	0
cc	6
nc	38
nop	1

How to fix Long Method

<?php

declare(strict_types=1);

namespace Minepic\Console\Commands;

use Carbon\Carbon;
use Illuminate\Console\Command;
use Minepic\Helpers\Storage\Files\SkinsStorage;
use Minepic\Minecraft\MojangClient;
use Minepic\Models\Account;

class CheckUuid extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'minepic:check-uuid';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Check old uuid.';

    /**
     * Execute the console command.
     *
     * @param MojangClient $mojangClient
     *
     * @throws \Throwable
     *
     * @return int
     */
    public function handle(MojangClient $mojangClient): int
    {
        $this->info('Selecting old uuid...');

        $results = $this->getAccountsIds();

        foreach ($results as $result) {
            /** @var \Minepic\Models\Account $account */
            $account = Account::find($result->id);
            if ($account) {
                $this->info("Checking {$account->username} [{$account->uuid}]...");
                try {
                    $accountApiData = $mojangClient->getUuidInfo($account->uuid);
                    $this->info("\tUUID Valid");

                    // Update database
                    $account->update([
                        'username' => $accountApiData->getUsername(),
                        'skin' => $accountApiData->getSkin(),
                        'cape' => $accountApiData->getCape(),
                        'fail_count' => 0,
                    ]);
                    $this->info("\tData updated");

                    try {
                        $skinData = $mojangClient->getSkin($account->uuid);
                        SkinsStorage::save($account->uuid, $skinData);
                        $this->info("\tSkin png updated");
                    } catch (\Exception $e) {
                        SkinsStorage::copyAsSteve($account->uuid);
                        $this->error("\tUsing Steve as skin");
                        $this->error("\t".$e->getMessage());
                    }
                } catch (\Exception $e) {
                    ++$account->fail_count;
                    $account->update([
                        'fail_count' => $account->fail_count,
                    ]);
                    $this->warn("\tFailed. Fail count: {$account->fail_count}");
                    if ($account->fail_count > 10) {
                        $account->delete();
                        $this->error("\tDELETED!");
                    } else {
                        $account->save();
                    }
                }
                $this->line('################################################');
            }
        }

        return 0;
    }

    private function getAccountsIds()
    {
        return Account::query()
            ->select(['id'])
            ->whereDate('updated_at', '<', Carbon::now()->subDays(28)->toDateTimeString())
            ->orderBy('updated_at', 'ASC')
            ->take(300)
            ->get();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Minepic\Console\Commands;
6
7			use Carbon\Carbon;
8			use Illuminate\Console\Command;
9			use Minepic\Helpers\Storage\Files\SkinsStorage;
10			use Minepic\Minecraft\MojangClient;
11			use Minepic\Models\Account;
12
13			class CheckUuid extends Command
14			{
15			/**
16			* The console command name.
17			*
18			* @var string
19			*/
20			protected $name = 'minepic:check-uuid';
21
22			/**
23			* The console command description.
24			*
25			* @var string
26			*/
27			protected $description = 'Check old uuid.';
28
29			/**
30			* Execute the console command.
31			*
32			* @param MojangClient $mojangClient
33			*
34			* @throws \Throwable
35			*
36			* @return int
37			*/
38			public function handle(MojangClient $mojangClient): int
39			{
40			$this->info('Selecting old uuid...');
41
42			$results = $this->getAccountsIds();
43
44			foreach ($results as $result) {
45			/** @var \Minepic\Models\Account $account */
46			$account = Account::find($result->id);
47			if ($account) {
48			$this->info("Checking {$account->username} [{$account->uuid}]...");
49			try {
50			$accountApiData = $mojangClient->getUuidInfo($account->uuid);
51			$this->info("\tUUID Valid");
52
53			// Update database
54			$account->update([
55			'username' => $accountApiData->getUsername(),
56			'skin' => $accountApiData->getSkin(),
57			'cape' => $accountApiData->getCape(),
58			'fail_count' => 0,
59			]);
60			$this->info("\tData updated");
61
62			try {
63			$skinData = $mojangClient->getSkin($account->uuid);
64			SkinsStorage::save($account->uuid, $skinData);
65			$this->info("\tSkin png updated");
66			} catch (\Exception $e) {
67			SkinsStorage::copyAsSteve($account->uuid);
68			$this->error("\tUsing Steve as skin");
69			$this->error("\t".$e->getMessage());
70			}
71			} catch (\Exception $e) {
72			++$account->fail_count;
73			$account->update([
74			'fail_count' => $account->fail_count,
75			]);
76			$this->warn("\tFailed. Fail count: {$account->fail_count}");
77			if ($account->fail_count > 10) {
78			$account->delete();
79			$this->error("\tDELETED!");
80			} else {
81			$account->save();
82			}
83			}
84			$this->line('################################################');
85			}
86			}
87
88			return 0;
89			}
90
91			private function getAccountsIds()
92			{
93			return Account::query()
94			->select(['id'])
95			->whereDate('updated_at', '<', Carbon::now()->subDays(28)->toDateTimeString())
96			->orderBy('updated_at', 'ASC')
97			->take(300)
98			->get();
99			}
100			}
101

mattiabasone / minepic

Push — master ( 165425...e22481 )

CheckUuid::handle() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like