App\Core

Complexity

Total Complexity

80

Size/Duplication

Total Lines	602
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	2

29 Methods

Rating	Name	Duplication	Size	Complexity
A	userDataUpdated()	0	3	1
A	removeFailedRequest()	0	5	1
A	logUsernameChange()	0	3	1
A	getUserdata()	0	3	1
A	normalizeRequest()	0	4	1
A	insertNewUuid()	0	25	6
A	convertRequestToUuid()	0	16	4
A	__construct()	0	6	1
A	getFullUserdataApi()	0	11	2
A	uuidInDb()	0	7	2
A	isometricAvatarCurrentUser()	0	12	1
A	checkDbCache()	0	3	1
A	setForceUpdate()	0	3	1
A	skinCurrentUser()	0	3	1
A	nameInDb()	0	7	2
A	avatarCurrentUser()	0	6	1
A	error()	0	3	1
A	renderSkinCurrentUser()	0	6	1
A	getFullUserdata()	0	5	1
A	updateStats()	0	8	6
B	updateDbUser()	0	37	7
A	saveUnexistentAccount()	0	6	1
A	forceUpdatePossible()	0	4	2
A	saveRemoteSkin()	0	15	4
A	isUnexistentAccount()	0	16	3
A	updateUserFailUpdate()	0	9	2
A	isCurrentRequestValidUuid()	0	3	1
A	loadDbUserdata()	0	17	3
D	initialize()	0	87	21

<?php

declare(strict_types=1);

namespace App;

use App\Events\Account\UsernameChangeEvent;
use App\Helpers\Storage\Files\SkinsStorage;
use App\Helpers\UserDataValidator;
use App\Image\IsometricAvatar;
use App\Image\Sections\Avatar;
use App\Image\Sections\Skin;
use App\Minecraft\MojangAccount;
use App\Minecraft\MojangClient;
use App\Models\Account;
use App\Models\AccountNotFound;
use App\Models\AccountStats;
use App\Repositories\AccountRepository;

/**
 * Class Core.
 */
class Core
{
    /**
     * Requested string.
     *
     * @var string
     */
    private $request = '';

    /**
     * Userdata from/to DB.
     *
     * @var Account
     */
    private $userdata;

    /**
     * Full userdata.
     *
     * @var MojangAccount
     */
    private $apiUserdata;

    /**
     * User data has been updated?
     *
     * @var bool
     */
    private $dataUpdated = false;

    /**
     * Set force update.
     *
     * @var bool
     */
    private $forceUpdate;

    /**
     * Minepic error string.
     *
     * @var string
     */
    private $error = false;

    /**
     * Account not found?
     *
     * @var bool
     */
    private $accountNotFound = false;

    /**
     * Retry for nonexistent usernames.
     *
     * @var string
     */
    private $retryUnexistentCheck = false;

    /**
     * Current image path.
     *
     * @var string
     */
    public $currentUserSkinImage;
    /**
     * @var AccountRepository
     */
    private $accountRepository;
    /**
     * @var MojangClient
     */
    private $mojangClient;

    /**
     * Core constructor.
     * @param AccountRepository $accountRepository Where user data is stored
     * @param MojangClient $mojangClient Client for Mojang API
     */
    public function __construct(
        AccountRepository $accountRepository,
        MojangClient $mojangClient
    ) {
        $this->accountRepository = $accountRepository;
        $this->mojangClient = $mojangClient;
    }

    /**
     * Display error.
     */
    public function error(): string
    {
        return $this->error;
    }

    /**
     * Check if is a valid UUID.
     */
    public function isCurrentRequestValidUuid(): bool
    {
        return UserDataValidator::isValidUuid($this->request);
    }

    /**
     * Normalize request.
     */
    private function normalizeRequest(): void
    {
        $this->request = \preg_replace("#\.png.*#", '', $this->request);
        $this->request = \preg_replace('#[^a-zA-Z0-9_]#', '', $this->request);
    }

    /**
     * Check if chache is still valid.
     *
     * @param int
     * @return bool
     */
    private function checkDbCache(): bool
    {
        return (\time() - $this->userdata->updated_at->timestamp) < env('USERDATA_CACHE_TIME');

The property timestamp does not exist on string.

    }

    /**
     * Load saved userdata.
     *
     * @param string $type
     * @param string $value
     * @return bool
     */
    private function loadDbUserdata($type = 'uuid', $value = ''): bool
    {
        if ($type !== 'username') {
            $result = $this->accountRepository->findByUuid($value);
        } else {
            $result = $this->accountRepository->findLastUpdatedByUsername($value);
        }

        if ($result !== null) {
            $this->userdata = $result;

It seems like $result can also be of type Illuminate\Database\Eloquent\Builder. However, the property $userdata is declared as type App\Models\Account. Maybe add an additional type check?

            $this->currentUserSkinImage = SkinsStorage::getPath($this->userdata->uuid);

            return true;
        }
        $this->currentUserSkinImage = SkinsStorage::getPath(env('DEFAULT_USERNAME'));

        return false;
    }

    /**
     * Return loaded user data.
     *
     * @return Account
     */
    public function getUserdata(): ?Account
    {
        return $this->userdata;
    }

    /**
     * Get loaded user data and stats (array).
     */
    public function getFullUserdata(): array
    {
        $userstats = AccountStats::find($this->userdata->uuid);

        return [$this->userdata, $userstats];
    }

    /**
     * Check if an UUID is in the database.
     */
    private function uuidInDb(?string $uuid = null): bool
    {
        if ($uuid === null) {
            $uuid = $this->request;
        }

        return $this->loadDbUserdata('uuid', $uuid);
    }

    /**
     * Check if a username is in the database.
     */
    private function nameInDb(?string $name = null): bool
    {
        if ($name === null) {
            $name = $this->request;
        }

        return $this->loadDbUserdata('username', $name);
    }

    /**
     * Insert user data in database.
     *
     * @param void
     * @return bool
     */
    public function insertNewUuid(): bool
    {
        if ($this->getFullUserdataApi()) {
            $this->userdata = $this->accountRepository->create([
                'username' => $this->apiUserdata->username,
                'uuid' => $this->apiUserdata->uuid,
                'skin' => $this->apiUserdata->skin && \mb_strlen($this->apiUserdata->skin) > 1 ? $this->apiUserdata->skin : '',
                'cape' => $this->apiUserdata->cape && \mb_strlen($this->apiUserdata->cape) > 1 ? $this->apiUserdata->cape : '',
            ]);

            $this->saveRemoteSkin();
            $this->currentUserSkinImage = SkinsStorage::getPath($this->apiUserdata->uuid);

            $accountStats = new AccountStats();
            $accountStats->uuid = $this->userdata->uuid;
            $accountStats->count_search = 0;
            $accountStats->count_request = 0;
            $accountStats->time_search = 0;
            $accountStats->time_request = 0;
            $accountStats->save();

            return true;
        }

        return false;
    }

    /**
     * Get UUID from username.
     *
     * @param string
     * @return bool
     */
    private function convertRequestToUuid(): bool
    {
        if (UserDataValidator::isValidUsername($this->request) || UserDataValidator::isValidEmail($this->request)) {
            try {
                $account = $this->mojangClient->sendUsernameInfoRequest($this->request);
                $this->request = $account->uuid;

                return true;
            } catch (\Exception $e) {
                \Log::error($e);

                return false;
            }
        }

        return false;
    }

    /**
     * Salva account inesistente.
     *
     * @return mixed
     */
    public function saveUnexistentAccount()
    {
        $notFound = AccountNotFound::firstOrNew(['request' => $this->request]);
        $notFound->request = $this->request;

        return $notFound->save();
    }

    /**
     * Check if requested string is a failed request.
     *
     * @return bool
     */
    public function isUnexistentAccount(): bool
    {
        $result = AccountNotFound::find($this->request);
        if ($result != null) {
            if ((\time() - $result->updated_at->timestamp) > env('USERDATA_CACHE_TIME')) {

The property updated_at does not seem to exist on App\Models\AccountNotFound. Are you sure there is no database migration missing?

                $this->retryUnexistentCheck = true;

The property $retryUnexistentCheck was declared of type string, but true is of type true. Maybe add a type cast?

            } else {
                $this->retryUnexistentCheck = false;
            }
            $this->accountNotFound = true;

            return true;
        }
        $this->accountNotFound = false;

        return false;
    }

    /**
     * Delete current request from failed cache.
     */
    public function removeFailedRequest(): bool
    {
        $result = AccountNotFound::where('request', $this->request)->delete();

        return \count($result) > 0;

It seems like $result can also be of type integer; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

    }

    /**
     * Check requested string and initialize objects.
     *
     * @param string
     * @return bool
     */
    public function initialize(string $string): bool
    {
        $this->dataUpdated = false;
        $this->request = $string;
        $this->normalizeRequest();

        if (!empty($this->request) && \mb_strlen($this->request) <= 32) {
            // TODO these checks needs optimizations
            // Valid UUID format? Then check if UUID is in my database
            if ($this->isCurrentRequestValidUuid() && $this->uuidInDb()) {
                // Check if UUID is in my database
                // Data cache still valid?
                if (!$this->checkDbCache() || $this->forceUpdatePossible()) {
                    // Nope, updating data
                    $this->updateDbUser();
                } else {
                    // Check if local image exists
                    if (!SkinsStorage::exists($this->request)) {
                        $this->saveRemoteSkin();
                    }
                }

                return true;
            } elseif ($this->nameInDb()) {
                // Check DB datacache
                if (!$this->checkDbCache() || $this->forceUpdatePossible()) {
                    // Check UUID (username change/other)
                    if ($this->convertRequestToUuid()) {
                        if ($this->request === $this->userdata->uuid) {
                            // Nope, updating data
                            $this->request = $this->userdata->uuid;
                            $this->updateDbUser();
                        } else {
                            // re-initialize process with the UUID if the name has been changed
                            return $this->initialize($this->request);
                        }
                    } else {
                        $this->request = $this->userdata->uuid;
                        $this->updateUserFailUpdate();
                        SkinsStorage::copyAsSteve($this->request);
                    }
                } else {
                    // Check if local image exists
                    if (!SkinsStorage::exists($this->request)) {
                        SkinsStorage::copyAsSteve($this->request);
                    }
                }

                return true;
            } else {
                // Account not found? time to retry to get information from Mojang?
                if ($this->retryUnexistentCheck || !$this->isUnexistentAccount()) {
                    if (!$this->isCurrentRequestValidUuid() && !$this->convertRequestToUuid()) {
                        $this->saveUnexistentAccount();
                        $this->userdata = null;
                        $this->currentUserSkinImage = SkinsStorage::getPath(env('DEFAULT_USERNAME'));
                        $this->error = 'Invalid request username';
                        $this->request = '';

                        return false;
                    }

                    // Check if the uuid is already in the database, maybe the user has changed username and the check
                    // nameInDb() has failed
                    if ($this->uuidInDb()) {
                        $this->updateDbUser();

                        return true;
                    }

                    if ($this->insertNewUuid()) {
                        if ($this->accountNotFound) {
                            $this->removeFailedRequest();
                        }

                        return true;
                    }
                }
            }
        }

        $this->userdata = null;
        $this->currentUserSkinImage = SkinsStorage::getPath(env('DEFAULT_USERNAME'));
        $this->error = 'Account not found';
        $this->request = '';

        return false;
    }

    /**
     * Update current user fail count.
     */
    private function updateUserFailUpdate(): bool
    {
        if (isset($this->userdata->uuid)) {
            ++$this->userdata->fail_count;

            return $this->userdata->save();
        }

        return false;
    }

    /**
     * Update db user data.
     */
    private function updateDbUser(): bool
    {
        if (isset($this->userdata->username) && $this->userdata->uuid != '') {
            // Get data from API
            if ($this->getFullUserdataApi()) {
                $originalUsername = $this->userdata->username;
                // Update database
                $this->accountRepository->update([
                    'username' => $this->apiUserdata->username,
                    'skin' => $this->apiUserdata->skin,
                    'cape' => $this->apiUserdata->cape,
                    'fail_count' => 0,
                ], $this->userdata->id);

                $this->userdata->refresh();

                // Update skin
                $this->saveRemoteSkin();

                // Log username change
                if ($this->userdata->username !== $originalUsername && $originalUsername !== '') {
                    $this->logUsernameChange($this->userdata->uuid, $originalUsername, $this->userdata->username);
                }
                $this->dataUpdated = true;

                return true;
            }

            $this->updateUserFailUpdate();

            if (!SkinsStorage::exists($this->userdata->uuid)) {
                SkinsStorage::copyAsSteve($this->userdata->uuid);
            }
        }
        $this->dataUpdated = false;

        return false;
    }

    /**
     * Return if data has been updated.
     */
    public function userDataUpdated(): bool
    {
        return $this->dataUpdated;
    }

    /**
     * Log the username change.
     *
     * @param $uuid string User UUID
     * @param $prev string Previous username
     * @param $new string New username
     */
    private function logUsernameChange(string $uuid, string $prev, string $new): void
    {
        \Event::dispatch(new UsernameChangeEvent($uuid, $prev, $new));

The method dispatch() does not exist on Event.

    }

    /**
     * Get userdata from Mojang API.
     *
     * @param mixed
     * @return bool
     */
    private function getFullUserdataApi(): bool
    {
        try {
            $this->apiUserdata = $this->mojangClient->getUuidInfo($this->request);

            return true;
        } catch (\Exception $e) {
            \Log::error($e);
            $this->apiUserdata = null;

            return false;
        }
    }

    /**
     * Show rendered avatar.
     *
     * @param int
     * @param mixed
     *
     * @return Avatar
     * @throws \Throwable
     */
    public function avatarCurrentUser(int $size = 0): Avatar
    {
        $avatar = new Avatar($this->currentUserSkinImage);
        $avatar->renderAvatar($size);

        return $avatar;
    }

    /**
     * Default Avatar Isometric.
     *
     * @param int $size
     * @return IsometricAvatar
     * @throws \Throwable
     */
    public function isometricAvatarCurrentUser(int $size = 0): IsometricAvatar
    {
        // TODO: Needs refactoring
        $uuid = $this->userdata->uuid ?? env('DEFAULT_UUID');
        $timestamp = $this->userdata->updated_at->timestamp ?? \time();

The property timestamp does not exist on string.

        $isometricAvatar = new IsometricAvatar(
            $uuid,
            $timestamp
        );
        $isometricAvatar->render($size);

        return $isometricAvatar;
    }

    /**
     * Save skin image.
     *
     * @param mixed
     * @return bool
     */
    public function saveRemoteSkin(): bool
    {
        if (!empty($this->userdata->skin) && \mb_strlen($this->userdata->skin) > 0) {
            $mojangClient = new MojangClient();
            try {
                $skinData = $mojangClient->getSkin($this->userdata->skin);

                return SkinsStorage::save($this->userdata->uuid, $skinData);
            } catch (\Exception $e) {
                \Log::error($e);
                $this->error = $e->getMessage();
            }
        }

        return SkinsStorage::copyAsSteve($this->userdata->uuid);
    }

    /**
     * Return rendered skin.
     *
     * @param int
     * @param string
     *
     * @return Skin
     * @throws \Throwable
     */
    public function renderSkinCurrentUser(int $size = 0, string $type = 'F'): Skin
    {
        $skin = new Skin($this->currentUserSkinImage);
        $skin->renderSkin($size, $type);

        return $skin;
    }

    /**
     * Return a Skin object of the current user.
     */
    public function skinCurrentUser(): Skin
    {
        return new Skin($this->currentUserSkinImage);
    }

    /**
     * Set force update.
     */
    public function setForceUpdate(bool $forceUpdate): void
    {
        $this->forceUpdate = $forceUpdate;
    }

    /**
     * Can I exec force update?
     */
    private function forceUpdatePossible(): bool
    {
        return ($this->forceUpdate) &&
            ((\time() - $this->userdata->updated_at->timestamp) > env('MIN_USERDATA_UPDATE_INTERVAL'));

The property timestamp does not exist on string.

    }

    /**
     * Use steve skin for given username.
     *
     * @param string
     */
    public function updateStats($type = 'request'): void
    {
        if (!empty($this->userdata->uuid) && env('STATS_ENABLED') && $this->userdata->uuid !== env('DEFAULT_UUID')) {
            $AccStats = new AccountStats();
            if ($type === 'request') {
                $AccStats->incrementRequestStats($this->userdata->uuid);
            } elseif ($type === 'search') {
                $AccStats->incrementSearchStats($this->userdata->uuid);
            }
        }
    }
}