UsernameResolver::isValidUsername() - Code Metrics - Inspection of "test namespace" - mattiabasone/minepic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9aa048...898b5e )

by Mattia

created 2020-09-09 09:00 UTC

UsernameResolver::isValidUsername() A

↳ Parent: UsernameResolver

Complexity

Conditions	2
Paths	2

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

declare(strict_types=1);

namespace Minepic\Resolvers;

use Minepic\Cache\UserNotFoundCache;
use Minepic\Helpers\UserDataValidator;
use Minepic\Minecraft\MojangClient;
use Minepic\Repositories\AccountRepository;

class UsernameResolver
{
    /**
     * @var AccountRepository
     */
    private AccountRepository $accountRepository;
    /**
     * @var MojangClient
     */
    private MojangClient $mojangClient;

    public function __construct(
        AccountRepository $accountRepository,
        MojangClient $mojangClient
    ) {
        $this->accountRepository = $accountRepository;
        $this->mojangClient = $mojangClient;
    }

    /**
     * @param string $username
     *
     * @throws \Exception
     *
     * @return string|null
     */
    public function resolve(string $username): ?string
    {
        if (!$this->isValidUsername($username)) {
            return null;
        }

        /** @var \Minepic\Models\Account $account */
        $account = $this->accountRepository->findLastUpdatedByUsername($username);
        if ($account !== null) {
            return $account->uuid;
        }

        if (!UserNotFoundCache::has($username)) {
            try {
                $mojangAccount = $this->mojangClient->sendUsernameInfoRequest($username);

                return $mojangAccount->getUuid();
            } catch (\Throwable $exception) {
                UserNotFoundCache::add($username);
            }
        }

        return null;
    }

    /**
     * @param string $username
     *
     * @return bool
     */
    private function isValidUsername(string $username): bool
    {
        return UserDataValidator::isValidUsername($username) || UserDataValidator::isValidEmail($username);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Minepic\Resolvers;
6
7			use Minepic\Cache\UserNotFoundCache;
8			use Minepic\Helpers\UserDataValidator;
9			use Minepic\Minecraft\MojangClient;
10			use Minepic\Repositories\AccountRepository;
11
12			class UsernameResolver
13			{
14			/**
15			* @var AccountRepository
16			*/
17			private AccountRepository $accountRepository;
18			/**
19			* @var MojangClient
20			*/
21			private MojangClient $mojangClient;
22
23			public function __construct(
24			AccountRepository $accountRepository,
25			MojangClient $mojangClient
26			) {
27			$this->accountRepository = $accountRepository;
28			$this->mojangClient = $mojangClient;
29			}
30
31			/**
32			* @param string $username
33			*
34			* @throws \Exception
35			*
36			* @return string\|null
37			*/
38			public function resolve(string $username): ?string
39			{
40			if (!$this->isValidUsername($username)) {
41			return null;
42			}
43
44			/** @var \Minepic\Models\Account $account */
45			$account = $this->accountRepository->findLastUpdatedByUsername($username);
46			if ($account !== null) {
47			return $account->uuid;
48			}
49
50			if (!UserNotFoundCache::has($username)) {
51			try {
52			$mojangAccount = $this->mojangClient->sendUsernameInfoRequest($username);
53
54			return $mojangAccount->getUuid();
55			} catch (\Throwable $exception) {
56			UserNotFoundCache::add($username);
57			}
58			}
59
60			return null;
61			}
62
63			/**
64			* @param string $username
65			*
66			* @return bool
67			*/
68			private function isValidUsername(string $username): bool
69			{
70			return UserDataValidator::isValidUsername($username) \|\| UserDataValidator::isValidEmail($username);
71			}
72			}
73

mattiabasone / minepic

Push — master ( 9aa048...898b5e )

UsernameResolver::isValidUsername() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like