PagOnline\Init\IgfsCgVerify::parseResponseMap()

Complexity

Conditions	5
Paths	8

Size

Total Lines	65
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	35
CRAP Score	5.0005

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function parseResponseMap($response)
    {
        parent::parseResponseMap($response);
        // Opzionale
        $this->tranID = IgfsUtils::getValue($response, 'tranID');
        // Opzionale
        $this->authCode = IgfsUtils::getValue($response, 'authCode');
        // Opzionale
        $this->enrStatus = IgfsUtils::getValue($response, 'enrStatus');
        // Opzionale
        $this->authStatus = IgfsUtils::getValue($response, 'authStatus');
        // Opzionale
        $this->brand = IgfsUtils::getValue($response, 'brand');
        // Opzionale
        $this->acquirerID = IgfsUtils::getValue($response, 'acquirerID');
        // Opzionale
        $this->maskedPan = IgfsUtils::getValue($response, 'maskedPan');
        // Opzionale
        $this->addInfo1 = IgfsUtils::getValue($response, 'addInfo1');
        // Opzionale
        $this->addInfo2 = IgfsUtils::getValue($response, 'addInfo2');
        // Opzionale
        $this->addInfo3 = IgfsUtils::getValue($response, 'addInfo3');
        // Opzionale
        $this->addInfo4 = IgfsUtils::getValue($response, 'addInfo4');
        // Opzionale
        $this->addInfo5 = IgfsUtils::getValue($response, 'addInfo5');
        // Opzionale
        $this->payInstrToken = IgfsUtils::getValue($response, 'payInstrToken');
        // Opzionale
        $this->expireMonth = IgfsUtils::getValue($response, 'expireMonth');
        // Opzionale
        $this->expireYear = IgfsUtils::getValue($response, 'expireYear');
        // Opzionale
        $this->level3Info = Level3Info::fromXml(IgfsUtils::getValue($response, 'level3Info'));
        // Opzionale
        $this->additionalFee = IgfsUtils::getValue($response, 'additionalFee');
        // Opzionale
        $this->status = IgfsUtils::getValue($response, 'status');
        // Opzionale
        $this->accountName = IgfsUtils::getValue($response, 'accountName');
        // Opzionale
        $this->nssResult = IgfsUtils::getValue($response, 'nssResult');
        // Opzionale
        $this->topUpID = IgfsUtils::getValue($response, 'topUpID');
        // Opzionale
        $this->payUserRef = IgfsUtils::getValue($response, 'payUserRef');
        // Opzionale
        $this->shopUserMobilePhone = IgfsUtils::getValue($response, 'shopUserMobilePhone');
        // Opzionale
        $this->receiptPdf = (string) \base64_decode(IgfsUtils::getValue($response, 'receiptPdf'), true);

It seems like PagOnline\IgfsUtils::getValue($response, 'receiptPdf') can also be of type null; however, parameter $string of base64_decode() does only seem to accept string, maybe add an additional type check?

        if (empty($this->receiptPdf)) {
            $this->receiptPdf = null;
        }

        $responseNode = $this->responseXmlToObject($response[static::$soapResponseTag]);
        if ($responseNode === null) {
            return;
        }

        $xml_response = IgfsUtils::parseResponseFields($responseNode);
        if (isset($xml_response['payAddData'])) {
            $this->payAddData = [];
            foreach ($responseNode->xpath('//payAddData') as $item) {
                \array_push($this->payAddData, Entry::fromXml($item->asXML()));

It seems like $item->asXML() can also be of type true; however, parameter $xml of PagOnline\XmlEntities\BaseXmlEntity::fromXml() does only seem to accept string, maybe add an additional type check?

            }