Minify::cache() - Code Metrics - Inspection of "Prevent error determining if path or content" - matthiasmullie/minify - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#90)

unknown

created 2015-12-24 23:59 UTC

Minify::cache() A

↳ Parent: Minify

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	7
rs	9.4286
cc	1
eloc	4
nc	1
nop	1

<?php

namespace MatthiasMullie\Minify;

use Psr\Cache\CacheItemInterface;

/**
 * Abstract minifier class.
 *
 * Please report bugs on https://github.com/matthiasmullie/minify/issues
 *
 * @author Matthias Mullie <[email protected]>
 * @copyright Copyright (c) 2012, Matthias Mullie. All rights reserved.
 * @license MIT License
 */
abstract class Minify
{
    /**
     * The data to be minified.
     *
     * @var string[]
     */
    protected $data = array();

    /**
     * Array of patterns to match.
     *
     * @var string[]
     */
    protected $patterns = array();

    /**
     * This array will hold content of strings and regular expressions that have
     * been extracted from the JS source code, so we can reliably match "code",
     * without having to worry about potential "code-like" characters inside.
     *
     * @var string[]
     */
    public $extracted = array();

    /**
     * Init the minify class - optionally, code may be passed along already.
     */
    public function __construct(/* $data = null, ... */)
    {
        // it's possible to add the source through the constructor as well ;)
        if (func_num_args()) {
            call_user_func_array(array($this, 'add'), func_get_args());
        }
    }

    /**
     * Add a file or straight-up code to be minified.
     *
     * @param string $data
     */
    public function add($data /* $data = null, ... */)
    {
        // bogus "usage" of parameter $data: scrutinizer warns this variable is
        // not used (we're using func_get_args instead to support overloading),
        // but it still needs to be defined because it makes no sense to have
        // this function without argument :)
        $args = array($data) + func_get_args();

        // this method can be overloaded
        foreach ($args as $data) {
            // redefine var
            $data = (string) $data;

            // load data
            $value = $this->load($data);
            $key = ($data != $value) ? $data : count($this->data);

            // store data
            $this->data[$key] = $value;
        }
    }

    /**
     * Load data.
     *
     * @param string $data Either a path to a file or the content itself.
     *
     * @return string
     */
    protected function load($data)
    {
        // check if the data is a file
        if (strpos($data, "\n") === false && file_exists($data) && is_file($data)) {
            $data = file_get_contents($data);

            // strip BOM, if any
            if (substr($data, 0, 3) == "\xef\xbb\xbf") {
                $data = substr($data, 3);
            }
        }

        return $data;
    }

    /**
     * Save to file.
     *
     * @param string $content The minified data.
     * @param string $path    The path to save the minified data to.
     *
     * @throws Exception
     */
    protected function save($content, $path)
    {
        // create file & open for writing
        if (($handler = @fopen($path, 'w')) === false) {
            throw new Exception('The file "'.$path.'" could not be opened. Check if PHP has enough permissions.');
        }

        // write to file
        if (@fwrite($handler, $content) === false) {
            throw new Exception('The file "'.$path.'" could not be written to. Check if PHP has enough permissions.');
        }

        // close the file
        @fclose($handler);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    /**
     * Minify the data & (optionally) saves it to a file.
     *
     * @param string[optional] $path Path to write the data to.
     *
     * @return string The minified data.
     */
    public function minify($path = null)
    {
        $content = $this->execute($path);

        // save to path
        if ($path !== null) {
            $this->save($content, $path);
        }

        return $content;
    }

    /**
     * Minify & gzip the data & (optionally) saves it to a file.
     *
     * @param string[optional] $path  Path to write the data to.
     * @param int[optional]    $level Compression level, from 0 to 9.
     *
     * @return string The minified & gzipped data.
     */
    public function gzip($path = null, $level = 9)
    {
        $content = $this->execute($path);
        $content = gzencode($content, $level, FORCE_GZIP);

        // save to path
        if ($path !== null) {
            $this->save($content, $path);
        }

        return $content;
    }

    /**
     * Minify the data & write it to a CacheItemInterface object.
     *
     * @param CacheItemInterface $item Cache item to write the data to.
     *
     * @return CacheItemInterface Cache item with the minifier data.
     */
    public function cache(CacheItemInterface $item)
    {
        $content = $this->execute();
        $item->set($content);

        return $item;
    }

    /**
     * Minify the data.
     *
     * @param string[optional] $path Path to write the data to.
     *
     * @return string The minified data.
     */
    abstract public function execute($path = null);

    /**
     * Register a pattern to execute against the source content.
     *
     * @param string          $pattern     PCRE pattern.
     * @param string|callable $replacement Replacement value for matched pattern.
     *
     * @throws Exception
     */
    protected function registerPattern($pattern, $replacement = '')
    {
        // study the pattern, we'll execute it more than once
        $pattern .= 'S';

        $this->patterns[] = array($pattern, $replacement);
    }

    /**
     * We can't "just" run some regular expressions against JavaScript: it's a
     * complex language. E.g. having an occurrence of // xyz would be a comment,
     * unless it's used within a string. Of you could have something that looks
     * like a 'string', but inside a comment.
     * The only way to accurately replace these pieces is to traverse the JS one
     * character at a time and try to find whatever starts first.
     *
     * @param string $content The content to replace patterns in.
     *
     * @return string The (manipulated) content.
     */
    protected function replace($content)
    {
        $processed = '';
        $positions = array_fill(0, count($this->patterns), -1);
        $matches = array();

        while ($content) {
            // find first match for all patterns
            foreach ($this->patterns as $i => $pattern) {
                list($pattern, $replacement) = $pattern;

                // no need to re-run matches that are still in the part of the
                // content that hasn't been processed
                if ($positions[$i] >= 0) {
                    continue;
                }

                $match = null;
                if (preg_match($pattern, $content, $match)) {
                    $matches[$i] = $match;

                    // we'll store the match position as well; that way, we
                    // don't have to redo all preg_matches after changing only
                    // the first (we'll still know where those others are)
                    $positions[$i] = strpos($content, $match[0]);
                } else {
                    // if the pattern couldn't be matched, there's no point in
                    // executing it again in later runs on this same content;
                    // ignore this one until we reach end of content
                    unset($matches[$i]);
                    $positions[$i] = strlen($content);
                }
            }

            // no more matches to find: everything's been processed, break out
            if (!$matches) {

                $processed .= $content;
                break;
            }

            // see which of the patterns actually found the first thing (we'll
            // only want to execute that one, since we're unsure if what the
            // other found was not inside what the first found)
            $discardLength = min($positions);
            $firstPattern = array_search($discardLength, $positions);
            $match = $matches[$firstPattern][0];

            // execute the pattern that matches earliest in the content string
            list($pattern, $replacement) = $this->patterns[$firstPattern];
            $replacement = $this->replacePattern($pattern, $replacement, $content);

            // figure out which part of the string was unmatched; that's the
            // part we'll execute the patterns on again next
            $content = substr($content, $discardLength);
            $unmatched = (string) substr($content, strpos($content, $match) + strlen($match));

            // move the replaced part to $processed and prepare $content to
            // again match batch of patterns against
            $processed .= substr($replacement, 0, strlen($replacement) - strlen($unmatched));
            $content = $unmatched;

            // first match has been replaced & that content is to be left alone,
            // the next matches will start after this replacement, so we should
            // fix their offsets
            foreach ($positions as $i => $position) {
                $positions[$i] -= $discardLength + strlen($match);
            }
        }

        return $processed;
    }

    /**
     * This is where a pattern is matched against $content and the matches
     * are replaced by their respective value.
     * This function will be called plenty of times, where $content will always
     * move up 1 character.
     *
     * @param string          $pattern     Pattern to match.
     * @param string|callable $replacement Replacement value.
     * @param string          $content     Content to match pattern against.
     *
     * @return string
     */
    protected function replacePattern($pattern, $replacement, $content)
    {
        if (is_callable($replacement)) {
            return preg_replace_callback($pattern, $replacement, $content, 1, $count);
        } else {
            return preg_replace($pattern, $replacement, $content, 1, $count);
        }
    }

    /**
     * Strings are a pattern we need to match, in order to ignore potential
     * code-like content inside them, but we just want all of the string
     * content to remain untouched.
     *
     * This method will replace all string content with simple STRING#
     * placeholder text, so we've rid all strings from characters that may be
     * misinterpreted. Original string content will be saved in $this->extracted
     * and after doing all other minifying, we can restore the original content
     * via restoreStrings()
     *
     * @param string[optional] $chars
     */
    protected function extractStrings($chars = '\'"')
    {
        // PHP only supports $this inside anonymous functions since 5.4
        $minifier = $this;
        $callback = function ($match) use ($minifier) {
            if (!$match[1]) {
                /*
                 * Empty strings need no placeholder; they can't be confused for
                 * anything else anyway.
                 * But we still needed to match them, for the extraction routine
                 * to skip over this particular string.
                 */
                return $match[0];
            }

            $count = count($minifier->extracted);
            $placeholder = $match[1].$count.$match[1];
            $minifier->extracted[$placeholder] = $match[1].$match[2].$match[1];

            return $placeholder;
        };

        /*
         * The \\ messiness explained:
         * * Don't count ' or " as end-of-string if it's escaped (has backslash
         * in front of it)
         * * Unless... that backslash itself is escaped (another leading slash),
         * in which case it's no longer escaping the ' or "
         * * So there can be either no backslash, or an even number
         * * multiply all of that times 4, to account for the escaping that has
         * to be done to pass the backslash into the PHP string without it being
         * considered as escape-char (times 2) and to get it in the regex,
         * escaped (times 2)
         */
        $this->registerPattern('/(['.$chars.'])(.*?(?<!\\\\)(\\\\\\\\)*+)\\1/s', $callback);
    }

    /**
     * This method will restore all extracted data (strings, regexes) that were
     * replaced with placeholder text in extract*(). The original content was
     * saved in $this->extracted.
     *
     * @param string $content
     *
     * @return string
     */
    protected function restoreExtractedData($content)
    {
        if (!$this->extracted) {

            // nothing was extracted, nothing to restore
            return $content;
        }

        $content = strtr($content, $this->extracted);

        $this->extracted = array();

        return $content;
    }
}


1			<?php
2
3			namespace MatthiasMullie\Minify;
4
5			use Psr\Cache\CacheItemInterface;
6
7			/**
8			* Abstract minifier class.
9			*
10			* Please report bugs on https://github.com/matthiasmullie/minify/issues
11			*
12			* @author Matthias Mullie <[email protected]>
13			* @copyright Copyright (c) 2012, Matthias Mullie. All rights reserved.
14			* @license MIT License
15			*/
16			abstract class Minify
17			{
18			/**
19			* The data to be minified.
20			*
21			* @var string[]
22			*/
23			protected $data = array();
24
25			/**
26			* Array of patterns to match.
27			*
28			* @var string[]
29			*/
30			protected $patterns = array();
31
32			/**
33			* This array will hold content of strings and regular expressions that have
34			* been extracted from the JS source code, so we can reliably match "code",
35			* without having to worry about potential "code-like" characters inside.
36			*
37			* @var string[]
38			*/
39			public $extracted = array();
40
41			/**
42			* Init the minify class - optionally, code may be passed along already.
43			*/
44			public function __construct(/* $data = null, ... */)
45			{
46			// it's possible to add the source through the constructor as well ;)
47			if (func_num_args()) {
48			call_user_func_array(array($this, 'add'), func_get_args());
49			}
50			}
51
52			/**
53			* Add a file or straight-up code to be minified.
54			*
55			* @param string $data
56			*/
57			public function add($data /* $data = null, ... */)
58			{
59			// bogus "usage" of parameter $data: scrutinizer warns this variable is
60			// not used (we're using func_get_args instead to support overloading),
61			// but it still needs to be defined because it makes no sense to have
62			// this function without argument :)
63			$args = array($data) + func_get_args();
64
65			// this method can be overloaded
66			foreach ($args as $data) {
67			// redefine var
68			$data = (string) $data;
69
70			// load data
71			$value = $this->load($data);
72			$key = ($data != $value) ? $data : count($this->data);
73
74			// store data
75			$this->data[$key] = $value;
76			}
77			}
78
79			/**
80			* Load data.
81			*
82			* @param string $data Either a path to a file or the content itself.
83			*
84			* @return string
85			*/
86			protected function load($data)
87			{
88			// check if the data is a file
89			if (strpos($data, "\n") === false && file_exists($data) && is_file($data)) {
90			$data = file_get_contents($data);
91
92			// strip BOM, if any
93			if (substr($data, 0, 3) == "\xef\xbb\xbf") {
94			$data = substr($data, 3);
95			}
96			}
97
98			return $data;
99			}
100
101			/**
102			* Save to file.
103			*
104			* @param string $content The minified data.
105			* @param string $path The path to save the minified data to.
106			*
107			* @throws Exception
108			*/
109			protected function save($content, $path)
110			{
111			// create file & open for writing
112			if (($handler = @fopen($path, 'w')) === false) {
113			throw new Exception('The file "'.$path.'" could not be opened. Check if PHP has enough permissions.');
114			}
115
116			// write to file
117			if (@fwrite($handler, $content) === false) {
118			throw new Exception('The file "'.$path.'" could not be written to. Check if PHP has enough permissions.');
119			}
120
121			// close the file
122			@fclose($handler);
			0 ignored issues – show Security Best Practice introduced 2015-12-17 21:43 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
123			}
124
125			/**
126			* Minify the data & (optionally) saves it to a file.
127			*
128			* @param string[optional] $path Path to write the data to.
129			*
130			* @return string The minified data.
131			*/
132			public function minify($path = null)
133			{
134			$content = $this->execute($path);
135
136			// save to path
137			if ($path !== null) {
138			$this->save($content, $path);
139			}
140
141			return $content;
142			}
143
144			/**
145			* Minify & gzip the data & (optionally) saves it to a file.
146			*
147			* @param string[optional] $path Path to write the data to.
148			* @param int[optional] $level Compression level, from 0 to 9.
149			*
150			* @return string The minified & gzipped data.
151			*/
152			public function gzip($path = null, $level = 9)
153			{
154			$content = $this->execute($path);
155			$content = gzencode($content, $level, FORCE_GZIP);
156
157			// save to path
158			if ($path !== null) {
159			$this->save($content, $path);
160			}
161
162			return $content;
163			}
164
165			/**
166			* Minify the data & write it to a CacheItemInterface object.
167			*
168			* @param CacheItemInterface $item Cache item to write the data to.
169			*
170			* @return CacheItemInterface Cache item with the minifier data.
171			*/
172			public function cache(CacheItemInterface $item)
173			{
174			$content = $this->execute();
175			$item->set($content);
176
177			return $item;
178			}
179
180			/**
181			* Minify the data.
182			*
183			* @param string[optional] $path Path to write the data to.
184			*
185			* @return string The minified data.
186			*/
187			abstract public function execute($path = null);
188
189			/**
190			* Register a pattern to execute against the source content.
191			*
192			* @param string $pattern PCRE pattern.
193			* @param string\|callable $replacement Replacement value for matched pattern.
194			*
195			* @throws Exception
196			*/
197			protected function registerPattern($pattern, $replacement = '')
198			{
199			// study the pattern, we'll execute it more than once
200			$pattern .= 'S';
201
202			$this->patterns[] = array($pattern, $replacement);
203			}
204
205			/**
206			* We can't "just" run some regular expressions against JavaScript: it's a
207			* complex language. E.g. having an occurrence of // xyz would be a comment,
208			* unless it's used within a string. Of you could have something that looks
209			* like a 'string', but inside a comment.
210			* The only way to accurately replace these pieces is to traverse the JS one
211			* character at a time and try to find whatever starts first.
212			*
213			* @param string $content The content to replace patterns in.
214			*
215			* @return string The (manipulated) content.
216			*/
217			protected function replace($content)
218			{
219			$processed = '';
220			$positions = array_fill(0, count($this->patterns), -1);
221			$matches = array();
222
223			while ($content) {
224			// find first match for all patterns
225			foreach ($this->patterns as $i => $pattern) {
226			list($pattern, $replacement) = $pattern;
227
228			// no need to re-run matches that are still in the part of the
229			// content that hasn't been processed
230			if ($positions[$i] >= 0) {
231			continue;
232			}
233
234			$match = null;
235			if (preg_match($pattern, $content, $match)) {
236			$matches[$i] = $match;
237
238			// we'll store the match position as well; that way, we
239			// don't have to redo all preg_matches after changing only
240			// the first (we'll still know where those others are)
241			$positions[$i] = strpos($content, $match[0]);
242			} else {
243			// if the pattern couldn't be matched, there's no point in
244			// executing it again in later runs on this same content;
245			// ignore this one until we reach end of content
246			unset($matches[$i]);
247			$positions[$i] = strlen($content);
248			}
249			}
250
251			// no more matches to find: everything's been processed, break out
252			if (!$matches) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-17 21:43 UTC by Report Bug Copy Issue Report The expression `$matches` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
253			$processed .= $content;
254			break;
255			}
256
257			// see which of the patterns actually found the first thing (we'll
258			// only want to execute that one, since we're unsure if what the
259			// other found was not inside what the first found)
260			$discardLength = min($positions);
261			$firstPattern = array_search($discardLength, $positions);
262			$match = $matches[$firstPattern][0];
263
264			// execute the pattern that matches earliest in the content string
265			list($pattern, $replacement) = $this->patterns[$firstPattern];
266			$replacement = $this->replacePattern($pattern, $replacement, $content);
267
268			// figure out which part of the string was unmatched; that's the
269			// part we'll execute the patterns on again next
270			$content = substr($content, $discardLength);
271			$unmatched = (string) substr($content, strpos($content, $match) + strlen($match));
272
273			// move the replaced part to $processed and prepare $content to
274			// again match batch of patterns against
275			$processed .= substr($replacement, 0, strlen($replacement) - strlen($unmatched));
276			$content = $unmatched;
277
278			// first match has been replaced & that content is to be left alone,
279			// the next matches will start after this replacement, so we should
280			// fix their offsets
281			foreach ($positions as $i => $position) {
282			$positions[$i] -= $discardLength + strlen($match);
283			}
284			}
285
286			return $processed;
287			}
288
289			/**
290			* This is where a pattern is matched against $content and the matches
291			* are replaced by their respective value.
292			* This function will be called plenty of times, where $content will always
293			* move up 1 character.
294			*
295			* @param string $pattern Pattern to match.
296			* @param string\|callable $replacement Replacement value.
297			* @param string $content Content to match pattern against.
298			*
299			* @return string
300			*/
301			protected function replacePattern($pattern, $replacement, $content)
302			{
303			if (is_callable($replacement)) {
304			return preg_replace_callback($pattern, $replacement, $content, 1, $count);
305			} else {
306			return preg_replace($pattern, $replacement, $content, 1, $count);
307			}
308			}
309
310			/**
311			* Strings are a pattern we need to match, in order to ignore potential
312			* code-like content inside them, but we just want all of the string
313			* content to remain untouched.
314			*
315			* This method will replace all string content with simple STRING#
316			* placeholder text, so we've rid all strings from characters that may be
317			* misinterpreted. Original string content will be saved in $this->extracted
318			* and after doing all other minifying, we can restore the original content
319			* via restoreStrings()
320			*
321			* @param string[optional] $chars
322			*/
323			protected function extractStrings($chars = '\'"')
324			{
325			// PHP only supports $this inside anonymous functions since 5.4
326			$minifier = $this;
327			$callback = function ($match) use ($minifier) {
328			if (!$match[1]) {
329			/*
330			* Empty strings need no placeholder; they can't be confused for
331			* anything else anyway.
332			* But we still needed to match them, for the extraction routine
333			* to skip over this particular string.
334			*/
335			return $match[0];
336			}
337
338			$count = count($minifier->extracted);
339			$placeholder = $match[1].$count.$match[1];
340			$minifier->extracted[$placeholder] = $match[1].$match[2].$match[1];
341
342			return $placeholder;
343			};
344
345			/*
346			* The \\ messiness explained:
347			* * Don't count ' or " as end-of-string if it's escaped (has backslash
348			* in front of it)
349			* * Unless... that backslash itself is escaped (another leading slash),
350			* in which case it's no longer escaping the ' or "
351			* * So there can be either no backslash, or an even number
352			* * multiply all of that times 4, to account for the escaping that has
353			* to be done to pass the backslash into the PHP string without it being
354			* considered as escape-char (times 2) and to get it in the regex,
355			* escaped (times 2)
356			*/
357			$this->registerPattern('/(['.$chars.'])(.?(?<!\\\\)(\\\\\\\\)+)\\1/s', $callback);
358			}
359
360			/**
361			* This method will restore all extracted data (strings, regexes) that were
362			* replaced with placeholder text in extract*(). The original content was
363			* saved in $this->extracted.
364			*
365			* @param string $content
366			*
367			* @return string
368			*/
369			protected function restoreExtractedData($content)
370			{
371			if (!$this->extracted) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-17 21:43 UTC by Report Bug Copy Issue Report The expression `$this->extracted` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
372			// nothing was extracted, nothing to restore
373			return $content;
374			}
375
376			$content = strtr($content, $this->extracted);
377
378			$this->extracted = array();
379
380			return $content;
381			}
382			}
383

matthiasmullie / minify

Pull Request — master (#90)

Minify::cache() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like