MatthiasMullie\Minify\JS::execute()

Complexity

Conditions	4
Paths	4

Size

Total Lines

77

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function execute($path = null)
    {
        /*
         * Let's first take out strings, comments and regular expressions.
         * All of these can contain JS code-like characters, and we should make
         * sure any further magic ignores anything inside of these.
         *
         * Consider this example, where we should not strip any whitespace:
         * var str = "a   test";
         *
         * Comments will be removed altogether, strings and regular expressions
         * will be replaced by placeholder text, which we'll restore later.
         */
        $this->extractStrings('\'"`');
        $this->stripComments();
        $this->extractRegex();

        $preservecommentpattern = '/(
             # optional newline
            \n?
            # start comment
            \/\*
            # comment content
            (?:
                # either starts with an !
                !
            |
                # or, after some number of characters which do not end the comment
                (?:(?!\*\/).)*?
                # there is either a @license or @preserve tag
                @(?:license|preserve)
            )
            # then match to the end of the comment
            .*?\*\/\n?
            )/ixs';
        // loop files
        foreach ($this->data as $source => $js) {

            // Split JS on special comments.
            $chunks = preg_split($preservecommentpattern, $js, -1, PREG_SPLIT_DELIM_CAPTURE );
            $processed = [];
            for ($i = 0; $i < count($chunks); $i += 2) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $code = $chunks[$i];
                $comment = '';
                if (isset($chunks[$i + 1])) {
                    $comment = $chunks[$i + 1];
                }

                // take out strings, other comments & regex (for which we've registered
                // the regexes just a few lines earlier)
                $code = $this->replace($code);

                $code = $this->propertyNotation($code);
                $code = $this->shortenBools($code);
                $code = $this->stripWhitespace($code);

                $processed[] = $code;
                $processed[] = $comment;
            }
            $file = implode($processed);
            // ASI at end of file, will be added back if concatenated later.
            $file = preg_replace('/;$/s', '', $file);

            $files[] = $file;

$files was never initialized. Although not strictly required by PHP, it is generally a good practice to add $files = array(); before regardless.

        }
        $content = implode(';', $files);

The variable $files does not seem to be defined for all execution paths leading up to this point.

        // clean up leftover `;`s from the combination of multiple scripts
        $content = ltrim($content, ';');

        /*
         * Earlier, we extracted strings & regular expressions and replaced them
         * with placeholder text. This will restore them.
         */
        $content = $this->restoreExtractedData($content);

        return $content;
    }