Complex classes like CSS often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CSS, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 18 | class CSS extends Minify |
||
| 19 | { |
||
| 20 | /** |
||
| 21 | * @var int |
||
| 22 | */ |
||
| 23 | protected $maxImportSize = 5; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * @var string[] |
||
| 27 | */ |
||
| 28 | protected $importExtensions = array( |
||
| 29 | 'gif' => 'data:image/gif', |
||
| 30 | 'png' => 'data:image/png', |
||
| 31 | 'jpe' => 'data:image/jpeg', |
||
| 32 | 'jpg' => 'data:image/jpeg', |
||
| 33 | 'jpeg' => 'data:image/jpeg', |
||
| 34 | 'svg' => 'data:image/svg+xml', |
||
| 35 | 'woff' => 'data:application/x-font-woff', |
||
| 36 | 'tif' => 'image/tiff', |
||
| 37 | 'tiff' => 'image/tiff', |
||
| 38 | 'xbm' => 'image/x-xbitmap', |
||
| 39 | ); |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Set the maximum size if files to be imported. |
||
| 43 | * |
||
| 44 | * Files larger than this size (in kB) will not be imported into the CSS. |
||
| 45 | * Importing files into the CSS as data-uri will save you some connections, |
||
| 46 | * but we should only import relatively small decorative images so that our |
||
| 47 | * CSS file doesn't get too bulky. |
||
| 48 | * |
||
| 49 | * @param int $size Size in kB |
||
| 50 | */ |
||
| 51 | public function setMaxImportSize($size) |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Set the type of extensions to be imported into the CSS (to save network |
||
| 58 | * connections). |
||
| 59 | * Keys of the array should be the file extensions & respective values |
||
| 60 | * should be the data type. |
||
| 61 | * |
||
| 62 | * @param string[] $extensions Array of file extensions |
||
| 63 | */ |
||
| 64 | public function setImportExtensions(array $extensions) |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Move any import statements to the top. |
||
| 71 | * |
||
| 72 | * @param string $content Nearly finished CSS content |
||
| 73 | * |
||
| 74 | * @return string |
||
| 75 | */ |
||
| 76 | protected function moveImportsToTop($content) |
||
| 90 | |||
| 91 | /** |
||
| 92 | * Combine CSS from import statements. |
||
| 93 | * |
||
| 94 | * @import's will be loaded and their content merged into the original file, |
||
| 95 | * to save HTTP requests. |
||
| 96 | * |
||
| 97 | * @param string $source The file to combine imports for |
||
| 98 | * @param string $content The CSS content to combine imports for |
||
| 99 | * @param string[] $parents Parent paths, for circular reference checks |
||
| 100 | * |
||
| 101 | * @return string |
||
| 102 | * |
||
| 103 | * @throws FileImportException |
||
| 104 | */ |
||
| 105 | protected function combineImports($source, $content, $parents) |
||
| 106 | { |
||
| 107 | $importRegexes = array( |
||
| 108 | // @import url(xxx) |
||
| 109 | '/ |
||
| 110 | # import statement |
||
| 111 | @import |
||
| 112 | |||
| 113 | # whitespace |
||
| 114 | \s+ |
||
| 115 | |||
| 116 | # open url() |
||
| 117 | url\( |
||
| 118 | |||
| 119 | # (optional) open path enclosure |
||
| 120 | (?P<quotes>["\']?) |
||
| 121 | |||
| 122 | # fetch path |
||
| 123 | (?P<path> |
||
| 124 | |||
| 125 | # do not fetch data uris, external sources or absolute paths |
||
| 126 | (?!( |
||
| 127 | ["\']? |
||
| 128 | (data:|https?:\\/\\/|\\/) |
||
| 129 | )) |
||
| 130 | |||
| 131 | .+? |
||
| 132 | ) |
||
| 133 | |||
| 134 | # (optional) close path enclosure |
||
| 135 | (?P=quotes) |
||
| 136 | |||
| 137 | # close url() |
||
| 138 | \) |
||
| 139 | |||
| 140 | # (optional) trailing whitespace |
||
| 141 | \s* |
||
| 142 | |||
| 143 | # (optional) media statement(s) |
||
| 144 | (?P<media>[^;]*) |
||
| 145 | |||
| 146 | # (optional) trailing whitespace |
||
| 147 | \s* |
||
| 148 | |||
| 149 | # (optional) closing semi-colon |
||
| 150 | ;? |
||
| 151 | |||
| 152 | /ix', |
||
| 153 | |||
| 154 | // @import 'xxx' |
||
| 155 | '/ |
||
| 156 | |||
| 157 | # import statement |
||
| 158 | @import |
||
| 159 | |||
| 160 | # whitespace |
||
| 161 | \s+ |
||
| 162 | |||
| 163 | # open path enclosure |
||
| 164 | (?P<quotes>["\']) |
||
| 165 | |||
| 166 | # fetch path |
||
| 167 | (?P<path> |
||
| 168 | |||
| 169 | # do not fetch data uris, external sources or absolute paths |
||
| 170 | (?!( |
||
| 171 | ["\']? |
||
| 172 | (data:|https?:\\/\\/|\\/) |
||
| 173 | )) |
||
| 174 | |||
| 175 | .+? |
||
| 176 | ) |
||
| 177 | |||
| 178 | # close path enclosure |
||
| 179 | (?P=quotes) |
||
| 180 | |||
| 181 | # (optional) trailing whitespace |
||
| 182 | \s* |
||
| 183 | |||
| 184 | # (optional) media statement(s) |
||
| 185 | (?P<media>[^;]*) |
||
| 186 | |||
| 187 | # (optional) trailing whitespace |
||
| 188 | \s* |
||
| 189 | |||
| 190 | # (optional) closing semi-colon |
||
| 191 | ;? |
||
| 192 | |||
| 193 | /ix', |
||
| 194 | ); |
||
| 195 | |||
| 196 | // find all relative imports in css |
||
| 197 | $matches = array(); |
||
| 198 | foreach ($importRegexes as $importRegex) { |
||
| 199 | if (preg_match_all($importRegex, $content, $regexMatches, PREG_SET_ORDER)) { |
||
| 200 | $matches = array_merge($matches, $regexMatches); |
||
| 201 | } |
||
| 202 | } |
||
| 203 | |||
| 204 | $search = array(); |
||
| 205 | $replace = array(); |
||
| 206 | |||
| 207 | // loop the matches |
||
| 208 | foreach ($matches as $match) { |
||
| 209 | // get the path for the file that will be imported |
||
| 210 | $importPath = dirname($source).'/'.$match['path']; |
||
| 211 | |||
| 212 | // only replace the import with the content if we can grab the |
||
| 213 | // content of the file |
||
| 214 | if (!$this->canImportByPath($match['path']) || !$this->canImportFile($importPath)) { |
||
| 215 | continue; |
||
| 216 | } |
||
| 217 | |||
| 218 | // check if current file was not imported previously in the same |
||
| 219 | // import chain. |
||
| 220 | if (in_array($importPath, $parents)) { |
||
| 221 | throw new FileImportException('Failed to import file "'.$importPath.'": circular reference detected.'); |
||
| 222 | } |
||
| 223 | |||
| 224 | // grab referenced file & minify it (which may include importing |
||
| 225 | // yet other @import statements recursively) |
||
| 226 | $minifier = new static($importPath); |
||
| 227 | $importContent = $minifier->execute($source, $parents); |
||
| 228 | |||
| 229 | // check if this is only valid for certain media |
||
| 230 | if (!empty($match['media'])) { |
||
| 231 | $importContent = '@media '.$match['media'].'{'.$importContent.'}'; |
||
| 232 | } |
||
| 233 | |||
| 234 | // add to replacement array |
||
| 235 | $search[] = $match[0]; |
||
| 236 | $replace[] = $importContent; |
||
| 237 | } |
||
| 238 | |||
| 239 | // replace the import statements |
||
| 240 | return str_replace($search, $replace, $content); |
||
| 241 | } |
||
| 242 | |||
| 243 | /** |
||
| 244 | * Import files into the CSS, base64-ized. |
||
| 245 | * |
||
| 246 | * @url(image.jpg) images will be loaded and their content merged into the |
||
| 247 | * original file, to save HTTP requests. |
||
| 248 | * |
||
| 249 | * @param string $source The file to import files for |
||
| 250 | * @param string $content The CSS content to import files for |
||
| 251 | * |
||
| 252 | * @return string |
||
| 253 | */ |
||
| 254 | protected function importFiles($source, $content) |
||
| 255 | { |
||
| 256 | $extensions = array_keys($this->importExtensions); |
||
| 257 | $regex = '/url\((["\']?)(.*?\.('.implode('|', $extensions).'))\\1\)/i'; |
||
| 258 | if ($extensions && preg_match_all($regex, $content, $matches, PREG_SET_ORDER)) { |
||
|
|
|||
| 259 | $search = array(); |
||
| 260 | $replace = array(); |
||
| 261 | |||
| 262 | // loop the matches |
||
| 263 | foreach ($matches as $match) { |
||
| 264 | // get the path for the file that will be imported |
||
| 265 | $path = $match[2]; |
||
| 266 | $path = dirname($source).'/'.$path; |
||
| 267 | $extension = $match[3]; |
||
| 268 | |||
| 269 | // only replace the import with the content if we're able to get |
||
| 270 | // the content of the file, and it's relatively small |
||
| 271 | if ($this->canImportByPath($match[2]) && $this->canImportFile($path) && $this->canImportBySize($path)) { |
||
| 272 | // grab content && base64-ize |
||
| 273 | $importContent = $this->load($path); |
||
| 274 | $importContent = base64_encode($importContent); |
||
| 275 | |||
| 276 | // build replacement |
||
| 277 | $search[] = $match[0]; |
||
| 278 | $replace[] = 'url('.$this->importExtensions[$extension].';base64,'.$importContent.')'; |
||
| 279 | } |
||
| 280 | } |
||
| 281 | |||
| 282 | // replace the import statements |
||
| 283 | $content = str_replace($search, $replace, $content); |
||
| 284 | } |
||
| 285 | |||
| 286 | return $content; |
||
| 287 | } |
||
| 288 | |||
| 289 | /** |
||
| 290 | * Minify the data. |
||
| 291 | * Perform CSS optimizations. |
||
| 292 | * |
||
| 293 | * @param string[optional] $path Path to write the data to |
||
| 294 | * @param string[] $parents Parent paths, for circular reference checks |
||
| 295 | * |
||
| 296 | * @return string The minified data |
||
| 297 | */ |
||
| 298 | public function execute($path = null, $parents = array()) |
||
| 346 | |||
| 347 | /** |
||
| 348 | * Moving a css file should update all relative urls. |
||
| 349 | * Relative references (e.g. ../images/image.gif) in a certain css file, |
||
| 350 | * will have to be updated when a file is being saved at another location |
||
| 351 | * (e.g. ../../images/image.gif, if the new CSS file is 1 folder deeper). |
||
| 352 | * |
||
| 353 | * @param Converter $converter Relative path converter |
||
| 354 | * @param string $content The CSS content to update relative urls for |
||
| 355 | * |
||
| 356 | * @return string |
||
| 357 | */ |
||
| 358 | protected function move(Converter $converter, $content) |
||
| 459 | |||
| 460 | /** |
||
| 461 | * Shorthand hex color codes. |
||
| 462 | * #FF0000 -> #F00. |
||
| 463 | * |
||
| 464 | * @param string $content The CSS content to shorten the hex color codes for |
||
| 465 | * |
||
| 466 | * @return string |
||
| 467 | */ |
||
| 468 | protected function shortenHex($content) |
||
| 511 | |||
| 512 | /** |
||
| 513 | * Shorten CSS font weights. |
||
| 514 | * |
||
| 515 | * @param string $content The CSS content to shorten the font weights for |
||
| 516 | * |
||
| 517 | * @return string |
||
| 518 | */ |
||
| 519 | protected function shortenFontWeights($content) |
||
| 532 | |||
| 533 | /** |
||
| 534 | * Shorthand 0 values to plain 0, instead of e.g. -0em. |
||
| 535 | * |
||
| 536 | * @param string $content The CSS content to shorten the zero values for |
||
| 537 | * |
||
| 538 | * @return string |
||
| 539 | */ |
||
| 540 | protected function shortenZeroes($content) |
||
| 590 | |||
| 591 | /** |
||
| 592 | * Strip comments from source code. |
||
| 593 | * |
||
| 594 | * @param string $content |
||
| 595 | * |
||
| 596 | * @return string |
||
| 597 | */ |
||
| 598 | protected function stripEmptyTags($content) |
||
| 602 | |||
| 603 | /** |
||
| 604 | * Strip comments from source code. |
||
| 605 | */ |
||
| 606 | protected function stripComments() |
||
| 610 | |||
| 611 | /** |
||
| 612 | * Strip whitespace. |
||
| 613 | * |
||
| 614 | * @param string $content The CSS content to strip the whitespace for |
||
| 615 | * |
||
| 616 | * @return string |
||
| 617 | */ |
||
| 618 | protected function stripWhitespace($content) |
||
| 644 | |||
| 645 | /** |
||
| 646 | * Check if file is small enough to be imported. |
||
| 647 | * |
||
| 648 | * @param string $path The path to the file |
||
| 649 | * |
||
| 650 | * @return bool |
||
| 651 | */ |
||
| 652 | protected function canImportBySize($path) |
||
| 656 | |||
| 657 | /** |
||
| 658 | * Check if file a file can be imported, going by the path. |
||
| 659 | * |
||
| 660 | * @param string $path |
||
| 661 | * |
||
| 662 | * @return bool |
||
| 663 | */ |
||
| 664 | protected function canImportByPath($path) |
||
| 668 | } |
||
| 669 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.