LM\AuthAbstractor\Test\KernelMocker

Complexity

Total Complexity

14

Size/Duplication

Total Lines	124
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

14 Methods

Rating	Name	Duplication	Size	Complexity
	createKernel()	0	104	?
A	hp$0 ➔ getTokenStorage()	0	3	1
A	hp$0 ➔ getComposerDir()	0	3	1
A	hp$0 ➔ getCustomTwigDir()	0	3	1
A	hp$0 ➔ getAppId()	0	3	1
A	hp$0 ➔ getLibDir()	0	3	1
A	hp$0 ➔ getU2fRegistrations()	0	3	1
A	hp$0 ➔ isExistingMember()	0	3	1
B	hp$0 ➔ createKernel()	0	104	1
A	hp$0 ➔ __construct()	0	13	1
A	hp$0 ➔ getU2fCertificates()	0	3	1
A	hp$0 ➔ getMember()	0	8	2
A	hp$0 ➔ getAssetUri()	0	3	1
A	hp$0 ➔ getPwdSettings()	0	3	1

<?php

declare(strict_types=1);

namespace LM\AuthAbstractor\Test;

use LM\AuthAbstractor\Controller\AuthenticationKernel;
use LM\AuthAbstractor\Configuration\IApplicationConfiguration;
use LM\AuthAbstractor\Model\IMember;
use LM\AuthAbstractor\Model\IAuthenticationKernel;
use LM\AuthAbstractor\Mocker\U2fMocker;
use LM\AuthAbstractor\Implementation\Member;
use Symfony\Component\Security\Csrf\TokenStorage\TokenStorageInterface;
use Symfony\Component\Security\Csrf\TokenStorage\SessionTokenStorage;
use InvalidArgumentException;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;

/**
 * Mocks the kernel.
 *
 * It only supports one user
 *
 * @internal
 * @todo Maybe it should be moved in tests?
 */
class KernelMocker
{
    const KEY_PWD_SETTINGS = 'pwdSettings';

    const KEY_U2F_CERTIFICATES = 'u2fCertificates';

    const KEY_USER_ID = 'userId';

    const KEY_USER_PWD = 'userPwd';

    const USER_ID = 'user';

    const USER_PWD = 'pwd';

    /**
     * @param array $options An array of options for initialising the kernel.
     * The available options are the constants of KernelMocker that begin with
     * KEY_.
     * @return IAuthenticationKernel A kernel that can be used for unit testing.
     */
    public function createKernel(array $options = []): IAuthenticationKernel
    {
        if (!isset($options[self::KEY_U2F_CERTIFICATES])) {
            $options[self::KEY_U2F_CERTIFICATES] = null;
        }
        if (!isset($options[self::KEY_PWD_SETTINGS])) {
            $options[self::KEY_PWD_SETTINGS] = [
                'min_length' => 0,
                'enforce_min_length' => false,
                'uppercase' => false,
                'special_chars' => false,
                'numbers' => false,
            ];
        }
        if (!isset($options[self::KEY_USER_ID])) {
            $options[self::KEY_USER_ID] = self::USER_ID;
        }
        if (!isset($options[self::KEY_USER_PWD])) {
            $options[self::KEY_USER_PWD] = self::USER_PWD;
        }
        return new AuthenticationKernel(
            new class($options[self::KEY_U2F_CERTIFICATES], $options[self::KEY_PWD_SETTINGS], $options[self::KEY_USER_ID], $options[self::KEY_USER_PWD]) implements IApplicationConfiguration {
                private $cas;

                private $hashedPassword;

                private $tokenStorage;
            
                private $username;

                public function __construct(
                    ?array $cas,
                    array $pwdSettings,
                    string $username,
                    string $password
                ) {
                    $this->cas = $cas;
                    $this->hashedPassword = password_hash($password, PASSWORD_DEFAULT);
                    $this->pwdSettings = $pwdSettings;

The property pwdSettings does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                    $this->tokenStorage = new SessionTokenStorage(new Session(
                        new MockArraySessionStorage()
                    ));
                    $this->username = $username;
                }

                public function getAssetUri(string $assetId): string
                {
                    return 'https://example.org';
                }

                public function getAppId(): string
                {
                    return 'https://example.org';
                }

                public function getComposerDir(): string
                {
                    return realpath(__DIR__.'/../../../../vendor');
                }

                public function getCustomTwigDir(): ?string
                {
                    return null;
                }

                public function getLibDir(): string
                {
                    return realpath(__DIR__.'/../../../..');
                }

                public function getMember(string $username): IMember
                {
                    if ($this->username !== $username) {
                        throw new InvalidArgumentException();
                    }
                    return new Member(
                        $this->hashedPassword,

It seems like $this->hashedPassword can also be of type null; however, parameter $hashedPassword of LM\AuthAbstractor\Implementation\Member::__construct() does only seem to accept string, maybe add an additional type check?

                        $this->username
                    );
                }

                public function getU2fCertificates(): ?array
                {
                    return $this->cas;
                }

                public function getU2fRegistrations(string $username): array
                {
                    return (new U2fMocker($this))->getU2fRegistrationsOnly();
                }

                public function getPwdSettings(): array
                {
                    return $this->pwdSettings;
                }

                public function getTokenStorage(): TokenStorageInterface
                {
                    return $this->tokenStorage;
                }

                public function isExistingMember(string $username): bool
                {
                    return $this->username === $username;
                }
            }
        );
    }
}