| Conditions | 6 |
| Paths | 18 |
| Total Lines | 55 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 39 | public function Create(Application $app, Request $request) { |
||
| 40 | $draftId = (int)$request->get('draft_id'); |
||
| 41 | $draft = $app['phpdraft.DraftRepository']->Load($draftId); |
||
| 42 | |||
| 43 | $newTrade = new Trade(); |
||
| 44 | $newTrade->draft_id = $draftId; |
||
| 45 | $newTrade->manager1_id = $request->get('manager1_id'); |
||
| 46 | $newTrade->manager2_id = $request->get('manager2_id'); |
||
| 47 | |||
| 48 | $newTrade->trade_round = $draft->draft_current_round; |
||
|
|
|||
| 49 | |||
| 50 | $assets_json = $request->get('trade_assets'); |
||
| 51 | |||
| 52 | try { |
||
| 53 | $newTrade->manager1 = $app['phpdraft.ManagerRepository']->Load($newTrade->manager1_id); |
||
| 54 | $newTrade->manager2 = $app['phpdraft.ManagerRepository']->Load($newTrade->manager2_id); |
||
| 55 | |||
| 56 | foreach($assets_json as $asset_id) { |
||
| 57 | $newTradeAsset = new TradeAsset(); |
||
| 58 | $newTradeAsset->player = $app['phpdraft.PickRepository']->Load($asset_id); |
||
| 59 | $newTradeAsset->was_drafted = $app['phpdraft.PickService']->PickHasBeenSelected($newTradeAsset->player); |
||
| 60 | |||
| 61 | if($newTradeAsset->player->manager_id == $newTrade->manager1_id) { |
||
| 62 | $newTradeAsset->oldmanager_id = $newTrade->manager1_id; |
||
| 63 | $newTradeAsset->newmanager_id = $newTrade->manager2_id; |
||
| 64 | $newTradeAsset->oldmanager = $newTrade->manager1; |
||
| 65 | $newTradeAsset->newmanager = $newTrade->manager2; |
||
| 66 | } else if($newTradeAsset->player->manager_id == $newTrade->manager2_id) { |
||
| 67 | $newTradeAsset->oldmanager_id = $newTrade->manager2_id; |
||
| 68 | $newTradeAsset->newmanager_id = $newTrade->manager1_id; |
||
| 69 | $newTradeAsset->oldmanager = $newTrade->manager2; |
||
| 70 | $newTradeAsset->newmanager = $newTrade->manager1; |
||
| 71 | } else { |
||
| 72 | throw new \Exception("Invalid trade data."); |
||
| 73 | } |
||
| 74 | |||
| 75 | $newTrade->trade_assets[] = $newTradeAsset; |
||
| 76 | } |
||
| 77 | } catch(\Exception $e) { |
||
| 78 | $response = new PhpDraftResponse(false, array()); |
||
| 79 | $message = $e->getMessage(); |
||
| 80 | $response->errors[] = "Unable to build trade: $message"; |
||
| 81 | |||
| 82 | return $app->json($response, Response::HTTP_BAD_REQUEST); |
||
| 83 | } |
||
| 84 | |||
| 85 | $validity = $app['phpdraft.TradeValidator']->IsTradeValid($draft, $newTrade); |
||
| 86 | |||
| 87 | if(!$validity->success) { |
||
| 88 | return $app->json($validity, Response::HTTP_BAD_REQUEST); |
||
| 89 | } |
||
| 90 | |||
| 91 | $response = $app['phpdraft.TradeService']->EnterTrade($draft, $newTrade); |
||
| 92 | |||
| 93 | return $app->json($response, $response->responseType(Response::HTTP_CREATED)); |
||
| 94 | } |
||
| 95 | } |