mattheworres / phpdraft

api/Domain/Repositories/TradeRepository.php

Spacing +4 added lines, -4 removed lines

@@ -31,7 +31,7 @@ 
         $trade->manager1 = $this->app['phpdraft.ManagerRepository']->Load($trade->manager1_id);
         $trade->manager2 = $this->app['phpdraft.ManagerRepository']->Load($trade->manager2_id);
         $trade->trade_assets = $this->GetAssets($trade, $trade->manager1, $trade->manager2);
-      }catch(\Exception $e) {
+      } catch (\Exception $e) {
         throw new \Exception("Unable to load managers or trade assets: " . $e->getMessage());
       }
 
@@ -83,7 +83,7 @@ 
     $draft_trade_stmt->bindParam(1, $draft_id);
     $draft_trade_stmt->setFetchMode(\PDO::FETCH_CLASS, '\PhpDraft\Domain\Entities\Trade');
 
-    if(!$draft_trade_stmt->execute()) {
+    if (!$draft_trade_stmt->execute()) {
       throw new \Exception("Unable to delete trades for draft $draft_id");
     }
 
@@ -134,13 +134,13 @@ 
 
     $stmt->bindParam(':trade_id', $trade->trade_id);
 
-    foreach($trade->trade_assets as &$asset) {
+    foreach ($trade->trade_assets as &$asset) {
       $stmt->bindParam(':player_id', $asset->player->player_id);
       $stmt->bindParam(':oldmanager_id', $asset->oldmanager->manager_id);
       $stmt->bindParam(':newmanager_id', $asset->newmanager->manager_id);
       $stmt->bindParam(':was_drafted', $asset->was_drafted);
 
-      if(!$stmt->execute()) {
+      if (!$stmt->execute()) {
         throw new Exception("Unable to save trade asset #$asset->player_id");
       }
 

Braces +19 added lines, -13 removed lines

@@ -31,7 +31,7 @@ 
         $trade->manager1 = $this->app['phpdraft.ManagerRepository']->Load($trade->manager1_id);
         $trade->manager2 = $this->app['phpdraft.ManagerRepository']->Load($trade->manager2_id);
         $trade->trade_assets = $this->GetAssets($trade, $trade->manager1, $trade->manager2);
-      }catch(\Exception $e) {
+      } catch(\Exception $e) {
         throw new \Exception("Unable to load managers or trade assets: " . $e->getMessage());
       }
 
@@ -58,19 +58,22 @@ 
     while ($asset = $stmt->fetch()) {
       /* @var $asset trade_asset_object */
       //We must use the protected $newmanager_id and $oldmanager_id because we have just pulled from DB, objs aren't automatic:
-      if ($asset->newmanager_id != $manager1->manager_id && $asset->newmanager_id != $manager2->manager_id)
-        throw new \Exception('Invalid manager ID for asset: ' . $asset->newmanager_id);
+      if ($asset->newmanager_id != $manager1->manager_id && $asset->newmanager_id != $manager2->manager_id) {
+              throw new \Exception('Invalid manager ID for asset: ' . $asset->newmanager_id);
+      }
 
-      if ($asset->oldmanager_id != $manager1->manager_id && $asset->oldmanager_id != $manager2->manager_id)
-        throw new \Exception('Invalid manager ID for asset: ' . $asset->oldmanager_id);
+      if ($asset->oldmanager_id != $manager1->manager_id && $asset->oldmanager_id != $manager2->manager_id) {
+              throw new \Exception('Invalid manager ID for asset: ' . $asset->oldmanager_id);
+      }
 
       //Use passed in manager_objects to prevent unneccessary SELECTs to the db:
       $asset->player = $this->app['phpdraft.PickRepository']->Load($asset->player_id);
       $asset->newmanager = $asset->newmanager_id == $manager1->manager_id ? $manager1 : $manager2;
       $asset->oldmanager = $asset->oldmanager_id == $manager1->manager_id ? $manager1 : $manager2;
 
-      if ($asset->player == false || $asset->newmanager == false || $asset->oldmanager == false)
-        throw new \Exception('Invalid asset loaded.');
+      if ($asset->player == false || $asset->newmanager == false || $asset->oldmanager == false) {
+              throw new \Exception('Invalid asset loaded.');
+      }
 
       $assets[] = $asset;
     }
@@ -89,8 +92,9 @@ 
 
     $trades = array();
 
-    while ($trade = $draft_trade_stmt->fetch())
-      $trades[] = $trade;
+    while ($trade = $draft_trade_stmt->fetch()) {
+          $trades[] = $trade;
+    }
 
     $delete_assets_stmt = $this->app['db']->prepare("DELETE FROM trade_assets WHERE trade_id = :trade_id");
     $delete_trade_stmt = $this->app['db']->prepare("DELETE FROM trades WHERE trade_id = :trade_id");
@@ -98,13 +102,15 @@ 
     foreach ($trades as $trade) {
       $delete_assets_stmt->bindValue(":trade_id", $trade->trade_id);
 
-      if (!$delete_assets_stmt->execute())
-        throw new \Exception("Unable to delete trade assets for $draft_id.");
+      if (!$delete_assets_stmt->execute()) {
+              throw new \Exception("Unable to delete trade assets for $draft_id.");
+      }
 
       $delete_trade_stmt->bindValue(":trade_id", $trade->trade_id);
 
-      if (!$delete_trade_stmt->execute())
-        throw new \Exception("Unable to delete trade assets for $draft_id.");
+      if (!$delete_trade_stmt->execute()) {
+              throw new \Exception("Unable to delete trade assets for $draft_id.");
+      }
     }
 
     return;

api/Domain/Repositories/DepthChartPositionRepository.php

Spacing +4 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
   public function LoadAll($draft_id) {
     $positions = array();
     
-    $stmt = $this->app['db']->prepare("SELECT d.* ".
+    $stmt = $this->app['db']->prepare("SELECT d.* " .
             "FROM depth_chart_positions d " .
             "WHERE d.draft_id = ? " .
             "ORDER BY d.display_order");
@@ -26,11 +26,11 @@ 
     
     $stmt->setFetchMode(\PDO::FETCH_CLASS, '\PhpDraft\Domain\Entities\DepthChartPosition');
     
-    if(!$stmt->execute()) {
+    if (!$stmt->execute()) {
       throw new \Exception("Unable to load updated positions.");
     }
     
-    while($position = $stmt->fetch()) {
+    while ($position = $stmt->fetch()) {
       $positions[] = $position;
     }
     
@@ -66,7 +66,7 @@ 
     $delete_stmt = $this->app['db']->prepare("DELETE FROM depth_chart_positions WHERE draft_id = ?");
     $delete_stmt->bindParam(1, $draft_id);
 
-    if(!$delete_stmt->execute()) {
+    if (!$delete_stmt->execute()) {
       throw new \Exception("Unable to delete existing depth chart positions.");
     }
   }

api/Domain/Repositories/ManagerRepository.php

Spacing +17 added lines, -17 removed lines

@@ -35,11 +35,11 @@ 
 
     $managers_stmt->bindParam(1, $draft_id);
 
-    if(!$managers_stmt->execute()) {
+    if (!$managers_stmt->execute()) {
       throw new \Exception("Unable to load managers for draft #$draft_id");
     }
 
-    while($manager = $managers_stmt->fetch()) {
+    while ($manager = $managers_stmt->fetch()) {
       $managers[] = $manager;
     }
 
@@ -49,7 +49,7 @@ 
   public function GetManagersByDraftOrder($draft_id, $descending = false) {
     $managers = array();
 
-    if($descending) {
+    if ($descending) {
       $managers_stmt = $this->app['db']->prepare("SELECT * FROM managers WHERE draft_id = ? ORDER BY draft_order DESC");
     } else {
       $managers_stmt = $this->app['db']->prepare("SELECT * FROM managers WHERE draft_id = ? ORDER BY draft_order");  
@@ -59,11 +59,11 @@ 
 
     $managers_stmt->setFetchMode(\PDO::FETCH_CLASS, '\PhpDraft\Domain\Entities\Manager');
 
-    if(!$managers_stmt->execute()) {
+    if (!$managers_stmt->execute()) {
       throw new \Exception("Unable to load managers for draft #$draft_id");
     }
 
-    while($manager = $managers_stmt->fetch()) {
+    while ($manager = $managers_stmt->fetch()) {
       $managers[] = $manager;
     }
 
@@ -75,7 +75,7 @@ 
     $manager_stmt = $this->app['db']->prepare("SELECT manager_name FROM managers WHERE draft_id = ?");
     $manager_stmt->bindParam(1, $draft_id);
 
-    if(!$manager_stmt->execute()) {
+    if (!$manager_stmt->execute()) {
       throw new \Exception("Draft id '%s' is invalid", $draft_id);
     }
 
@@ -86,7 +86,7 @@ 
     $manager_stmt = $this->app['db']->prepare("SELECT COUNT(manager_id) FROM managers WHERE draft_id = ?");
     $manager_stmt->bindParam(1, $draft_id);
 
-    if(!$manager_stmt->execute()) {
+    if (!$manager_stmt->execute()) {
       throw new \Exception("Unable to get number of managers for draft #$draft_id");
     }
 
@@ -94,7 +94,7 @@ 
   }
 
   public function NameIsUnique($name, $draft_id, $id = null) {
-    if(!empty($id)) {
+    if (!empty($id)) {
       $name_stmt = $this->app['db']->prepare("SELECT manager_name FROM managers WHERE manager_name LIKE ? AND draft_id = ? AND manager_id <> ?");
       $name_stmt->bindParam(1, $name);
       $name_stmt->bindParam(2, $draft_id);
@@ -105,7 +105,7 @@ 
       $name_stmt->bindParam(2, $draft_id);
     }
 
-    if(!$name_stmt->execute()) {
+    if (!$name_stmt->execute()) {
       throw new \Exception("Manager name '$name' is invalid");
     }
 
@@ -117,7 +117,7 @@ 
     $exists_stmt->bindParam(1, $id);
     $exists_stmt->bindParam(2, $draft_id);
 
-    if(!$exists_stmt->execute()) {
+    if (!$exists_stmt->execute()) {
       throw new \Exception("Manager ID $id is invalid");
     }
 
@@ -136,7 +136,7 @@ 
       throw new \Exception("Unable to create new manager: " . $this->app['db']->errorInfo());
     }
 
-    $manager->manager_id = (int) $this->app['db']->lastInsertId();
+    $manager->manager_id = (int)$this->app['db']->lastInsertId();
 
     return $manager;
   }
@@ -148,7 +148,7 @@ 
     $newDraftOrder = $this->_GetLowestDraftorder($draft_id) + 1;
     $newManagers = array();
 
-    foreach($managersArray as $newManager) {
+    foreach ($managersArray as $newManager) {
       $save_stmt->bindValue(':draft_id', $newManager->draft_id);
       $save_stmt->bindValue(':manager_name', $newManager->manager_name);
       $save_stmt->bindValue(':draft_order', $newDraftOrder++);
@@ -169,7 +169,7 @@ 
     $update_stmt->bindParam(1, $manager->manager_name);
     $update_stmt->bindParam(2, $manager->manager_id);
 
-    if(!$update_stmt->execute()) {
+    if (!$update_stmt->execute()) {
       throw new \Exception("Unable to update manager #$manager->manager_id");
     }
 
@@ -181,11 +181,11 @@ 
 
     $newDraftOrder = 1;
 
-    foreach($managersIdArray as $manager_id) {
+    foreach ($managersIdArray as $manager_id) {
       $reorder_stmt->bindValue(':draft_order', $newDraftOrder++);
       $reorder_stmt->bindValue(':manager_id', $manager_id);
 
-      if(!$reorder_stmt->execute()) {
+      if (!$reorder_stmt->execute()) {
         throw new \Exception("Unable to update manager order for manager #$manager_id");
       }
     }
@@ -197,7 +197,7 @@ 
     $delete_stmt = $this->app['db']->prepare("DELETE FROM managers WHERE manager_id = ?");
     $delete_stmt->bindParam(1, $manager_id);
 
-    if(!$delete_stmt->execute()) {
+    if (!$delete_stmt->execute()) {
       throw new \Exception("Unable to delete manager $manager_id.");
     }
 
@@ -208,7 +208,7 @@ 
     $delete_stmt = $this->app['db']->prepare("DELETE FROM managers WHERE draft_id = ?");
     $delete_stmt->bindParam(1, $draft_id);
 
-    if(!$delete_stmt->execute()) {
+    if (!$delete_stmt->execute()) {
       throw new \Exception("Unable to delete managers for draft $draft_id.");
     }
 

Braces +6 added lines, -4 removed lines

@@ -18,11 +18,13 @@
     $load_stmt->setFetchMode(\PDO::FETCH_INTO, $manager);
     $load_stmt->bindParam(1, $id);
 
-    if (!$load_stmt->execute())
-      throw new \Exception(sprintf('Manager "%s" does not exist.', $manager));
+    if (!$load_stmt->execute()) {
+          throw new \Exception(sprintf('Manager "%s" does not exist.', $manager));
+    }
 
-    if (!$load_stmt->fetch())
-      throw new \Exception(sprintf('Manager "%s" does not exist.', $id));
+    if (!$load_stmt->fetch()) {
+          throw new \Exception(sprintf('Manager "%s" does not exist.', $id));
+    }
 
     return $manager;
   }

api/Controllers/Commish/DepthChartPositionController.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 
     $validity = $app['phpdraft.DepthChartPositionValidator']->IsDraftSportValid($draft_sport);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 

api/Controllers/Commish/IndexController.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     //Leaving this here as we also grab roles below, but LoginUserService->GetCurrentUser() will fetch user via this method too:
     $token = $app['security']->getToken();
 
-    if($token !== null) {
+    if ($token !== null) {
       $usr = $token->getUser();
 
       $isAuthenticated = true;

api/Controllers/Commish/ManagerController.php

Spacing +9 added lines, -9 removed lines

@@ -26,7 +26,7 @@ 
 
     $validity = $app['phpdraft.ManagerValidator']->IsManagerValidForCreate($draftId, $manager);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
@@ -41,7 +41,7 @@ 
     $managersJson = $request->get('managers');
     $newManagers = array();
 
-    foreach($managersJson as $managerRequest) {
+    foreach ($managersJson as $managerRequest) {
       $newManager = new Manager();
       $newManager->draft_id = $draftId;
       $newManager->manager_name = $managerRequest['manager_name'];
@@ -51,7 +51,7 @@ 
 
     $validity = $app['phpdraft.ManagerValidator']->AreManagersValidForCreate($draftId, $newManagers);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
@@ -66,13 +66,13 @@ 
     $managersIdJson = $request->get('ordered_manager_ids');
     $managerIds = array();
 
-    foreach($managersIdJson as $managerId) {
+    foreach ($managersIdJson as $managerId) {
       $managerIds[] = (int)$managerId;
     }
 
     $validity = $app['phpdraft.ManagerValidator']->AreManagerIdsValidForOrdering($draftId, $managerIds);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
@@ -88,7 +88,7 @@ 
     try {
       $draft = $app['phpdraft.DraftRepository']->Load($draftId);
       $manager = $app['phpdraft.ManagerRepository']->Load($managerId);
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response = new PhpDraftResponse(false, array());
       $response->errors[] = "Unable to load manager #$managerId";
 
@@ -99,7 +99,7 @@ 
 
     $validity = $app['phpdraft.ManagerValidator']->IsManagerValidForUpdate($draft, $manager);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 
@@ -114,14 +114,14 @@ 
 
     try {
       $manager = $app['phpdraft.ManagerRepository']->Load($managerId);
-    } catch(\Exception $e) {
+    } catch (\Exception $e) {
       $response = new PhpDraftResponse(false, array());
       $response->errors[] = "Unable to delete manager #$managerId";
 
       return $app->json($response, Response::HTTP_BAD_REQUEST);
     }
 
-    if($manager->draft_id != $draftId) {
+    if ($manager->draft_id != $draftId) {
       $response = new PhpDraftResponse(false, array());
       $response->errors[] = "Unable to delete manager #$managerId";
 

api/Controllers/Commish/UserProfileController.php

Spacing +2 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
   public function Get(Application $app, Request $request) {
     $user = $app['phpdraft.LoginUserService']->GetCurrentUser();
 
-    if(empty($user)) {
+    if (empty($user)) {
       return $app->json(new PhpDraftResponse(false));
     }
 
@@ -22,7 +22,7 @@ 
   public function Put(Application $app, Request $request) {
     $validity = $app['phpdraft.LoginUserValidator']->IsUserProfileUpdateValid($request);
 
-    if(!$validity->success) {
+    if (!$validity->success) {
       return $app->json($validity, Response::HTTP_BAD_REQUEST);
     }
 

api/Controllers/IndexController.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
     $minified_css = '';
 
-    foreach($colors as $position => $hex_color_key) {
+    foreach ($colors as $position => $hex_color_key) {
       $minified_css .= "div.pick$position{background-color:$hex_color_key;}";
     }
 

api/Controllers/DraftController.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     $draft_id = (int)$request->get('id');
     $getDraftData = $request->get('get_draft_data') == 'true';
 
-    if(empty($draft_id) || $draft_id == 0) {
+    if (empty($draft_id) || $draft_id == 0) {
       throw new \Exception("Unable to load draft.");
     }