DatabaseCacheService::_LoadCacheObject() - Code Metrics - Inspection of "Merge pull request #32 from mattheworres/v2.1-clea..." - mattheworres/phpdraft - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4f2bb7...01aead )

by Matthew

created 2017-03-31 01:29 UTC

DatabaseCacheService::_LoadCacheObject() A

↳ Parent: DatabaseCacheService

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php
namespace PhpDraft\Domain\Services;

use Silex\Application;
use Symfony\Component\HttpFoundation\Request;
use phpFastCache\CacheManager;

//A wrapper service for the PHP-based caching to save on several MySQL reads
class DatabaseCacheService {
  private $cacheInstance;

  public function __construct(Application $app) {
    $this->app = $app;
class MyClass { }

$x = new MyClass();
$x->foo = true;

    $cacheConfig = [
      'path' => CACHE_PATH
    ];

    $this->cacheInstance = CacheManager::Files($cacheConfig);

  }

  /*
  * Attempt to load a cached instance of an object.
  * @param string $itemKey The unique identifier of the object in the cache
  * @return object the cached object, or null if $itemKey was a miss in the cache
  */
  public function GetCachedItem($itemKey) {
    $cachedItem = $this->_LoadCacheObject($itemKey);

    if(!$cachedItem->isHit()) {
      return null;
    }

    return $cachedItem->get();
  }

  /*
  * Store an object in the cache for
  * @param string $itemKey The unique identifier of the object in the cache
  * @param object $item The object that is to be stored in the cache
  */
  public function SetCachedItem($itemKey, $item) {
    $cachedItem = $this->_LoadCacheObject($itemKey);

    $cachedItem->set($item)->expiresAfter(CACHE_SECONDS);
    $this->cacheInstance->save($cachedItem);
  }

  /*
  * Remove an object from the cache
  * @param string $itemKey The unique identifier of the object in the cache
  */
  public function DeleteCachedItem($itemKey) {
    $this->cacheInstance->deleteItem($itemKey);
  }

  /*
  * Load a phpFastCache cache object for a given key. Is used in both get and set events.
  * @param string $itemKey The unique identifier of the object in the cache
  * @return object the phpFastCache object for the given key
  */
  private function _LoadCacheObject($itemKey) {
    return $this->cacheInstance->getItem($itemKey);
  }
}

1			<?php
2			namespace PhpDraft\Domain\Services;
3
4			use Silex\Application;
5			use Symfony\Component\HttpFoundation\Request;
6			use phpFastCache\CacheManager;
7
8			//A wrapper service for the PHP-based caching to save on several MySQL reads
9			class DatabaseCacheService {
10			private $cacheInstance;
11
12			public function __construct(Application $app) {
13			$this->app = $app;
			0 ignored issues – show Bug introduced 2017-03-28 03:27 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14
15			$cacheConfig = [
16			'path' => CACHE_PATH
17			];
18
19			$this->cacheInstance = CacheManager::Files($cacheConfig);
			0 ignored issues – show Unused Code introduced 2017-03-28 03:27 UTC by Report Bug Copy Issue Report The call to `CacheManager::Files()` has too many arguments starting with `$cacheConfig`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
20			}
21
22			/*
23			* Attempt to load a cached instance of an object.
24			* @param string $itemKey The unique identifier of the object in the cache
25			* @return object the cached object, or null if $itemKey was a miss in the cache
26			*/
27			public function GetCachedItem($itemKey) {
28			$cachedItem = $this->_LoadCacheObject($itemKey);
29
30			if(!$cachedItem->isHit()) {
31			return null;
32			}
33
34			return $cachedItem->get();
35			}
36
37			/*
38			* Store an object in the cache for
39			* @param string $itemKey The unique identifier of the object in the cache
40			* @param object $item The object that is to be stored in the cache
41			*/
42			public function SetCachedItem($itemKey, $item) {
43			$cachedItem = $this->_LoadCacheObject($itemKey);
44
45			$cachedItem->set($item)->expiresAfter(CACHE_SECONDS);
46			$this->cacheInstance->save($cachedItem);
47			}
48
49			/*
50			* Remove an object from the cache
51			* @param string $itemKey The unique identifier of the object in the cache
52			*/
53			public function DeleteCachedItem($itemKey) {
54			$this->cacheInstance->deleteItem($itemKey);
55			}
56
57			/*
58			* Load a phpFastCache cache object for a given key. Is used in both get and set events.
59			* @param string $itemKey The unique identifier of the object in the cache
60			* @return object the phpFastCache object for the given key
61			*/
62			private function _LoadCacheObject($itemKey) {
63			return $this->cacheInstance->getItem($itemKey);
64			}
65			}

mattheworres / phpdraft

Push — master ( 4f2bb7...01aead )

DatabaseCacheService::_LoadCacheObject() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like