PhpDraft\Test\ProPlayerValidatorTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	56
Duplicated Lines	46.43 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	8	1
A	testEnsuresSportIsNotEmpty()	13	13	1
A	testDraftIdAndSecondsArePresent()	0	17	1
A	testValidateSportValues()	13	13	1

<?php
namespace PhpDraft\Test;

use PHPUnit\Framework\TestCase;
use PhpDraft\Domain\Validators\ProPlayerValidator;
use PhpDraft\Domain\Repositories\DraftDataRepository;

class ProPlayerValidatorTest extends TestCase {
  function setUp() {

It is generally recommended to explicitly declare the visibility for methods.

    $this->app = require dirname(__FILE__).'/../../../../api/config/_app.php';

The property app does not exist. Did you maybe forget to declare it?

    $draftDataRepository = new DraftDataRepository($this->app);
    $this->sut = new ProPlayerValidator($this->app);

The property sut does not exist. Did you maybe forget to declare it?

    $this->app['phpdraft.DraftDataRepository'] = $draftDataRepository;

    $this->uploadedFileClass = 'Symfony\Component\HttpFoundation\File\UploadedFile';

The property uploadedFileClass does not exist. Did you maybe forget to declare it?

  }

  public function testEnsuresSportIsNotEmpty() {

This method seems to be duplicated in your project.

    $mockFile = $this->getMockBuilder($this->uploadedFileClass)
                    ->enableOriginalConstructor()
                    ->setConstructorArgs([tempnam(sys_get_temp_dir(), ''), 'dummy'])
                    ->getMock();

    $sport = "";

    $result = $this->sut->IsUploadSportValid($sport, $mockFile);

    $this->assertFalse($result->success);
    $this->assertContains("One or more missing fields.", $result->errors);
  }

  public function testDraftIdAndSecondsArePresent() {
    $mockFile = $this->getMockBuilder($this->uploadedFileClass)
                    ->enableOriginalConstructor()
                    ->setConstructorArgs([tempnam(sys_get_temp_dir(), ''), 'dummy'])
                    ->getMock();

    $mockFile->expects($this->once())
        ->method('getError')
        ->will($this->returnValue(1));

    $sport = "NFL";

    $result = $this->sut->IsUploadSportValid($sport, $mockFile);

    $this->assertFalse($result->success);
    $this->assertContains("Upload error - 1", $result->errors);
  }

  public function testValidateSportValues() {

This method seems to be duplicated in your project.

    $mockFile = $this->getMockBuilder($this->uploadedFileClass)
                    ->enableOriginalConstructor()
                    ->setConstructorArgs([tempnam(sys_get_temp_dir(), ''), 'dummy'])
                    ->getMock();

    $sport = "QVC";

    $result = $this->sut->IsUploadSportValid($sport, $mockFile);

    $this->assertFalse($result->success);
    $this->assertContains("Sport QVC is an invalid value.", $result->errors);
  }
}