PhpDraft\Domain\Models\PickSearchModel

Complexity

Total Complexity

9

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	hasName()	0	2	2
A	searchCount()	0	2	1
A	emptyResultsData()	0	3	1
A	hasPosition()	0	2	2
A	hasTeam()	0	2	2
A	__construct()	0	6	1

<?php

namespace PhpDraft\Domain\Models;

class PickSearchModel {
  /** @var string */
  public $draft_id;

  /** @var string */
  public $keywords;

  /** @var string Three-char abbreviation */
  public $team;

  /** @var string Three-char abbreviation */
  public $position;

  /** @var string Sorting by player pick, ASC or DESC */
  public $sort;

  /** @var array */
  public $player_results;

  public function __construct($draft_id, $keywords, $team, $position, $sort) {
    $this->draft_id = $draft_id;
    $this->keywords = $keywords;
    $this->team = $team;
    $this->position = $position;
    $this->sort = $sort;
  }

  /**
   * Used if the strict search returns no results, empty the results (for any reason) and set the count to zero.
   */
  public function emptyResultsData() {
    unset($this->player_results);
    $this->search_count = 0;

The property search_count does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

  }

  public function hasName() {
    return isset($this->keywords) && strlen($this->keywords) > 0;
  }

  public function hasTeam() {
    return isset($this->team) && strlen($this->team) > 0;
  }

  public function hasPosition() {
    return isset($this->position) && strlen($this->position) > 0;
  }

  public function searchCount() {
    return count($player_results);

The variable $player_results seems to be never defined.

  }
}