Issues in LsTreeCommand.php (master) - Issues in master - matteosister/GitElephant - Measure and Improve Code Quality continuously with Scrutinizer

Issues (106)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/GitElephant/Command/LsTreeCommand.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * GitElephant - An abstraction layer for git written in PHP
 * Copyright (C) 2013  Matteo Giachino
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see [http://www.gnu.org/licenses/].
 */

namespace GitElephant\Command;

use GitElephant\Objects\Branch;
use GitElephant\Objects\NodeObject;
use GitElephant\Objects\TreeishInterface;
use GitElephant\Repository;

/**
 * ls-tree command generator
 *
 * @author Matteo Giachino <[email protected]>
 */
class LsTreeCommand extends BaseCommand
{
    public const LS_TREE_COMMAND = 'ls-tree';

    /**
     * constructor
     *
     * @param \GitElephant\Repository $repo The repository object this command
     *                                      will interact with
     */
    public function __construct(Repository $repo = null)
    {
        parent::__construct($repo);
    }

    /**
     * build a ls-tree command
     *
     * @param string|Branch $ref The reference to build the tree from
     *
     * @throws \RuntimeException
     * @return string
     */
    public function fullTree($ref = 'HEAD'): string
    {
        $what = $ref;
        if ($ref instanceof TreeishInterface) {
            $what = $ref->getSha();
        }
        $this->clearAll();
        $this->addCommandName(self::LS_TREE_COMMAND);
        // recurse
        $this->addCommandArgument('-r');
        // show trees
        $this->addCommandArgument('-t');
        $this->addCommandArgument('-l');
        $this->addCommandSubject($what);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return $this->getCommand();
    }

    /**
     * tree of a given path
     *
     * @param string|TreeishInterface        $ref  reference
     * @param string|NodeObject $path path
     *
     * @throws \RuntimeException
     * @return string
     */
    public function tree($ref = 'HEAD', $path = null): string
    {
        if ($path instanceof NodeObject) {
            $subjectPath = $path->getFullPath() . ($path->isTree() ? '/' : '');
        } else {
            $subjectPath = $path;
        }

        $what = $ref;
        if ($ref instanceof TreeishInterface) {
            $what = $ref->getSha();
        }
        $subject = $what;

        $this->clearAll();

        $this->addCommandName(self::LS_TREE_COMMAND);
        $this->addCommandArgument('-l');
        $this->addCommandSubject($subject);
        $this->addPath($subjectPath);

        return $this->getCommand();
    }

    /**
     * build ls-tree command that list all
     *
     * @param null|string $ref the reference to build the tree from
     *
     * @throws \RuntimeException
     * @return string
     */
    public function listAll($ref = null): string
    {
        if (is_null($ref)) {
            $ref = 'HEAD';
        }
        $this->clearAll();
        $this->addCommandName(self::LS_TREE_COMMAND);
        $this->addCommandSubject($ref);

        return $this->getCommand();
    }
}


1		<?php
2
3		/**
4		* GitElephant - An abstraction layer for git written in PHP
5		* Copyright (C) 2013 Matteo Giachino
6		*
7		* This program is free software: you can redistribute it and/or modify
8		* it under the terms of the GNU General Public License as published by
9		* the Free Software Foundation, either version 3 of the License, or
10		* (at your option) any later version.
11		*
12		* This program is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		* GNU General Public License for more details.
16		*
17		* You should have received a copy of the GNU General Public License
18		* along with this program. If not, see [http://www.gnu.org/licenses/].
19		*/
20
21		namespace GitElephant\Command;
22
23		use GitElephant\Objects\Branch;
24		use GitElephant\Objects\NodeObject;
25		use GitElephant\Objects\TreeishInterface;
26		use GitElephant\Repository;
27
28		/**
29		* ls-tree command generator
30		*
31		* @author Matteo Giachino <[email protected]>
32		*/
33		class LsTreeCommand extends BaseCommand
34		{
35		public const LS_TREE_COMMAND = 'ls-tree';
36
37		/**
38		* constructor
39		*
40		* @param \GitElephant\Repository $repo The repository object this command
41		* will interact with
42		*/
43	15	public function __construct(Repository $repo = null)
44		{
45	15	parent::__construct($repo);
46	15	}
47
48		/**
49		* build a ls-tree command
50		*
51		* @param string\|Branch $ref The reference to build the tree from
52		*
53		* @throws \RuntimeException
54		* @return string
55		*/
56	1	public function fullTree($ref = 'HEAD'): string
57		{
58	1	$what = $ref;
59	1	if ($ref instanceof TreeishInterface) {
60	1	$what = $ref->getSha();
61		}
62	1	$this->clearAll();
63	1	$this->addCommandName(self::LS_TREE_COMMAND);
64		// recurse
65	1	$this->addCommandArgument('-r');
66		// show trees
67	1	$this->addCommandArgument('-t');
68	1	$this->addCommandArgument('-l');
69	1	$this->addCommandSubject($what);
		0 ignored issues – show Bug introduced 2018-02-26 19:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$what` defined by `$ref` on line `58` can also be of type `object<GitElephant\Objects\Branch>`; however, `GitElephant\Command\Base...nd::addCommandSubject()` does only seem to accept `object<GitElephant\Comma...ndCommand>\|array\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
70
71	1	return $this->getCommand();
72		}
73
74		/**
75		* tree of a given path
76		*
77		* @param string\|TreeishInterface $ref reference
78		* @param string\|NodeObject $path path
79		*
80		* @throws \RuntimeException
81		* @return string
82		*/
83	15	public function tree($ref = 'HEAD', $path = null): string
84		{
85	15	if ($path instanceof NodeObject) {
86	9	$subjectPath = $path->getFullPath() . ($path->isTree() ? '/' : '');
87		} else {
88	15	$subjectPath = $path;
89		}
90
91	15	$what = $ref;
92	15	if ($ref instanceof TreeishInterface) {
93	1	$what = $ref->getSha();
94		}
95	15	$subject = $what;
96
97	15	$this->clearAll();
98
99	15	$this->addCommandName(self::LS_TREE_COMMAND);
100	15	$this->addCommandArgument('-l');
101	15	$this->addCommandSubject($subject);
102	15	$this->addPath($subjectPath);
103
104	15	return $this->getCommand();
105		}
106
107		/**
108		* build ls-tree command that list all
109		*
110		* @param null\|string $ref the reference to build the tree from
111		*
112		* @throws \RuntimeException
113		* @return string
114		*/
115	1	public function listAll($ref = null): string
116		{
117	1	if (is_null($ref)) {
118	1	$ref = 'HEAD';
119		}
120	1	$this->clearAll();
121	1	$this->addCommandName(self::LS_TREE_COMMAND);
122	1	$this->addCommandSubject($ref);
123
124	1	return $this->getCommand();
125		}
126		}
127

matteosister / GitElephant

Issues (106)

Security Analysis no request data

src/GitElephant/Command/LsTreeCommand.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like