GitElephant\Status\StatusWorkingTree

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

85.71%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	all()	0	11	1
A	filterByType()	0	15	2

<?php

/**
 * GitElephant - An abstraction layer for git written in PHP
 * Copyright (C) 2013  Matteo Giachino
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see [http://www.gnu.org/licenses/].
 */

namespace GitElephant\Status;

use PhpCollection\Sequence;

/**
 * Class StatusWorkingTree
 *
 * @package GitElephant\Status
 */
class StatusWorkingTree extends Status
{
    /**
     * all files with modified status in the working tree
     *
     * @return Sequence
     */
    public function all(): \PhpCollection\Sequence
    {
        return new Sequence(
            array_filter(
                $this->files,
                function (StatusFile $statusFile) {
                    return $statusFile->getWorkingTreeStatus();
                }
            )
        );
    }

    /**
     * filter files by working tree status
     *
     * @param string $type
     *
     * @return Sequence
     */
    protected function filterByType(string $type): \PhpCollection\Sequence
    {
        if (!$this->files) {

The expression $this->files of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return new Sequence();
        }

        return new Sequence(
            array_filter(
                $this->files,
                function (StatusFile $statusFile) use ($type) {
                    return $type === $statusFile->getWorkingTreeStatus();
                }
            )
        );
    }
}