ResetCommand::reset() - Code Metrics - Inspection of "- merging develop branch into master" - matteosister/GitElephant - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

unknown

created 2018-04-30 12:39 UTC

ResetCommand::reset() A

↳ Parent: ResetCommand

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	9
cts	9
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	4
nop	2
crap	4

<?php
/**
 * Created by PhpStorm.
 * User: christian
 * Date: 3/2/16
 * Time: 11:29 AM
 */

namespace GitElephant\Command;


use GitElephant\Objects\Commit;
use GitElephant\Objects\TreeishInterface;
use \GitElephant\Repository;

class ResetCommand extends BaseCommand
{
    const GIT_RESET_COMMAND = 'reset';

    const OPTION_HARD  = '--hard';
    const OPTION_MERGE = '--merge';
    const OPTION_SOFT  = '--soft';

    /**
     * constructor
     *
     * @param \GitElephant\Repository $repo The repository object this command
     *                                      will interact with
     */
    public function __construct(Repository $repo = null)
    {
        parent::__construct($repo);
    }

    /**
     * @param TreeishInterface|Commit|string $arg
     * @param array $options
     *
     * @throws \RuntimeException
     * @return string
     */
    public function reset($arg = null, array $options = array())
    {
        $this->clearAll();
        $this->addCommandName(self::GIT_RESET_COMMAND);
        // if there are options add them.
        if (! is_null($options)) {
            foreach ($options as $option) {
                $this->addCommandArgument($option);
            }
        }
        if($arg!=null){

            $this->addCommandSubject2($arg);

        }

        return $this->getCommand();
    }

    /**
     * @param Repository $repository
     * @return ResetCommand
     */
    public static function getInstance(Repository $repository=null)

    {
        return new self($repository);
    }



}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: christian
5		* Date: 3/2/16
6		* Time: 11:29 AM
7		*/
8
9		namespace GitElephant\Command;
10
11
12		use GitElephant\Objects\Commit;
13		use GitElephant\Objects\TreeishInterface;
14		use \GitElephant\Repository;
15
16		class ResetCommand extends BaseCommand
17		{
18		const GIT_RESET_COMMAND = 'reset';
19
20		const OPTION_HARD = '--hard';
21		const OPTION_MERGE = '--merge';
22		const OPTION_SOFT = '--soft';
23
24		/**
25		* constructor
26		*
27		* @param \GitElephant\Repository $repo The repository object this command
28		* will interact with
29		*/
30	3	public function __construct(Repository $repo = null)
31		{
32	3	parent::__construct($repo);
33	3	}
34
35		/**
36		* @param TreeishInterface\|Commit\|string $arg
37		* @param array $options
38		*
39		* @throws \RuntimeException
40		* @return string
41		*/
42	3	public function reset($arg = null, array $options = array())
43		{
44	3	$this->clearAll();
45	3	$this->addCommandName(self::GIT_RESET_COMMAND);
46		// if there are options add them.
47	3	if (! is_null($options)) {
48	3	foreach ($options as $option) {
49	3	$this->addCommandArgument($option);
50		}
51		}
52	3	if($arg!=null){
		0 ignored issues – show Bug introduced 2016-03-02 13:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$arg` of type `GitElephant\Objects\TreeishInterface\|string\|null` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `!==` instead. Loading history... Coding Style introduced 2016-03-02 13:00 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
53	3	$this->addCommandSubject2($arg);
		0 ignored issues – show Bug introduced 2016-03-02 13:00 UTC by Report Bug Copy Issue Report It seems like `$arg` defined by parameter `$arg` on line 42 can also be of type `object<GitElephant\Objects\TreeishInterface>`; however, `GitElephant\Command\Base...d::addCommandSubject2()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
54		}
55
56	3	return $this->getCommand();
57		}
58
59		/**
60		* @param Repository $repository
61		* @return ResetCommand
62		*/
63	3	public static function getInstance(Repository $repository=null)
		0 ignored issues – show Coding Style introduced 2016-03-02 13:58 UTC by Report Bug Copy Issue Report Incorrect spacing between argument "$repository" and equals sign; expected 1 but found 0 Loading history... Coding Style introduced 2016-03-02 13:58 UTC by Report Bug Copy Issue Report Incorrect spacing between default value and equals sign for argument "$repository"; expected 1 but found 0 Loading history...
64		{
65	3	return new self($repository);
66		}
67
68
69
70		}
71

matteosister / GitElephant

Pull Request — master (#139)

ResetCommand::reset() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like