Complex classes like Tree often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Tree, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
34 | class Tree extends NodeObject implements \ArrayAccess, \Countable, \Iterator |
||
35 | { |
||
36 | /** |
||
37 | * @var string |
||
38 | */ |
||
39 | private $ref; |
||
40 | |||
41 | /** |
||
42 | * the cursor position |
||
43 | * |
||
44 | * @var int |
||
45 | */ |
||
46 | private $position; |
||
47 | |||
48 | /** |
||
49 | * the tree subject |
||
50 | * |
||
51 | * @var NodeObject |
||
52 | */ |
||
53 | private $subject; |
||
54 | |||
55 | /** |
||
56 | * tree children |
||
57 | * |
||
58 | * @var array |
||
59 | */ |
||
60 | private $children = []; |
||
61 | |||
62 | /** |
||
63 | * tree path children |
||
64 | * |
||
65 | * @var array |
||
66 | */ |
||
67 | private $pathChildren = []; |
||
68 | |||
69 | /** |
||
70 | * the blob of the actual tree |
||
71 | * |
||
72 | * @var \GitElephant\Objects\NodeObject |
||
73 | */ |
||
74 | private $blob; |
||
75 | |||
76 | /** |
||
77 | * static method to generate standalone log |
||
78 | * |
||
79 | * @param \GitElephant\Repository $repository repo |
||
80 | * @param array $outputLines output lines from command.log |
||
81 | * |
||
82 | * @return \GitElephant\Objects\Tree |
||
83 | */ |
||
84 | public static function createFromOutputLines(Repository $repository, array $outputLines) |
||
91 | |||
92 | /** |
||
93 | * get the commit properties from command |
||
94 | * |
||
95 | * @see LsTreeCommand::tree |
||
96 | */ |
||
97 | 15 | private function createFromCommand() |
|
103 | |||
104 | /** |
||
105 | * Some path examples: |
||
106 | * empty string for root |
||
107 | * folder1/folder2 |
||
108 | * folder1/folder2/filename |
||
109 | * |
||
110 | * @param \GitElephant\Repository $repository the repository |
||
111 | * @param string $ref a treeish reference |
||
112 | * @param NodeObject $subject the subject |
||
113 | * |
||
114 | * @throws \RuntimeException |
||
115 | * @throws \Symfony\Component\Process\Exception\RuntimeException |
||
116 | * @internal param \GitElephant\Objects\Object|string $treeObject Object instance |
||
117 | */ |
||
118 | 15 | public function __construct(Repository $repository, $ref = 'HEAD', NodeObject $subject = null) |
|
126 | |||
127 | /** |
||
128 | * parse the output of a git command showing a ls-tree |
||
129 | * |
||
130 | * @param array $outputLines output lines |
||
131 | */ |
||
132 | 15 | private function parseOutputLines(array $outputLines) |
|
133 | { |
||
134 | 15 | foreach ($outputLines as $line) { |
|
135 | 15 | $this->parseLine($line); |
|
136 | } |
||
137 | 15 | usort($this->children, [$this, 'sortChildren']); |
|
138 | 15 | $this->scanPathsForBlob($outputLines); |
|
139 | 15 | } |
|
140 | |||
141 | /** |
||
142 | * @return \GitElephant\Command\Caller\Caller |
||
143 | */ |
||
144 | 15 | private function getCaller() |
|
148 | |||
149 | /** |
||
150 | * get the current tree parent, null if root |
||
151 | * |
||
152 | * @return null|string |
||
153 | */ |
||
154 | public function getParent() |
||
162 | |||
163 | /** |
||
164 | * tell if the tree created is the root of the repository |
||
165 | * |
||
166 | * @return bool |
||
167 | */ |
||
168 | 15 | public function isRoot() |
|
172 | |||
173 | /** |
||
174 | * tell if the path given is a blob path |
||
175 | * |
||
176 | * @return bool |
||
177 | */ |
||
178 | 15 | public function isBlob() |
|
182 | |||
183 | /** |
||
184 | * the current tree path is a binary file |
||
185 | * |
||
186 | * @return bool |
||
187 | */ |
||
188 | public function isBinary() |
||
192 | |||
193 | /** |
||
194 | * get binary data |
||
195 | * |
||
196 | * @throws \RuntimeException |
||
197 | * @throws \Symfony\Component\Process\Exception\LogicException |
||
198 | * @throws \Symfony\Component\Process\Exception\InvalidArgumentException |
||
199 | * @throws \Symfony\Component\Process\Exception\RuntimeException |
||
200 | * @return string |
||
201 | */ |
||
202 | public function getBinaryData() |
||
208 | |||
209 | /** |
||
210 | * Return an array like this |
||
211 | * 0 => array( |
||
212 | * 'path' => the path to the current element |
||
213 | * 'label' => the name of the current element |
||
214 | * ), |
||
215 | * 1 => array(), |
||
216 | * ... |
||
217 | * |
||
218 | * @return array |
||
219 | */ |
||
220 | public function getBreadcrumb() |
||
242 | |||
243 | /** |
||
244 | * check if the path is equals to a fullPath |
||
245 | * to tell if it's a blob |
||
246 | * |
||
247 | * @param array $outputLines output lines |
||
248 | * |
||
249 | * @return mixed |
||
250 | */ |
||
251 | 15 | private function scanPathsForBlob(array $outputLines) |
|
270 | |||
271 | /** |
||
272 | * Reorder children of the tree |
||
273 | * Tree first (alphabetically) and then blobs (alphabetically) |
||
274 | * |
||
275 | * @param \GitElephant\Objects\NodeObject $a the first object |
||
276 | * @param \GitElephant\Objects\NodeObject $b the second object |
||
277 | * |
||
278 | * @return int |
||
279 | */ |
||
280 | 7 | private function sortChildren(NodeObject $a, NodeObject $b) |
|
291 | |||
292 | /** |
||
293 | * Parse a single line into pieces |
||
294 | * |
||
295 | * @param string $line a single line output from the git binary |
||
296 | * |
||
297 | * @return mixed |
||
298 | */ |
||
299 | 15 | private function parseLine($line) |
|
346 | |||
347 | /** |
||
348 | * get the last commit message for this tree |
||
349 | * |
||
350 | * @param string $ref |
||
351 | * |
||
352 | * @throws \RuntimeException |
||
353 | * @return Commit\Message |
||
354 | */ |
||
355 | public function getLastCommitMessage($ref = 'master') |
||
359 | |||
360 | /** |
||
361 | * get author of the last commit |
||
362 | * |
||
363 | * @param string $ref |
||
364 | * |
||
365 | * @throws \RuntimeException |
||
366 | * @return Author |
||
367 | */ |
||
368 | public function getLastCommitAuthor($ref = 'master') |
||
372 | |||
373 | /** |
||
374 | * get the last commit for a given treeish, for the actual tree |
||
375 | * |
||
376 | * @param string $ref |
||
377 | * |
||
378 | * @throws \RuntimeException |
||
379 | * @throws \Symfony\Component\Process\Exception\RuntimeException |
||
380 | * @return Commit |
||
381 | */ |
||
382 | public function getLastCommit($ref = 'master') |
||
391 | |||
392 | /** |
||
393 | * get the tree object for this tree |
||
394 | * |
||
395 | * @return \GitElephant\Objects\NodeObject |
||
396 | */ |
||
397 | 1 | public function getObject() |
|
401 | |||
402 | /** |
||
403 | * Blob getter |
||
404 | * |
||
405 | * @return \GitElephant\Objects\NodeObject |
||
406 | */ |
||
407 | 5 | public function getBlob() |
|
411 | |||
412 | /** |
||
413 | * Get Subject |
||
414 | * |
||
415 | * @return \GitElephant\Objects\NodeObject |
||
416 | */ |
||
417 | 1 | public function getSubject() |
|
421 | |||
422 | /** |
||
423 | * Get Ref |
||
424 | * |
||
425 | * @return string |
||
426 | */ |
||
427 | public function getRef() |
||
431 | |||
432 | /** |
||
433 | * ArrayAccess interface |
||
434 | * |
||
435 | * @param int $offset offset |
||
436 | * |
||
437 | * @return bool |
||
438 | */ |
||
439 | public function offsetExists($offset) |
||
443 | |||
444 | |||
445 | /** |
||
446 | * ArrayAccess interface |
||
447 | * |
||
448 | * @param int $offset offset |
||
449 | * |
||
450 | * @return null |
||
451 | */ |
||
452 | 8 | public function offsetGet($offset) |
|
456 | |||
457 | /** |
||
458 | * ArrayAccess interface |
||
459 | * |
||
460 | * @param int $offset offset |
||
461 | * @param mixed $value value |
||
462 | */ |
||
463 | public function offsetSet($offset, $value) |
||
472 | |||
473 | /** |
||
474 | * ArrayAccess interface |
||
475 | * |
||
476 | * @param int $offset offset |
||
477 | */ |
||
478 | public function offsetUnset($offset) |
||
482 | |||
483 | /** |
||
484 | * Countable interface |
||
485 | * |
||
486 | * @return int |
||
487 | */ |
||
488 | 4 | public function count() |
|
492 | |||
493 | /** |
||
494 | * Iterator interface |
||
495 | * |
||
496 | * @return mixed |
||
497 | */ |
||
498 | 1 | public function current() |
|
502 | |||
503 | /** |
||
504 | * Iterator interface |
||
505 | */ |
||
506 | 1 | public function next() |
|
510 | |||
511 | /** |
||
512 | * Iterator interface |
||
513 | * |
||
514 | * @return int |
||
515 | */ |
||
516 | public function key() |
||
520 | |||
521 | /** |
||
522 | * Iterator interface |
||
523 | * |
||
524 | * @return bool |
||
525 | */ |
||
526 | 1 | public function valid() |
|
530 | |||
531 | /** |
||
532 | * Iterator interface |
||
533 | */ |
||
534 | 1 | public function rewind() |
|
538 | } |
||
539 |