GitElephant\GitBinary

Complexity

Total Complexity

6

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	getPath()	0	4	1
A	setPath()	0	4	1
A	getVersion()	0	10	2

<?php
/**
 * GitElephant - An abstraction layer for git written in PHP
 * Copyright (C) 2013  Matteo Giachino
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see [http://www.gnu.org/licenses/].
 */

namespace GitElephant;

/**
 * Git binary
 * It contains the reference to the system git binary
 *
 * @author Matteo Giachino <matteog@gmail.com>
 */
class GitBinary
{
    /**
     * the path to the repository
     *
     * @var string $path
     */
    private $path;

    /**
     * @var float
     */
    private $version;

    /**
     * Class constructor
     *
     * @param null $path the physical path to the git binary
     */
    public function __construct(string $path = null)
    {
        if (is_null($path)) {
            // unix only!
            $path = exec('which git');
        }
        $this->setPath($path);
    }

    /**
     * path getter
     * returns the path of the binary
     *
     * @return mixed
     */
    public function getPath()
    {
        return $this->path;
    }

    /**
     * path setter
     *
     * @param string $path the path to the system git binary
     */
    public function setPath(string $path)
    {
        $this->path = $path;
    }

    /**
     * @return float|string
     */
    public function getVersion()
    {
        if (is_null($this->version)) {

Blank line found at start of control structure

            // unix only!
            $this->version = exec('git --version | cut -d " " -f 3');

The property $version was declared of type double, but exec('git --version | cut -d " " -f 3') is of type string. Maybe add a type cast?

        }

        return $this->version;
    }
}