Complex classes like BaseCommand often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BaseCommand, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 32 | class BaseCommand |
||
| 33 | { |
||
| 34 | /** |
||
| 35 | * the command name |
||
| 36 | * |
||
| 37 | * @var string |
||
| 38 | */ |
||
| 39 | private $commandName = null; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * config options |
||
| 43 | * |
||
| 44 | * @var array |
||
| 45 | */ |
||
| 46 | private $configs = array(); |
||
| 47 | |||
| 48 | /** |
||
| 49 | * global configs |
||
| 50 | * |
||
| 51 | * @var array |
||
| 52 | */ |
||
| 53 | private $globalConfigs = array(); |
||
| 54 | |||
| 55 | /** |
||
| 56 | * global options |
||
| 57 | * |
||
| 58 | * @var array |
||
| 59 | */ |
||
| 60 | private $globalOptions = array(); |
||
| 61 | |||
| 62 | /** |
||
| 63 | * the command arguments |
||
| 64 | * |
||
| 65 | * @var array |
||
| 66 | */ |
||
| 67 | private $commandArguments = array(); |
||
| 68 | |||
| 69 | /** |
||
| 70 | * the global command arguments |
||
| 71 | * |
||
| 72 | * @var array |
||
| 73 | */ |
||
| 74 | private $globalCommandArguments = array(); |
||
| 75 | |||
| 76 | /** |
||
| 77 | * the command subject |
||
| 78 | * |
||
| 79 | * @var string|SubCommandCommand |
||
| 80 | */ |
||
| 81 | private $commandSubject = null; |
||
| 82 | |||
| 83 | /** |
||
| 84 | * the command second subject (i.e. for branch) |
||
| 85 | * |
||
| 86 | * @var string|SubCommandCommand |
||
| 87 | */ |
||
| 88 | private $commandSubject2 = null; |
||
| 89 | |||
| 90 | /** |
||
| 91 | * the path |
||
| 92 | * |
||
| 93 | * @var string |
||
| 94 | */ |
||
| 95 | private $path = null; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * constructor |
||
| 99 | * |
||
| 100 | * should be called by all child classes' constructors to permit use of |
||
| 101 | * global configs, options and command arguments |
||
| 102 | * |
||
| 103 | * @param null|\GitElephant\Repository $repo The repo object to read |
||
| 104 | */ |
||
| 105 | 118 | public function __construct(Repository $repo = null) |
|
| 119 | |||
| 120 | /** |
||
| 121 | * Clear all previous variables |
||
| 122 | */ |
||
| 123 | 104 | public function clearAll() |
|
| 124 | { |
||
| 125 | 104 | $this->commandName = null; |
|
| 126 | 104 | $this->configs = array(); |
|
| 127 | 104 | $this->commandArguments = array(); |
|
| 128 | 104 | $this->commandSubject = null; |
|
| 129 | 104 | $this->commandSubject2 = null; |
|
| 130 | 104 | $this->path = null; |
|
| 131 | 104 | } |
|
| 132 | |||
| 133 | 108 | public static function getInstance(Repository $repo = null) |
|
| 137 | |||
| 138 | /** |
||
| 139 | * Add the command name |
||
| 140 | * |
||
| 141 | * @param string $commandName the command name |
||
| 142 | */ |
||
| 143 | 105 | protected function addCommandName($commandName) |
|
| 147 | |||
| 148 | /** |
||
| 149 | * Get command name |
||
| 150 | * |
||
| 151 | * @return string |
||
| 152 | */ |
||
| 153 | 11 | protected function getCommandName() |
|
| 157 | |||
| 158 | /** |
||
| 159 | * Set Configs |
||
| 160 | * |
||
| 161 | * @param array|Map $configs the config variable. i.e. { "color.status" => "false", "color.diff" => "true" } |
||
| 162 | */ |
||
| 163 | 3 | public function addConfigs($configs) |
|
| 164 | { |
||
| 165 | 3 | foreach ($configs as $config => $value) { |
|
| 166 | 3 | $this->configs[$config] = $value; |
|
| 167 | 3 | } |
|
| 168 | 3 | } |
|
| 169 | |||
| 170 | /** |
||
| 171 | * Set global configs |
||
| 172 | * |
||
| 173 | * @param array|Map $configs the config variable. i.e. { "color.status" => "false", "color.diff" => "true" } |
||
| 174 | */ |
||
| 175 | 95 | protected function addGlobalConfigs($configs) |
|
| 176 | { |
||
| 177 | 95 | if (!empty($configs)) { |
|
| 178 | 1 | foreach ($configs as $config => $value) { |
|
| 179 | 1 | $this->globalConfigs[$config] = $value; |
|
| 180 | 1 | } |
|
| 181 | 1 | } |
|
| 182 | 95 | } |
|
| 183 | |||
| 184 | /** |
||
| 185 | * Set global option |
||
| 186 | * |
||
| 187 | * @param array|Map $options a global option |
||
| 188 | */ |
||
| 189 | 95 | protected function addGlobalOptions($options) |
|
| 190 | { |
||
| 191 | 95 | if (!empty($options)) { |
|
| 192 | 1 | foreach ($options as $name => $value) { |
|
| 193 | 1 | $this->globalOptions[$name] = $value; |
|
| 194 | 1 | } |
|
| 195 | 1 | } |
|
| 196 | 95 | } |
|
| 197 | |||
| 198 | /** |
||
| 199 | * Get Configs |
||
| 200 | * |
||
| 201 | * @return array |
||
| 202 | */ |
||
| 203 | public function getConfigs() |
||
| 207 | |||
| 208 | /** |
||
| 209 | * Add a command argument |
||
| 210 | * |
||
| 211 | * @param string $commandArgument the command argument |
||
| 212 | */ |
||
| 213 | 101 | protected function addCommandArgument($commandArgument) |
|
| 217 | |||
| 218 | /** |
||
| 219 | * Add a global command argument |
||
| 220 | * |
||
| 221 | * @param string $commandArgument the command argument |
||
| 222 | */ |
||
| 223 | 1 | protected function addGlobalCommandArgument($commandArgument) |
|
| 224 | { |
||
| 225 | 1 | if (!empty($commandArgument)) { |
|
| 226 | 1 | $this->globalCommandArguments[] = $commandArgument; |
|
| 227 | 1 | } |
|
| 228 | 1 | } |
|
| 229 | |||
| 230 | /** |
||
| 231 | * Get all added command arguments |
||
| 232 | * |
||
| 233 | * @return array |
||
| 234 | */ |
||
| 235 | 11 | protected function getCommandArguments() |
|
| 239 | |||
| 240 | /** |
||
| 241 | * Add a command subject |
||
| 242 | * |
||
| 243 | * @param string $commandSubject the command subject |
||
| 244 | */ |
||
| 245 | 96 | protected function addCommandSubject($commandSubject) |
|
| 249 | |||
| 250 | /** |
||
| 251 | * Add a second command subject |
||
| 252 | * |
||
| 253 | * @param string $commandSubject2 the second command subject |
||
| 254 | */ |
||
| 255 | 21 | protected function addCommandSubject2($commandSubject2) |
|
| 259 | |||
| 260 | /** |
||
| 261 | * Add a path to the git command |
||
| 262 | * |
||
| 263 | * @param string $path path |
||
| 264 | */ |
||
| 265 | 19 | protected function addPath($path) |
|
| 269 | |||
| 270 | /** |
||
| 271 | * Normalize any valid option to its long name |
||
| 272 | * an provide a structure that can be more intelligently |
||
| 273 | * handled by other routines |
||
| 274 | * |
||
| 275 | * @param array $options command options |
||
| 276 | * @param array $switchOptions list of valid options that are switch like |
||
| 277 | * @param array $valueOptions list of valid options that must have a value assignment |
||
| 278 | * |
||
| 279 | * @return array Associative array of valid, normalized command options |
||
| 280 | */ |
||
| 281 | 15 | public function normalizeOptions(Array $options = array(), Array $switchOptions = array(), $valueOptions = array()) |
|
|
|
|||
| 282 | { |
||
| 283 | 15 | $normalizedOptions = array(); |
|
| 284 | |||
| 285 | 15 | foreach ($options as $option) { |
|
| 286 | 7 | if (array_key_exists($option, $switchOptions)) { |
|
| 287 | 7 | $normalizedOptions[$switchOptions[$option]] = $switchOptions[$option]; |
|
| 288 | 7 | } else { |
|
| 289 | 1 | $parts = preg_split('/([\s=])+/', $option, 2, PREG_SPLIT_DELIM_CAPTURE); |
|
| 290 | 1 | if (count($parts)) { |
|
| 291 | 1 | $optionName = $parts[0]; |
|
| 292 | 1 | if (in_array($optionName, $valueOptions)) { |
|
| 293 | 1 | $value = ($parts[1] == '=') ? $option : array($parts[0], $parts[2]); |
|
| 294 | 1 | $normalizedOptions[$optionName] = $value; |
|
| 295 | 1 | } |
|
| 296 | 1 | } |
|
| 297 | } |
||
| 298 | 15 | } |
|
| 299 | |||
| 300 | 15 | return $normalizedOptions; |
|
| 301 | } |
||
| 302 | |||
| 303 | /** |
||
| 304 | * Get the current command |
||
| 305 | * |
||
| 306 | * @return string |
||
| 307 | * @throws \RuntimeException |
||
| 308 | */ |
||
| 309 | 106 | public function getCommand() |
|
| 310 | { |
||
| 311 | 106 | if (is_null($this->commandName)) { |
|
| 312 | 1 | throw new \RuntimeException("You should pass a commandName to execute a command"); |
|
| 313 | } |
||
| 314 | |||
| 315 | 105 | $command = ''; |
|
| 316 | 105 | $command .= $this->getCLIConfigs(); |
|
| 317 | 105 | $command .= $this->getCLIGlobalOptions(); |
|
| 318 | 105 | $command .= $this->getCLICommandName(); |
|
| 319 | 105 | $command .= $this->getCLICommandArguments(); |
|
| 320 | 105 | $command .= $this->getCLISubjects(); |
|
| 321 | 105 | $command .= $this->getCLIPath(); |
|
| 322 | |||
| 323 | 105 | $command = preg_replace('/\\s{2,}/', ' ', $command); |
|
| 324 | |||
| 325 | 105 | return trim($command); |
|
| 326 | } |
||
| 327 | |||
| 328 | /** |
||
| 329 | * get a string of CLI-formatted command arguments |
||
| 330 | * |
||
| 331 | * @return string The command argument string |
||
| 332 | */ |
||
| 333 | 106 | private function getCLICommandArguments() |
|
| 334 | { |
||
| 335 | 106 | $command = ''; |
|
| 336 | 106 | $combinedArguments = array_merge($this->globalCommandArguments, $this->commandArguments); |
|
| 337 | 106 | if (count($combinedArguments) > 0) { |
|
| 338 | 101 | $command .= ' ' . implode(' ', array_map('escapeshellarg', $combinedArguments)); |
|
| 339 | 101 | } |
|
| 340 | 106 | return $command; |
|
| 341 | } |
||
| 342 | |||
| 343 | /** |
||
| 344 | * get a string of CLI-formatted command name |
||
| 345 | * |
||
| 346 | * @return string The command name string |
||
| 347 | */ |
||
| 348 | 106 | private function getCLICommandName() |
|
| 352 | |||
| 353 | /** |
||
| 354 | * get a string of CLI-formatted configs |
||
| 355 | * |
||
| 356 | * @return string The config string |
||
| 357 | */ |
||
| 358 | 106 | private function getCLIConfigs() |
|
| 359 | { |
||
| 360 | 106 | $command = ''; |
|
| 374 | |||
| 375 | /** |
||
| 376 | * get a string of CLI-formatted global options |
||
| 377 | * |
||
| 378 | * @return string The global options string |
||
| 379 | */ |
||
| 380 | 106 | private function getCLIGlobalOptions() |
|
| 390 | |||
| 391 | /** |
||
| 392 | * get a string of CLI-formatted path |
||
| 393 | * |
||
| 394 | * @return string The path string |
||
| 395 | */ |
||
| 396 | 106 | private function getCLIPath() |
|
| 404 | |||
| 405 | /** |
||
| 406 | * get a string of CLI-formatted subjects |
||
| 407 | * |
||
| 408 | * @throws \RuntimeException |
||
| 409 | * @return string The subjects string |
||
| 410 | */ |
||
| 411 | 106 | private function getCLISubjects() |
|
| 440 | } |
||
| 441 |