GitElephant\Command\ResetCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getInstance()	0	4	1
A	reset()	0	15	3

<?php

/**
 * Created by PhpStorm.
 * User: christian
 * Date: 3/2/16
 * Time: 11:29 AM
 */

namespace GitElephant\Command;

use GitElephant\Objects\Commit;
use GitElephant\Objects\TreeishInterface;
use GitElephant\Repository;

class ResetCommand extends BaseCommand
{
    public const GIT_RESET_COMMAND = 'reset';

    public const OPTION_HARD = '--hard';
    public const OPTION_MERGE = '--merge';
    public const OPTION_SOFT = '--soft';

    /**
     * constructor
     *
     * @param \GitElephant\Repository $repo The repository object this command
     *                                      will interact with
     */
    public function __construct(Repository $repo = null)
    {
        parent::__construct($repo);
    }

    /**
     * @param TreeishInterface|Commit|string $arg
     * @param array $options
     *
     * @throws \RuntimeException
     * @return string
     */
    public function reset($arg = null, array $options = []): string
    {
        $this->clearAll();
        $this->addCommandName(self::GIT_RESET_COMMAND);
        // if there are options add them.
        foreach ($options as $option) {
            $this->addCommandArgument($option);
        }

        if ($arg != null) {

It seems like you are loosely comparing $arg of type GitElephant\Objects\TreeishInterface|string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $this->addCommandSubject2($arg);

It seems like $arg defined by parameter $arg on line 42 can also be of type object<GitElephant\Objects\TreeishInterface>; however, GitElephant\Command\BaseCommand::addCommandSubject2() does only seem to accept object<GitElephant\Command\SubCommandCommand>|array|string, maybe add an additional type check?

        }

        return $this->getCommand();
    }

    /**
     * @param Repository $repository
     * @return ResetCommand
     */
    public static function getInstance(Repository $repository = null): \GitElephant\Command\ResetCommand
    {
        return new self($repository);
    }
}