View GitHub Repository mysql-compat

Schedule Inspection
Subscribe
Completed
Branch — master (4dfee6)
by Matteo
04:02 queued 02:05
created

InsertTest   A

↳ Parent: Project

Complexity

Total Complexity 1

Size/Duplication

Total Lines 13
Duplicated Lines 76.92 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 1
Bugs 0 Features 1
Metric Value
wmc 1
c 1
b 0
f 1
lcom 1
cbo 2
dl 10
loc 13
rs 10

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1 
<?php
2 

            


            
                                                        
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
class InsertTest extends BridgeTestCase

            


            
                                                        
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
    public function testLastInsertedId()

            


            
                                                        
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
        $this->assertEquals(0, $this->bridge->insertId());

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
        

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
        $this->bridge->query('INSERT INTO test_table VALUES (100, "test insert")');

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
        $this->assertEquals(100, $this->bridge->insertId());

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
        $this->bridge->query('INSERT INTO test_table (testfield) VALUES ("test insert")');

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
        $this->assertEquals(101, $this->bridge->insertId());

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
}