Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | trait ExecuteQueries |
||
9 | { |
||
10 | public function affectedRows(Connection $linkIdentifier = null) |
||
16 | |||
17 | public function query($query, Connection $linkIdentifier = null) |
||
29 | |||
30 | public function selectDb($databaseName, Connection $linkIdentifier = null) |
||
36 | |||
37 | View Code Duplication | public function createDb($databaseName, Connection $linkIdentifier = null) |
|
46 | |||
47 | View Code Duplication | public function listTables($database, Connection $linkIdentifier = null) |
|
56 | |||
57 | public function insertId(Connection $linkIdentifier = null) |
||
63 | |||
64 | public function listDbs() |
||
68 | |||
69 | public function dbName() |
||
73 | |||
74 | public function dbQuery($database, $query, Connection $linkIdentifier = null) |
||
81 | |||
82 | public function dropDb() |
||
86 | |||
87 | public function listFields() |
||
91 | |||
92 | public function listProcesses() |
||
96 | |||
97 | public function tablename() |
||
101 | |||
102 | public function unbufferedQuery() |
||
106 | } |
||
107 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.