matiasdelellis / facerecognition

lib/Settings/Personal.php

<?php

namespace OCA\FaceRecognition\Settings;

use OCA\Viewer\Event\LoadViewer;

The type OCA\Viewer\Event\LoadViewer was not found. Maybe you did not declare it correctly or list all dependencies?

use OCP\EventDispatcher\IEventDispatcher;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\AppFramework\Services\IInitialState;
use OCP\Settings\ISettings;

use OCA\FaceRecognition\Db\Person;
use OCA\FaceRecognition\Db\PersonMapper;

use OCA\FaceRecognition\Service\SettingsService;

class Personal implements ISettings {

	/** @var IEventDispatcher */
	private $eventDispatcher;

	/** @var \OCP\AppFramework\Services\IInitialState **/
	protected IInitialState $initialState;

	/** @var PersonMapper */
	protected $personMapper;

	/** @var SettingsService */
	protected $settingsService;

	protected ?string $userId;

	public function __construct(IEventDispatcher $eventDispatcher,
	                            IInitialState    $initialState,
	                            PersonMapper     $personmapper,
	                            SettingsService  $settingsService,
	                            string           $userId)
	{
		$this->eventDispatcher = $eventDispatcher;
		$this->initialState = $initialState;
		$this->personMapper = $personmapper;
		$this->settingsService = $settingsService;
		$this->userId = $userId;
	}

	public function getPriority()
	{
		return 20;
	}

	public function getSection()
	{
		return 'facerecognition';
	}

	public function getSectionID(): string
	{
		return 'facerecognition';
	}

	public function getForm()
	{
		$userEnabled = $this->settingsService->getUserEnabled($this->userId);
		$unamedCount = 0;
		$hiddenCount = 0;

		if ($userEnabled) {
			$modelId = $this->settingsService->getCurrentFaceModel();
			$minClusterSize = $this->settingsService->getMinimumFacesInCluster();

			$clusters = $this->personMapper->findUnassigned($this->userId, $modelId);

It seems like $this->userId can also be of type null; however, parameter $userId of OCA\FaceRecognition\Db\PersonMapper::findUnassigned() does only seem to accept string, maybe add an additional type check?

			foreach ($clusters as $cluster) {
				$clusterSize = $this->personMapper->countClusterFaces($cluster->getId());
				if ($clusterSize >= $minClusterSize)
					$unamedCount++;
			}

			$clusters = $this->personMapper->findIgnored($this->userId, $modelId);

It seems like $this->userId can also be of type null; however, parameter $userId of OCA\FaceRecognition\Db\PersonMapper::findIgnored() does only seem to accept string, maybe add an additional type check?

			foreach ($clusters as $cluster) {
				$clusterSize = $this->personMapper->countClusterFaces($cluster->getId());
				if ($clusterSize >= $minClusterSize)
					$hiddenCount++;
			}
		}

		$this->initialState->provideInitialState('user-enabled', $userEnabled);
		$this->initialState->provideInitialState('has-unamed', $unamedCount > 0);
		$this->initialState->provideInitialState('has-hidden', $hiddenCount > 0);

		$this->eventDispatcher->dispatch(LoadViewer::class, new LoadViewer());

The function OCP\EventDispatcher\IEventDispatcher::dispatch() has been deprecated: 21.0.0 use \OCP\EventDispatcher\IEventDispatcher::dispatchTyped

		return new TemplateResponse('facerecognition', 'settings/personal');
	}

	public function getPanel(): TemplateResponse
	{
		return $this->getForm();
	}

}