SettingController::getAppValue() - Code Metrics - Inspection of "Implement settings controller and adds sensitivity..." - matiasdelellis/facerecognition - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — more-settings ( 65bbdc )

by Matias

created 2019-03-28 00:05 UTC

SettingController::getAppValue() A

↳ Parent: SettingController

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	12
nc	2
nop	1
dl	0
loc	16
ccs	0
cts	16
cp	0
crap	6
rs	9.8666
c	0
b	0
f	0

<?php

namespace OCA\FaceRecognition\Controller;

use OCA\FaceRecognition\Db\FaceMapper;
use OCA\FaceRecognition\Db\ImageMapper;
use OCA\FaceRecognition\Db\PersonMapper;

use OCP\AppFramework\Controller;
use OCP\AppFramework\Http\JSONResponse;
use OCP\IRequest;
use OCP\IConfig;

class SettingController extends Controller {

	/** @var IConfig */
	private $config;

	/** @var FaceMapper */
	private $faceMapper;

	/** @var ImageMapper */
	private $imageMapper;

	/** @var PersonMapper */
	private $personMapper;

	/** @var string */
	private $userId;

	public function __construct ($appName,
	                             IRequest     $request,
	                             IConfig      $config,
	                             FaceMapper   $faceMapper,
	                             ImageMapper  $imageMapper,
	                             PersonMapper $personMapper,
	                             $userId)
	{
		parent::__construct($appName, $request);
		$this->appName = $appName;
		$this->config = $config;
		$this->faceMapper = $faceMapper;
		$this->imageMapper = $imageMapper;
		$this->personMapper = $personMapper;
		$this->userId = $userId;
	}

	/**
	 * @param $type
	 * @param $value
	 * @return JSONResponse
	 * @throws \OCP\PreConditionNotMetException
	 */
	public function setAppValue($type, $value) {
		$this->config->setAppValue('facerecognition', $type, $value);
		$result = [
			'success' => 'true',
			'value' => $value
		];
		return new JSONResponse($result);
	}

	/**
	 * @param $type
	 * @return JSONResponse
	 */
	public function getAppValue($type) {
		$value = $this->config->getAppValue('facerecognition', $type);
		if ($value !== '') {
			$result = [
				'status' => 'success',
				'value' => $value
			];
		} else {
			$result = [
				'status' => 'false',
				'value' =>'nodata'
			];
		}
		$response = new JSONResponse();
		$response->setData($result);
		return $response;
	}

}


1			<?php
2
3			namespace OCA\FaceRecognition\Controller;
4
5			use OCA\FaceRecognition\Db\FaceMapper;
6			use OCA\FaceRecognition\Db\ImageMapper;
7			use OCA\FaceRecognition\Db\PersonMapper;
8
9			use OCP\AppFramework\Controller;
10			use OCP\AppFramework\Http\JSONResponse;
11			use OCP\IRequest;
12			use OCP\IConfig;
13
14			class SettingController extends Controller {
15
16			/** @var IConfig */
17			private $config;
18
19			/** @var FaceMapper */
20			private $faceMapper;
21
22			/** @var ImageMapper */
23			private $imageMapper;
24
25			/** @var PersonMapper */
26			private $personMapper;
27
28			/** @var string */
29			private $userId;
30
31			public function __construct ($appName,
32			IRequest $request,
33			IConfig $config,
34			FaceMapper $faceMapper,
35			ImageMapper $imageMapper,
36			PersonMapper $personMapper,
37			$userId)
38			{
39			parent::__construct($appName, $request);
40			$this->appName = $appName;
41			$this->config = $config;
42			$this->faceMapper = $faceMapper;
43			$this->imageMapper = $imageMapper;
44			$this->personMapper = $personMapper;
45			$this->userId = $userId;
46			}
47
48			/**
49			* @param $type
50			* @param $value
51			* @return JSONResponse
52			* @throws \OCP\PreConditionNotMetException
53			*/
54			public function setAppValue($type, $value) {
55			$this->config->setAppValue('facerecognition', $type, $value);
56			$result = [
57			'success' => 'true',
58			'value' => $value
59			];
60			return new JSONResponse($result);
61			}
62
63			/**
64			* @param $type
65			* @return JSONResponse
66			*/
67			public function getAppValue($type) {
68			$value = $this->config->getAppValue('facerecognition', $type);
69			if ($value !== '') {
70			$result = [
71			'status' => 'success',
72			'value' => $value
73			];
74			} else {
75			$result = [
76			'status' => 'false',
77			'value' =>'nodata'
78			];
79			}
80			$response = new JSONResponse();
81			$response->setData($result);
82			return $response;
83			}
84
85			}
86

matiasdelellis / facerecognition

Push — more-settings ( 65bbdc )

SettingController::getAppValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like