PersonMapper::findByName() - Code Metrics - Inspection of "Add button to show all clusters with same person n..." - matiasdelellis/facerecognition - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — be-coherent ( a74984...06aff4 )

by Matias

created 2019-11-28 13:52 UTC

PersonMapper::findByName() A

↳ Parent: PersonMapper

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	7
ccs	0
cts	7
cp	0
crap	2
rs	10

<?php
/**
 * @copyright Copyright (c) 2017, Matias De lellis <[email protected]>
 * @copyright Copyright (c) 2018, Branko Kokanovic <[email protected]>
 *
 * @author Branko Kokanovic <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */
namespace OCA\FaceRecognition\Db;

use OC\DB\QueryBuilder\Literal;
filter:
    dependency_paths: ["lib/*"]

use OCP\IDBConnection;
use OCP\IUser;

use OCP\AppFramework\Db\QBMapper;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\DB\QueryBuilder\IQueryBuilder;

class PersonMapper extends QBMapper {

	public function __construct(IDBConnection $db) {
		parent::__construct($db, 'face_recognition_persons', '\OCA\FaceRecognition\Db\Person');
	}

	public function find(string $userId, int $personId): Person {
		$qb = $this->db->getQueryBuilder();
		$qb->select('id', 'name')
			->from('face_recognition_persons', 'p')
			->where($qb->expr()->eq('id', $qb->createNamedParameter($personId)))
			->andWhere($qb->expr()->eq('user', $qb->createNamedParameter($userId)));
		$person = $this->findEntity($qb);
		return $person;

	}

	public function findByName(string $userId, string $personName): array {
		$qb = $this->db->getQueryBuilder();
		$qb->select('id', 'name')
			->from('face_recognition_persons', 'p')
			->where($qb->expr()->eq('name', $qb->createNamedParameter($personName)))
			->andWhere($qb->expr()->eq('user', $qb->createNamedParameter($userId)));
		return $this->findEntities($qb);
	}

	public function findAll(string $userId): array {
		$qb = $this->db->getQueryBuilder();
		$qb->select('id', 'name', 'is_valid')
			->from('face_recognition_persons', 'p')
			->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)));

		$person = $this->findEntities($qb);
		return $person;
	}

	/**
	 * Returns count of persons (clusters) found for a given user.
	 *
	 * @param string $userId ID of the user
	 * @param bool $onlyInvalid True if client wants count of invalid persons only,
	 *  false if client want count of all persons
	 * @return int Count of persons
	 */
	public function countPersons(string $userId, bool $onlyInvalid=false): int {
		$qb = $this->db->getQueryBuilder();
		$qb = $qb
			->select($qb->createFunction('COUNT(' . $qb->getColumnName('id') . ')'))
			->from($this->getTableName())
			->where($qb->expr()->eq('user', $qb->createParameter('user')));
		if ($onlyInvalid) {
			$qb = $qb
				->andWhere($qb->expr()->eq('is_valid', $qb->createParameter('is_valid')))
				->setParameter('is_valid', false, IQueryBuilder::PARAM_BOOL);
		}
		$query = $qb->setParameter('user', $userId);
		$resultStatement = $query->execute();
		$data = $resultStatement->fetch(\PDO::FETCH_NUM);
		$resultStatement->closeCursor();

		return (int)$data[0];
	}

	/**
	 * Based on a given fileId, takes all person that belong to that image
	 * and return an array with that.
	 *
	 * @param string $userId ID of the user that clusters belong to
	 * @param int $fileId ID of file image for which to searh persons.
	 *
	 * @return array of persons
	 */
	public function findFromFile(string $userId, int $fileId): array {
		$qb = $this->db->getQueryBuilder();
		$qb->select('p.id', 'name');
		$qb->from("face_recognition_persons", "p")
			->innerJoin('p', 'face_recognition_faces' ,'f', $qb->expr()->eq('p.id', 'f.person'))
			->innerJoin('p', 'face_recognition_images' ,'i', $qb->expr()->eq('i.id', 'f.image'))
			->where($qb->expr()->eq('p.user', $qb->createNamedParameter($userId)))
			->andWhere($qb->expr()->eq('i.file', $qb->createNamedParameter($fileId)));
		$persons = $this->findEntities($qb);

		return $persons;
	}

	/**
	 * Based on a given image, takes all faces that belong to that image
	 * and invalidates all person that those faces belongs to.
	 *
	 * @param int $imageId ID of image for which to invalidate persons for
	 */
	public function invalidatePersons(int $imageId) {
		$sub = $this->db->getQueryBuilder();
		$tableNameWithPrefixWithoutQuotes = trim($sub->getTableName($this->getTableName()), '`');
		$sub->select(new Literal('1'));
		$sub->from("face_recognition_images", "i")
			->innerJoin('i', 'face_recognition_faces' ,'f', $sub->expr()->eq('i.id', 'f.image'))
			->where($sub->expr()->eq($tableNameWithPrefixWithoutQuotes . '.id', 'f.person'))
			->andWhere($sub->expr()->eq('i.id', $sub->createParameter('image_id')));

		$qb = $this->db->getQueryBuilder();
		$qb->update($this->getTableName())
			->set("is_valid", $qb->createParameter('is_valid'))
			->where('EXISTS (' . $sub->getSQL() . ')')
			->setParameter('image_id', $imageId)
			->setParameter('is_valid', false, IQueryBuilder::PARAM_BOOL)
			->execute();
	}

	/**
	 * Updates one face with $faceId to database to person ID $personId.
	 *
	 * @param int $faceId ID of the face
	 * @param int|null $personId ID of the person
	 */
	private function updateFace(int $faceId, $personId) {
		$qb = $this->db->getQueryBuilder();
		$qb->update('face_recognition_faces')
			->set("person", $qb->createNamedParameter($personId))
			->where($qb->expr()->eq('id', $qb->createNamedParameter($faceId)))
			->execute();
	}

	/**
	 * Based on current clusters and new clusters, do database reconciliation.
	 * It tries to do that in minimal number of SQL queries. Operation is atomic.
	 *
	 * Clusters are array, where keys are ID of persons, and values are indexed arrays
	 * with values that are ID of the faces for those persons.
	 *
	 * @param string $userId ID of the user that clusters belong to
	 * @param array $currentClusters Current clusters
	 * @param array $newClusters New clusters
	 */
	public function mergeClusterToDatabase(string $userId, $currentClusters, $newClusters) {
		$this->db->beginTransaction();
		$currentDateTime = new \DateTime();

		try {
			// Delete clusters that do not exist anymore
			foreach($currentClusters as $oldPerson => $oldFaces) {
				if (array_key_exists($oldPerson, $newClusters)) {
					continue;
				}

				// OK, we bumped into cluster that existed and now it does not exist.
				// We need to remove all references to it and to delete it.
				foreach ($oldFaces as $oldFace) {
					$this->updateFace($oldFace, null);
				}

				// todo: this is not very cool. What if user had associated linked user to this. And all lost?
				$qb = $this->db->getQueryBuilder();
				// todo: for extra safety, we should probably add here additional condition, where (user=$userId)
				$qb
					->delete($this->getTableName())
					->where($qb->expr()->eq('id', $qb->createNamedParameter($oldPerson)))
					->execute();
			}

			// Modify existing clusters
			foreach($newClusters as $newPerson=>$newFaces) {
				if (!array_key_exists($newPerson, $currentClusters)) {
					// This cluster didn't exist, there is nothing to modify
					// It will be processed during cluster adding operation
					continue;
				}

				$oldFaces = $currentClusters[$newPerson];
				if ($newFaces === $oldFaces) {
					// Set cluster as valid now
					$qb = $this->db->getQueryBuilder();
					$qb
						->update($this->getTableName())
						->set("is_valid", $qb->createParameter('is_valid'))
						->where($qb->expr()->eq('id', $qb->createNamedParameter($newPerson)))
						->setParameter('is_valid', true, IQueryBuilder::PARAM_BOOL)
						->execute();
					continue;
				}

				// OK, set of faces do differ. Now, we could potentially go into finer grain details
				// and add/remove each individual face, but this seems too detailed. Enough is to
				// reset all existing faces to null and to add new faces to new person. That should
				// take care of both faces that are removed from cluster, as well as for newly added
				// faces to this cluster.

				// First remove all old faces from any cluster (reset them to null)
				foreach ($oldFaces as $oldFace) {
					// Reset face to null only if it wasn't moved to other cluster!
					// (if face is just moved to other cluster, do not reset to null, as some other
					// pass for some other cluster will eventually update it to proper cluster)
					if ($this->isFaceInClusters($oldFace, $newClusters) === false) {
						$this->updateFace($oldFace, null);
					}
				}

				// Then set all new faces to belong to this cluster
				foreach ($newFaces as $newFace) {
					$this->updateFace($newFace, $newPerson);
				}

				// Set cluster as valid now
				$qb = $this->db->getQueryBuilder();
				$qb
					->update($this->getTableName())
					->set("is_valid", $qb->createParameter('is_valid'))
					->where($qb->expr()->eq('id', $qb->createNamedParameter($newPerson)))
					->setParameter('is_valid', true, IQueryBuilder::PARAM_BOOL)
					->execute();
			}

			// Add new clusters
			foreach($newClusters as $newPerson=>$newFaces) {
				if (array_key_exists($newPerson, $currentClusters)) {
					// This cluster already existed, nothing to add
					// It was already processed during modify cluster operation
					continue;
				}

				// Create new cluster and add all faces to it
				$qb = $this->db->getQueryBuilder();
				$qb
					->insert($this->getTableName())
					->values([
						'user' => $qb->createNamedParameter($userId),
						'name' => $qb->createNamedParameter(sprintf("New person %d", $newPerson)),
						'is_valid' => $qb->createNamedParameter(true),
						'last_generation_time' => $qb->createNamedParameter($currentDateTime, IQueryBuilder::PARAM_DATE),
						'linked_user' => $qb->createNamedParameter(null)])
					->execute();
				$insertedPersonId = $this->db->lastInsertId($this->getTableName());
				foreach ($newFaces as $newFace) {
					$this->updateFace($newFace, $insertedPersonId);
				}
			}

			$this->db->commit();
		} catch (\Exception $e) {
			$this->db->rollBack();
			throw $e;
		}
	}

	/**
	 * Deletes all persons from that user.
	 *
	 * @param string $userId User to drop persons from a table.
	 */
	public function deleteUserPersons(string $userId) {
		$qb = $this->db->getQueryBuilder();
		$qb->delete($this->getTableName())
			->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
			->execute();
	}

	/**
	 * Deletes person if it is empty (have no faces associated to it)
	 *
	 * @param int $personId Person to check if it should be deleted
	 */
	public function removeIfEmpty(int $personId) {
		$sub = $this->db->getQueryBuilder();
		$sub->select(new Literal('1'));
		$sub->from("face_recognition_faces", "f")
			->where($sub->expr()->eq('f.person', $sub->createParameter('person')));

		$qb = $this->db->getQueryBuilder();
		$qb->delete($this->getTableName())
			->where($qb->expr()->eq('id', $qb->createParameter('person')))
			->andWhere('NOT EXISTS (' . $sub->getSQL() . ')')
			->setParameter('person', $personId)
			->execute();
	}

	/**
	 * Deletes all persons that have no faces associated to them
	 *
	 * @param string $userId ID of user for which we are deleting orphaned persons
	 */
	public function deleteOrphaned(string $userId): int {
		$sub = $this->db->getQueryBuilder();
		$sub->select(new Literal('1'));
		$sub->from("face_recognition_faces", "f")
			->where($sub->expr()->eq('f.person', 'p.id'));

		$qb = $this->db->getQueryBuilder();
		$qb->select('p.id')
			->from($this->getTableName(), 'p')
			->where($qb->expr()->eq('p.user', $qb->createParameter('user')))
			->andWhere('NOT EXISTS (' . $sub->getSQL() . ')')
			->setParameter('user', $userId);
		$orphanedPersons = $this->findEntities($qb);

		$orphaned = 0;
		foreach ($orphanedPersons as $person) {
			$qb = $this->db->getQueryBuilder();
			$orphaned += $qb->delete($this->getTableName())
				->where($qb->expr()->eq('id', $qb->createNamedParameter($person->id)))
				->execute();
		}
		return $orphaned;
	}

	/**
	 * Checks if face with a given ID is in any cluster.
	 *
	 * @param int $faceId ID of the face to check
	 * @param array $cluster All clusters to check into
	 *
	 * @return bool True if face is found in any cluster, false otherwise.
	 */
	private function isFaceInClusters(int $faceId, array $clusters): bool {
		foreach ($clusters as $_=>$faces) {
			if (in_array($faceId, $faces)) {
				return true;
			}
		}
		return false;
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2017, Matias De lellis <[email protected]>
4			* @copyright Copyright (c) 2018, Branko Kokanovic <[email protected]>
5			*
6			* @author Branko Kokanovic <[email protected]>
7			*
8			* @license GNU AGPL version 3 or any later version
9			*
10			* This program is free software: you can redistribute it and/or modify
11			* it under the terms of the GNU Affero General Public License as
12			* published by the Free Software Foundation, either version 3 of the
13			* License, or (at your option) any later version.
14			*
15			* This program is distributed in the hope that it will be useful,
16			* but WITHOUT ANY WARRANTY; without even the implied warranty of
17			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18			* GNU Affero General Public License for more details.
19			*
20			* You should have received a copy of the GNU Affero General Public License
21			* along with this program. If not, see <http://www.gnu.org/licenses/>.
22			*
23			*/
24			namespace OCA\FaceRecognition\Db;
25
26			use OC\DB\QueryBuilder\Literal;
			0 ignored issues – show Bug introduced 2018-11-21 10:16 UTC by Report Bug Copy Issue Report The type `OC\DB\QueryBuilder\Literal` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
27
28			use OCP\IDBConnection;
29			use OCP\IUser;
30
31			use OCP\AppFramework\Db\QBMapper;
32			use OCP\AppFramework\Db\DoesNotExistException;
33			use OCP\DB\QueryBuilder\IQueryBuilder;
34
35			class PersonMapper extends QBMapper {
36
37			public function __construct(IDBConnection $db) {
38			parent::__construct($db, 'face_recognition_persons', '\OCA\FaceRecognition\Db\Person');
39			}
40
41			public function find(string $userId, int $personId): Person {
42			$qb = $this->db->getQueryBuilder();
43			$qb->select('id', 'name')
44			->from('face_recognition_persons', 'p')
45			->where($qb->expr()->eq('id', $qb->createNamedParameter($personId)))
46			->andWhere($qb->expr()->eq('user', $qb->createNamedParameter($userId)));
47			$person = $this->findEntity($qb);
48			return $person;
			0 ignored issues – show Bug Best Practice introduced 2019-11-28 14:00 UTC by Report Bug Copy Issue Report The expression `return $person` returns the type `OCP\AppFramework\Db\Entity` which includes types incompatible with the type-hinted return `OCA\FaceRecognition\Db\Person`. Loading history...
49			}
50
51			public function findByName(string $userId, string $personName): array {
52			$qb = $this->db->getQueryBuilder();
53			$qb->select('id', 'name')
54			->from('face_recognition_persons', 'p')
55			->where($qb->expr()->eq('name', $qb->createNamedParameter($personName)))
56			->andWhere($qb->expr()->eq('user', $qb->createNamedParameter($userId)));
57			return $this->findEntities($qb);
58			}
59
60			public function findAll(string $userId): array {
61			$qb = $this->db->getQueryBuilder();
62			$qb->select('id', 'name', 'is_valid')
63			->from('face_recognition_persons', 'p')
64			->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)));
65
66			$person = $this->findEntities($qb);
67			return $person;
68			}
69
70			/**
71			* Returns count of persons (clusters) found for a given user.
72			*
73			* @param string $userId ID of the user
74			* @param bool $onlyInvalid True if client wants count of invalid persons only,
75			* false if client want count of all persons
76			* @return int Count of persons
77			*/
78			public function countPersons(string $userId, bool $onlyInvalid=false): int {
79			$qb = $this->db->getQueryBuilder();
80			$qb = $qb
81			->select($qb->createFunction('COUNT(' . $qb->getColumnName('id') . ')'))
82			->from($this->getTableName())
83			->where($qb->expr()->eq('user', $qb->createParameter('user')));
84			if ($onlyInvalid) {
85			$qb = $qb
86			->andWhere($qb->expr()->eq('is_valid', $qb->createParameter('is_valid')))
87			->setParameter('is_valid', false, IQueryBuilder::PARAM_BOOL);
88			}
89			$query = $qb->setParameter('user', $userId);
90			$resultStatement = $query->execute();
91			$data = $resultStatement->fetch(\PDO::FETCH_NUM);
92			$resultStatement->closeCursor();
93
94			return (int)$data[0];
95			}
96
97			/**
98			* Based on a given fileId, takes all person that belong to that image
99			* and return an array with that.
100			*
101			* @param string $userId ID of the user that clusters belong to
102			* @param int $fileId ID of file image for which to searh persons.
103			*
104			* @return array of persons
105			*/
106			public function findFromFile(string $userId, int $fileId): array {
107			$qb = $this->db->getQueryBuilder();
108			$qb->select('p.id', 'name');
109			$qb->from("face_recognition_persons", "p")
110			->innerJoin('p', 'face_recognition_faces' ,'f', $qb->expr()->eq('p.id', 'f.person'))
111			->innerJoin('p', 'face_recognition_images' ,'i', $qb->expr()->eq('i.id', 'f.image'))
112			->where($qb->expr()->eq('p.user', $qb->createNamedParameter($userId)))
113			->andWhere($qb->expr()->eq('i.file', $qb->createNamedParameter($fileId)));
114			$persons = $this->findEntities($qb);
115
116			return $persons;
117			}
118
119			/**
120			* Based on a given image, takes all faces that belong to that image
121			* and invalidates all person that those faces belongs to.
122			*
123			* @param int $imageId ID of image for which to invalidate persons for
124			*/
125			public function invalidatePersons(int $imageId) {
126			$sub = $this->db->getQueryBuilder();
127			$tableNameWithPrefixWithoutQuotes = trim($sub->getTableName($this->getTableName()), '`');
128			$sub->select(new Literal('1'));
129			$sub->from("face_recognition_images", "i")
130			->innerJoin('i', 'face_recognition_faces' ,'f', $sub->expr()->eq('i.id', 'f.image'))
131			->where($sub->expr()->eq($tableNameWithPrefixWithoutQuotes . '.id', 'f.person'))
132			->andWhere($sub->expr()->eq('i.id', $sub->createParameter('image_id')));
133
134			$qb = $this->db->getQueryBuilder();
135			$qb->update($this->getTableName())
136			->set("is_valid", $qb->createParameter('is_valid'))
137			->where('EXISTS (' . $sub->getSQL() . ')')
138			->setParameter('image_id', $imageId)
139			->setParameter('is_valid', false, IQueryBuilder::PARAM_BOOL)
140			->execute();
141			}
142
143			/**
144			* Updates one face with $faceId to database to person ID $personId.
145			*
146			* @param int $faceId ID of the face
147			* @param int\|null $personId ID of the person
148			*/
149			private function updateFace(int $faceId, $personId) {
150			$qb = $this->db->getQueryBuilder();
151			$qb->update('face_recognition_faces')
152			->set("person", $qb->createNamedParameter($personId))
153			->where($qb->expr()->eq('id', $qb->createNamedParameter($faceId)))
154			->execute();
155			}
156
157			/**
158			* Based on current clusters and new clusters, do database reconciliation.
159			* It tries to do that in minimal number of SQL queries. Operation is atomic.
160			*
161			* Clusters are array, where keys are ID of persons, and values are indexed arrays
162			* with values that are ID of the faces for those persons.
163			*
164			* @param string $userId ID of the user that clusters belong to
165			* @param array $currentClusters Current clusters
166			* @param array $newClusters New clusters
167			*/
168			public function mergeClusterToDatabase(string $userId, $currentClusters, $newClusters) {
169			$this->db->beginTransaction();
170			$currentDateTime = new \DateTime();
171
172			try {
173			// Delete clusters that do not exist anymore
174			foreach($currentClusters as $oldPerson => $oldFaces) {
175			if (array_key_exists($oldPerson, $newClusters)) {
176			continue;
177			}
178
179			// OK, we bumped into cluster that existed and now it does not exist.
180			// We need to remove all references to it and to delete it.
181			foreach ($oldFaces as $oldFace) {
182			$this->updateFace($oldFace, null);
183			}
184
185			// todo: this is not very cool. What if user had associated linked user to this. And all lost?
186			$qb = $this->db->getQueryBuilder();
187			// todo: for extra safety, we should probably add here additional condition, where (user=$userId)
188			$qb
189			->delete($this->getTableName())
190			->where($qb->expr()->eq('id', $qb->createNamedParameter($oldPerson)))
191			->execute();
192			}
193
194			// Modify existing clusters
195			foreach($newClusters as $newPerson=>$newFaces) {
196			if (!array_key_exists($newPerson, $currentClusters)) {
197			// This cluster didn't exist, there is nothing to modify
198			// It will be processed during cluster adding operation
199			continue;
200			}
201
202			$oldFaces = $currentClusters[$newPerson];
203			if ($newFaces === $oldFaces) {
204			// Set cluster as valid now
205			$qb = $this->db->getQueryBuilder();
206			$qb
207			->update($this->getTableName())
208			->set("is_valid", $qb->createParameter('is_valid'))
209			->where($qb->expr()->eq('id', $qb->createNamedParameter($newPerson)))
210			->setParameter('is_valid', true, IQueryBuilder::PARAM_BOOL)
211			->execute();
212			continue;
213			}
214
215			// OK, set of faces do differ. Now, we could potentially go into finer grain details
216			// and add/remove each individual face, but this seems too detailed. Enough is to
217			// reset all existing faces to null and to add new faces to new person. That should
218			// take care of both faces that are removed from cluster, as well as for newly added
219			// faces to this cluster.
220
221			// First remove all old faces from any cluster (reset them to null)
222			foreach ($oldFaces as $oldFace) {
223			// Reset face to null only if it wasn't moved to other cluster!
224			// (if face is just moved to other cluster, do not reset to null, as some other
225			// pass for some other cluster will eventually update it to proper cluster)
226			if ($this->isFaceInClusters($oldFace, $newClusters) === false) {
227			$this->updateFace($oldFace, null);
228			}
229			}
230
231			// Then set all new faces to belong to this cluster
232			foreach ($newFaces as $newFace) {
233			$this->updateFace($newFace, $newPerson);
234			}
235
236			// Set cluster as valid now
237			$qb = $this->db->getQueryBuilder();
238			$qb
239			->update($this->getTableName())
240			->set("is_valid", $qb->createParameter('is_valid'))
241			->where($qb->expr()->eq('id', $qb->createNamedParameter($newPerson)))
242			->setParameter('is_valid', true, IQueryBuilder::PARAM_BOOL)
243			->execute();
244			}
245
246			// Add new clusters
247			foreach($newClusters as $newPerson=>$newFaces) {
248			if (array_key_exists($newPerson, $currentClusters)) {
249			// This cluster already existed, nothing to add
250			// It was already processed during modify cluster operation
251			continue;
252			}
253
254			// Create new cluster and add all faces to it
255			$qb = $this->db->getQueryBuilder();
256			$qb
257			->insert($this->getTableName())
258			->values([
259			'user' => $qb->createNamedParameter($userId),
260			'name' => $qb->createNamedParameter(sprintf("New person %d", $newPerson)),
261			'is_valid' => $qb->createNamedParameter(true),
262			'last_generation_time' => $qb->createNamedParameter($currentDateTime, IQueryBuilder::PARAM_DATE),
263			'linked_user' => $qb->createNamedParameter(null)])
264			->execute();
265			$insertedPersonId = $this->db->lastInsertId($this->getTableName());
266			foreach ($newFaces as $newFace) {
267			$this->updateFace($newFace, $insertedPersonId);
268			}
269			}
270
271			$this->db->commit();
272			} catch (\Exception $e) {
273			$this->db->rollBack();
274			throw $e;
275			}
276			}
277
278			/**
279			* Deletes all persons from that user.
280			*
281			* @param string $userId User to drop persons from a table.
282			*/
283			public function deleteUserPersons(string $userId) {
284			$qb = $this->db->getQueryBuilder();
285			$qb->delete($this->getTableName())
286			->where($qb->expr()->eq('user', $qb->createNamedParameter($userId)))
287			->execute();
288			}
289
290			/**
291			* Deletes person if it is empty (have no faces associated to it)
292			*
293			* @param int $personId Person to check if it should be deleted
294			*/
295			public function removeIfEmpty(int $personId) {
296			$sub = $this->db->getQueryBuilder();
297			$sub->select(new Literal('1'));
298			$sub->from("face_recognition_faces", "f")
299			->where($sub->expr()->eq('f.person', $sub->createParameter('person')));
300
301			$qb = $this->db->getQueryBuilder();
302			$qb->delete($this->getTableName())
303			->where($qb->expr()->eq('id', $qb->createParameter('person')))
304			->andWhere('NOT EXISTS (' . $sub->getSQL() . ')')
305			->setParameter('person', $personId)
306			->execute();
307			}
308
309			/**
310			* Deletes all persons that have no faces associated to them
311			*
312			* @param string $userId ID of user for which we are deleting orphaned persons
313			*/
314			public function deleteOrphaned(string $userId): int {
315			$sub = $this->db->getQueryBuilder();
316			$sub->select(new Literal('1'));
317			$sub->from("face_recognition_faces", "f")
318			->where($sub->expr()->eq('f.person', 'p.id'));
319
320			$qb = $this->db->getQueryBuilder();
321			$qb->select('p.id')
322			->from($this->getTableName(), 'p')
323			->where($qb->expr()->eq('p.user', $qb->createParameter('user')))
324			->andWhere('NOT EXISTS (' . $sub->getSQL() . ')')
325			->setParameter('user', $userId);
326			$orphanedPersons = $this->findEntities($qb);
327
328			$orphaned = 0;
329			foreach ($orphanedPersons as $person) {
330			$qb = $this->db->getQueryBuilder();
331			$orphaned += $qb->delete($this->getTableName())
332			->where($qb->expr()->eq('id', $qb->createNamedParameter($person->id)))
333			->execute();
334			}
335			return $orphaned;
336			}
337
338			/**
339			* Checks if face with a given ID is in any cluster.
340			*
341			* @param int $faceId ID of the face to check
342			* @param array $cluster All clusters to check into
343			*
344			* @return bool True if face is found in any cluster, false otherwise.
345			*/
346			private function isFaceInClusters(int $faceId, array $clusters): bool {
347			foreach ($clusters as $_=>$faces) {
348			if (in_array($faceId, $faces)) {
349			return true;
350			}
351			}
352			return false;
353			}
354			}
355

matiasdelellis / facerecognition

Push — be-coherent ( a74984...06aff4 )

PersonMapper::findByName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like