matiasdelellis / facerecognition

lib/Controller/PersonController.php

Doc Comments -1 removed lines

@@ -50,7 +50,6 @@
 	/**
 	 * @NoAdminRequired
 	 *
-	 * @param string $oldName
 	 * @param string $newName
 	 */
 	public function updateName($name, $newName) {

Unused Use Statements -7 removed lines

@@ -3,16 +3,9 @@
 
 use OCP\IRequest;
 use OCP\Files\IRootFolder;
-use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
-use OCP\AppFramework\Http\JSONResponse;
-use OCP\AppFramework\Http\DataDisplayResponse;
 use OCP\AppFramework\Controller;
-
-use OCA\FaceRecognition\Db\Face;
 use OCA\FaceRecognition\Db\FaceMapper;
-
-use OCA\FaceRecognition\Db\Person;
 use OCA\FaceRecognition\Db\PersonMapper;
 
 class PersonController extends Controller {

lib/Db/FaceMapper.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 
 use OCP\IDBConnection;
 use OCP\AppFramework\Db\Mapper;
-use OCP\AppFramework\Db\DoesNotExistException;
-use OCP\DB\QueryBuilder\IQueryBuilder;
 
 class FaceMapper extends Mapper {
 

Doc Comments +23 added lines

@@ -22,16 +22,27 @@ 
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param string $userId
+	 * @param integer $limit
+	 * @param integer $offset
+	 */
 	public function findAllQueued($userId, $limit = null, $offset = null) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND distance = -1 AND encoding IS NULL';
 		return $this->findEntities($sql, [$userId], $limit, $offset);
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function findAllKnown($userId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND distance = 0 AND encoding IS NOT NULL';
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function findAllUnknown($userId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND distance > 0 AND encoding IS NOT NULL';
 		return $this->findEntities($sql, [$userId]);
@@ -42,6 +53,9 @@ 
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param integer $limit
+	 */
 	public function findAllNamed($userId, $query, $limit = null, $offset = null) {
 		$sql = 'SELECT id, name, distance FROM *PREFIX*face_recognition WHERE uid = ? AND encoding IS NOT NULL AND LOWER(name) LIKE LOWER(?)';
 		return $this->findEntities($sql, [$userId, $query], $limit, $offset);
@@ -57,11 +71,17 @@ 
 		return $this->findEntities($sql, [$userId]);
 	}
 
+	/**
+	 * @param integer $fileId
+	 */
 	public function findNewFile($userId, $fileId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND file = ? AND distance = -1 AND encoding IS NULL';
 		return $this->findEntities($sql, [$userId, $fileId]);
 	}
 
+	/**
+	 * @param integer $fileId
+	 */
 	public function findFile($userId, $fileId) {
 		$sql = 'SELECT * FROM *PREFIX*face_recognition WHERE uid = ? AND file = ?';
 		return $this->findEntities($sql, [$userId, $fileId]);
@@ -78,6 +98,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function countUserQueue($userId) {
 		$sql = 'SELECT count(*) AS ct FROM *PREFIX*face_recognition WHERE uid = ? AND distance = -1 AND encoding IS NULL';
 		$query = \OCP\DB::prepare($sql);

lib/Db/FaceNew.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OCA\FaceRecognition\Db;
 
 use JsonSerializable;
-
 use OCP\AppFramework\Db\Entity;
 
 /**

lib/Db/FaceNewMapper.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use OCP\IDBConnection;
 use OCP\AppFramework\Db\Mapper;
-use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\DB\QueryBuilder\IQueryBuilder;
 
 class FaceNewMapper extends Mapper {

Doc Comments +6 added lines

@@ -22,6 +22,9 @@ 
 		return $faces;
 	}
 
+	/**
+	 * @param integer $model
+	 */
 	public function countFaces(string $userId, $model): int {
 		$qb = $this->db->getQueryBuilder();
 		$query = $qb
@@ -39,6 +42,9 @@ 
 		return (int)$data[0];
 	}
 
+	/**
+	 * @param integer $model
+	 */
 	public function getFaces(string $userId, $model): array {
 		$qb = $this->db->getQueryBuilder();
 		$query = $qb

lib/Db/ImageMapper.php

Doc Comments +6 added lines

@@ -53,6 +53,9 @@ 
 		return $row ? (int)$row['id'] : null;
 	}
 
+	/**
+	 * @param integer $model
+	 */
 	public function countUserImages(string $userId, $model): int {
 		$qb = $this->db->getQueryBuilder();
 		$query = $qb
@@ -69,6 +72,9 @@ 
 		return (int)$data[0];
 	}
 
+	/**
+	 * @param integer $model
+	 */
 	public function countUserProcessedImages(string $userId, $model): int {
 		$qb = $this->db->getQueryBuilder();
 		$query = $qb

Unused Use Statements -2 removed lines

@@ -25,9 +25,7 @@
 
 use OCP\IDBConnection;
 use OCP\IUser;
-
 use OCP\AppFramework\Db\Mapper;
-use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\DB\QueryBuilder\IQueryBuilder;
 
 class ImageMapper extends Mapper {

lib/Helper/PythonAnalyzer.php

Doc Comments +8 added lines

@@ -11,6 +11,11 @@ 
 	protected $model;
 	protected $fileList;
 
+	/**
+	 * @param string $command
+	 * @param string $predictor
+	 * @param string $model
+	 */
 	function __construct($command, $predictor, $model) {
 		$this->command = $command;
 		$this->predictor = $predictor;
@@ -18,6 +23,9 @@ 
 		$this->fileList = "";
 	}
 
+	/**
+	 * @param string $filename
+	 */
 	public function appendFile ($filename)
 	{
 		$this->fileList .= " ".escapeshellarg($filename);

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace OCA\FaceRecognition\Helper;
 
-use OCP\App\IAppManager;
-
 class PythonAnalyzer
 {
 	protected $command;

lib/Helper/Requirements.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 	 * Based on that and the fact that Nextcloud is superset of these, these are supported image types.
 	 *
 	 * @param string $mimeType MIME type to check if it supported
-	 * @return true if MIME type is supported, false otherwise
+	 * @return boolean if MIME type is supported, false otherwise
 	 */
 	public static function isImageTypeSupported(string $mimeType): bool {
 		if (

lib/Watcher.php

Unused Use Statements -1 removed lines

@@ -31,7 +31,6 @@
 use OCP\IDBConnection;
 use OCP\ILogger;
 use OCP\IUserManager;
-
 use OCA\FaceRecognition\BackgroundJob\Tasks\AddMissingImagesTask;
 use OCA\FaceRecognition\Db\Face;
 use OCA\FaceRecognition\Db\Image;

lib/Controller/FaceController.php

Unused Use Statements -7 removed lines

@@ -5,17 +5,10 @@
 use OCP\Files\IRootFolder;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
-use OCP\AppFramework\Http\JSONResponse;
 use OCP\AppFramework\Http\DataDisplayResponse;
 use OCP\AppFramework\Controller;
-
-use OCA\FaceRecognition\Db\Face;
 use OCA\FaceRecognition\Db\FaceMapper;
-
-use OCA\FaceRecognition\Db\FaceNew;
 use OCA\FaceRecognition\Db\FaceNewMapper;
-
-use OCA\FaceRecognition\Db\Image;
 use OCA\FaceRecognition\Db\ImageMapper;
 
 class FaceController extends Controller {

Doc Comments +4 added lines, -1 removed lines

@@ -82,6 +82,9 @@ 
 		return $this->getFaceThumb ($fileId, $face);
 	}
 
+	/**
+	 * @param \OCP\AppFramework\Db\Entity $face
+	 */
 	private function getFaceThumb ($fileId, $face) {
 		$userFolder = $this->rootFolder->getUserFolder($this->userId);
 		$nodes = $userFolder->getById($fileId);
@@ -141,7 +144,7 @@ 
 	 * @NoAdminRequired
 	 *
 	 * @param int $id
-	 * @param string $name
+	 * @param string $newName
 	 */
 	public function updateName ($id, $newName) {
 		$face = $this->faceMapper->find($id, $this->userId);