OCA\FaceRecognition\Command\SyncAlbumsCommand::execute()

Complexity

Conditions	15
Paths	26

Size

Total Lines	81
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	240

Importance

Changes	3
Bugs	1	Features	1

<?php
	protected function execute(InputInterface $input, OutputInterface $output) {
		if (!$this->appManager->isEnabledForUser('photos')) {
			$output->writeln('The photos app is disabled.');
			return 1;
		}

		$users = array();
		$userId = $input->getOption('user_id');
		$personNames = array();

The assignment to $personNames is dead and can be removed.

		$person_name = $input->getOption('person_name');
		$mode = $input->getOption('mode');

		if (!is_null($userId)) {
			if ($this->userManager->get($userId) === null) {

It seems like $userId can also be of type string[]; however, parameter $uid of OCP\IUserManager::get() does only seem to accept string, maybe add an additional type check?

				$output->writeln("User with id <$userId> in unknown.");
				return 1;
			}
			else {
				$users[] = $userId;
			}
		}
		else {
			$this->userManager->callForAllUsers(function (IUser $iUser) use (&$users) {
				$users[] = $iUser->getUID();
			});
		}

		if ($input->getOption('list_person')) {
			if (is_null($userId)) {
				$output->writeln("List option requires option user_id!");
				return 1;
			} else{
				$output->writeln("List of defined persons for the user <$userId> :");
				$modelId = $this->settingsService->getCurrentFaceModel();
				$distintNames = $this->personMapper->findDistinctNames($userId, $modelId);
				foreach ($distintNames as $key=>$distintName) {
					if ($key > 0 ){
						$output->write(", ");
					}
					$output->write($distintName->getName());
				}
				$output->writeln("");
				$output->writeln("Done.");
			}
			return 0;
		}

		foreach ($users as $userId) {
			if (!is_null($person_name)) {
				if (is_null($userId)) {
					$output->writeln("Person_name option requires option user_id!");
					return 1;
				}
				$output->writeln("Synchronizing albums for the user <$userId> and person_name <$person_name> using mode <$mode>... ");
				if ($mode === "album-per-person") {
					$personList = explode(",", $person_name);
					foreach ($personList as $person) {
						$this->photoAlbums->syncUserPersonNamesSelected($userId, $person, $output);
					}
				}
				else if ($mode === "album-combined") {
					$personList = explode(",", $person_name); 
					if (count($personList) < 2) {
						$output->writeln("Note parameter mode <$mode> requires at least two persons separated using coma.");
						return 1;
					}
					$this->photoAlbums->syncUserPersonNamesCombinedAlbum($userId, $personList, $output);
				}
				else {
					$output->writeln("Error: invalid value for parameter mode <$mode>. ");
					return 1;
				}
				$output->writeln("Done.");
			} else {
				$output->write("Synchronizing albums for the user <$userId>... ");
				$this->photoAlbums->syncUser($userId);
				$output->writeln("Done.");
			}
		}

		return 0;
	}