Passed
Push — better-links ( 0170f3 )
by Matias
02:51 queued 21s
created

PersonController::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 20
Code Lines 9

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
cc 1
eloc 9
nc 1
nop 10
dl 0
loc 20
ccs 0
cts 20
cp 0
crap 2
rs 9.9666
c 0
b 0
f 0

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
namespace OCA\FaceRecognition\Controller;
3
4
use OCP\IRequest;
5
use OCP\IConfig;
6
use OCP\Files\IRootFolder;
7
use OCP\IUserSession;
8
use OCP\IURLGenerator;
9
use OCP\AppFramework\Http;
10
use OCP\AppFramework\Http\DataResponse;
11
use OCP\AppFramework\Http\JSONResponse;
12
use OCP\AppFramework\Http\DataDisplayResponse;
13
use OCP\AppFramework\Controller;
14
15
use OCA\FaceRecognition\Db\Face;
16
use OCA\FaceRecognition\Db\FaceMapper;
17
18
use OCA\FaceRecognition\Db\Image;
19
use OCA\FaceRecognition\Db\ImageMapper;
20
21
use OCA\FaceRecognition\Db\Person;
22
use OCA\FaceRecognition\Db\PersonMapper;
23
24
use OCA\FaceRecognition\Migration\AddDefaultFaceModel;
25
26
class PersonController extends Controller {
27
28
	private $config;
29
	private $rootFolder;
30
	private $userSession;
31
	private $urlGenerator;
32
	private $faceMapper;
33
	private $imageMapper;
34
	private $personMapper;
35
	private $userId;
36
37
	public function __construct($AppName,
38
	                            IRequest      $request,
39
	                            IConfig       $config,
40
	                            IRootFolder   $rootFolder,
41
	                            IUserSession  $userSession,
42
	                            IURLGenerator $urlGenerator,
43
	                            FaceMapper    $faceMapper,
44
	                            ImageMapper   $imageMapper,
45
	                            PersonMapper  $personmapper,
46
	                            $UserId)
47
	{
48
		parent::__construct($AppName, $request);
49
		$this->config       = $config;
50
		$this->rootFolder   = $rootFolder;
51
		$this->userSession  = $userSession;
52
		$this->urlGenerator = $urlGenerator;
53
		$this->imageMapper  = $imageMapper;
54
		$this->faceMapper   = $faceMapper;
55
		$this->personMapper = $personmapper;
56
		$this->userId       = $UserId;
57
	}
58
59
	/**
60
	 * @NoAdminRequired
61
	 */
62
	public function index() {
63
		$model = intval($this->config->getAppValue('facerecognition', 'model', AddDefaultFaceModel::DEFAULT_FACE_MODEL_ID));
64
65
		$resp = array();
66
		$persons = $this->personMapper->findAll($this->userId);
67
		foreach ($persons as $person) {
68
			$cluster = [];
69
			$faces = [];
70
			$personFaces = $this->faceMapper->findFacesFromPerson($this->userId, $person->getId(), $model);
71
			foreach ($personFaces as $personFace) {
72
				$image = $this->imageMapper->find($this->userId, $personFace->getImage());
73
				$face = [];
74
				$face['thumb-url'] = $this->getThumbUrl($personFace->getId());
75
				$face['file-url'] = $this->getRedirectToFileUrl($image->getFile());
76
				$faces[] = $face;
77
			}
78
			$cluster['name'] = $person->getName();
79
			$cluster['id'] = $person->getId();
80
			$cluster['faces'] = $faces;
81
			$resp[] = $cluster;
82
		}
83
		return new DataResponse($resp);
84
	}
85
86
	/**
87
	 * @NoAdminRequired
88
	 *
89
	 * @param int $id
90
	 * @param string $name
91
	 */
92
	public function updateName($id, $name) {
93
		$person = $this->personMapper->find ($this->userId, $id);
94
		$person->setName($name);
95
		$this->personMapper->update($person);
96
97
		$newPerson = $this->personMapper->find($this->userId, $id);
98
		return new DataResponse($newPerson);
99
	}
100
101
	private function getThumbUrl($faceId) {
102
		$params = [];
103
		$params['id'] = $faceId;
104
		$params['size'] = 50;
105
		return $this->urlGenerator->linkToRoute('facerecognition.face.getThumb', $params);
106
	}
107
108
	private function getRedirectToFileUrl($fileId) {
109
		$uid        = $this->userSession->getUser()->getUID();
110
		$baseFolder = $this->rootFolder->getUserFolder($uid);
111
		$files      = $baseFolder->getById($fileId);
112
		$file       = current($files);
113
114
		$params = [];
115
		$params['dir'] = $baseFolder->getRelativePath($file->getParent()->getPath());
116
		$params['scrollto'] = $file->getName();
117
118
		return $this->urlGenerator->linkToRoute('files.view.index', $params);
119
	}
120
121
}
122