It seems like tmpfile() can also be of type false. However, the property $resource is declared as type resource. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
The expression return $this->resource could also return false which is incompatible with the documented return type resource. Did you maybe forget to handle an error condition?
If the returned type also contains false, it is an indicator that maybe an error condition leading to the specific return statement remains unhandled.
Loading history...
62
}
63
64
/**
65
* GETTERS / SETTERS.
66
*/
67
68
/**
69
* @param Datatable $datatable
70
*
71
* @return Export
72
*/
73
public function setDatatable(Datatable $datatable): self
74
{
75
$this->datatable = $datatable;
76
77
return $this;
78
}
79
80
/**
81
* @param string $delimiter
82
*
83
* @return Export
84
*/
85
public function setDelimiter(string $delimiter): self
mathieupetrini /
doctrinedatatable
Loading history...
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.